* [PATCH] x86/boot/compressed/64: Remove unused variable
@ 2019-07-16 13:17 Zhenzhong Duan
2019-07-17 14:34 ` Kirill A. Shutemov
2019-07-18 19:47 ` [tip:x86/urgent] " tip-bot for Zhenzhong Duan
0 siblings, 2 replies; 4+ messages in thread
From: Zhenzhong Duan @ 2019-07-16 13:17 UTC (permalink / raw)
To: linux-kernel
Cc: x86, Zhenzhong Duan, Kirill A. Shutemov, Peter Zijlstra,
Thomas Gleixner, Ingo Molnar, Borislav Petkov
Fix gcc warning:
arch/x86/boot/compressed/pgtable_64.c: In function 'find_trampoline_placement':
arch/x86/boot/compressed/pgtable_64.c:43:16: warning: unused variable 'trampoline_start' [-Wunused-variable]
unsigned long trampoline_start;
^
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
---
arch/x86/boot/compressed/pgtable_64.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/boot/compressed/pgtable_64.c b/arch/x86/boot/compressed/pgtable_64.c
index f8debf7..5f2d030 100644
--- a/arch/x86/boot/compressed/pgtable_64.c
+++ b/arch/x86/boot/compressed/pgtable_64.c
@@ -40,7 +40,6 @@ struct paging_config {
static unsigned long find_trampoline_placement(void)
{
unsigned long bios_start = 0, ebda_start = 0;
- unsigned long trampoline_start;
struct boot_e820_entry *entry;
char *signature;
int i;
--
1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] x86/boot/compressed/64: Remove unused variable
2019-07-16 13:17 [PATCH] x86/boot/compressed/64: Remove unused variable Zhenzhong Duan
@ 2019-07-17 14:34 ` Kirill A. Shutemov
2019-07-18 8:13 ` Zhenzhong Duan
2019-07-18 19:47 ` [tip:x86/urgent] " tip-bot for Zhenzhong Duan
1 sibling, 1 reply; 4+ messages in thread
From: Kirill A. Shutemov @ 2019-07-17 14:34 UTC (permalink / raw)
To: Zhenzhong Duan
Cc: linux-kernel, x86, Peter Zijlstra, Thomas Gleixner, Ingo Molnar,
Borislav Petkov
On Tue, Jul 16, 2019 at 01:17:20PM +0000, Zhenzhong Duan wrote:
> Fix gcc warning:
>
> arch/x86/boot/compressed/pgtable_64.c: In function 'find_trampoline_placement':
> arch/x86/boot/compressed/pgtable_64.c:43:16: warning: unused variable 'trampoline_start' [-Wunused-variable]
> unsigned long trampoline_start;
> ^
>
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Borislav Petkov <bp@alien8.de>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Have no idea why I don't see the warning in my setup.
--
Kirill A. Shutemov
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86/boot/compressed/64: Remove unused variable
2019-07-17 14:34 ` Kirill A. Shutemov
@ 2019-07-18 8:13 ` Zhenzhong Duan
0 siblings, 0 replies; 4+ messages in thread
From: Zhenzhong Duan @ 2019-07-18 8:13 UTC (permalink / raw)
To: Kirill A. Shutemov
Cc: linux-kernel, x86, Peter Zijlstra, Thomas Gleixner, Ingo Molnar,
Borislav Petkov
On 2019/7/17 22:34, Kirill A. Shutemov wrote:
> On Tue, Jul 16, 2019 at 01:17:20PM +0000, Zhenzhong Duan wrote:
>> Fix gcc warning:
>>
>> arch/x86/boot/compressed/pgtable_64.c: In function 'find_trampoline_placement':
>> arch/x86/boot/compressed/pgtable_64.c:43:16: warning: unused variable 'trampoline_start' [-Wunused-variable]
>> unsigned long trampoline_start;
>> ^
>>
>> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
>> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>> Cc: Peter Zijlstra <peterz@infradead.org>
>> Cc: Thomas Gleixner <tglx@linutronix.de>
>> Cc: Ingo Molnar <mingo@redhat.com>
>> Cc: Borislav Petkov <bp@alien8.de>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>
> Have no idea why I don't see the warning in my setup.
Try below:
make bzImage EXTRA_CFLAGS="-Wunused-variable"
Zhenzhong
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip:x86/urgent] x86/boot/compressed/64: Remove unused variable
2019-07-16 13:17 [PATCH] x86/boot/compressed/64: Remove unused variable Zhenzhong Duan
2019-07-17 14:34 ` Kirill A. Shutemov
@ 2019-07-18 19:47 ` tip-bot for Zhenzhong Duan
1 sibling, 0 replies; 4+ messages in thread
From: tip-bot for Zhenzhong Duan @ 2019-07-18 19:47 UTC (permalink / raw)
To: linux-tip-commits
Cc: zhenzhong.duan, tglx, mingo, linux-kernel, kirill.shutemov, hpa
Commit-ID: 449f328637e3ca62461da04d60ccb35aa5aa21dc
Gitweb: https://git.kernel.org/tip/449f328637e3ca62461da04d60ccb35aa5aa21dc
Author: Zhenzhong Duan <zhenzhong.duan@oracle.com>
AuthorDate: Tue, 16 Jul 2019 21:17:20 +0800
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 18 Jul 2019 21:41:57 +0200
x86/boot/compressed/64: Remove unused variable
Fix gcc warning:
arch/x86/boot/compressed/pgtable_64.c: In function 'find_trampoline_placement':
arch/x86/boot/compressed/pgtable_64.c:43:16: warning: unused variable 'trampoline_start' [-Wunused-variable]
unsigned long trampoline_start;
^
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Link: https://lkml.kernel.org/r/1563283040-31101-1-git-send-email-zhenzhong.duan@oracle.com
---
arch/x86/boot/compressed/pgtable_64.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/boot/compressed/pgtable_64.c b/arch/x86/boot/compressed/pgtable_64.c
index f8debf7aeb4c..5f2d03067ae5 100644
--- a/arch/x86/boot/compressed/pgtable_64.c
+++ b/arch/x86/boot/compressed/pgtable_64.c
@@ -40,7 +40,6 @@ int cmdline_find_option_bool(const char *option);
static unsigned long find_trampoline_placement(void)
{
unsigned long bios_start = 0, ebda_start = 0;
- unsigned long trampoline_start;
struct boot_e820_entry *entry;
char *signature;
int i;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-18 19:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-16 13:17 [PATCH] x86/boot/compressed/64: Remove unused variable Zhenzhong Duan
2019-07-17 14:34 ` Kirill A. Shutemov
2019-07-18 8:13 ` Zhenzhong Duan
2019-07-18 19:47 ` [tip:x86/urgent] " tip-bot for Zhenzhong Duan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome