* [tip:x86/urgent] x86: vsyscall: Use NULL instead 0 for a pointer argument
[not found] <1333306084-3776-1-git-send-email-emilgoode@gmail.com>
@ 2012-04-06 10:03 ` tip-bot for Emil Goode
0 siblings, 0 replies; only message in thread
From: tip-bot for Emil Goode @ 2012-04-06 10:03 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, luto, hpa, mingo, emilgoode, tglx
Commit-ID: 46ed99d1b7c92920ce9e313152522847647aae4f
Gitweb: http://git.kernel.org/tip/46ed99d1b7c92920ce9e313152522847647aae4f
Author: Emil Goode <emilgoode@gmail.com>
AuthorDate: Sun, 1 Apr 2012 20:48:04 +0200
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 6 Apr 2012 11:49:59 +0200
x86: vsyscall: Use NULL instead 0 for a pointer argument
This patch silences the following sparse warning:
arch/x86/kernel/vsyscall_64.c:250:34:
warning: Using plain integer as NULL pointer
Signed-off-by: Emil Goode <emilgoode@gmail.com>
Acked-by: Andy Lutomirski <luto@amacapital.net>
Cc: john.stultz@linaro.org
Link: http://lkml.kernel.org/r/1333306084-3776-1-git-send-email-emilgoode@gmail.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/kernel/vsyscall_64.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kernel/vsyscall_64.c b/arch/x86/kernel/vsyscall_64.c
index f386dc4..7515cf0 100644
--- a/arch/x86/kernel/vsyscall_64.c
+++ b/arch/x86/kernel/vsyscall_64.c
@@ -216,9 +216,9 @@ bool emulate_vsyscall(struct pt_regs *regs, unsigned long address)
current_thread_info()->sig_on_uaccess_error = 1;
/*
- * 0 is a valid user pointer (in the access_ok sense) on 32-bit and
+ * NULL is a valid user pointer (in the access_ok sense) on 32-bit and
* 64-bit, so we don't need to special-case it here. For all the
- * vsyscalls, 0 means "don't write anything" not "write it at
+ * vsyscalls, NULL means "don't write anything" not "write it at
* address 0".
*/
ret = -EFAULT;
@@ -247,7 +247,7 @@ bool emulate_vsyscall(struct pt_regs *regs, unsigned long address)
ret = sys_getcpu((unsigned __user *)regs->di,
(unsigned __user *)regs->si,
- 0);
+ NULL);
break;
}
^ permalink raw reply [flat|nested] only message in thread