mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] x86: Revert "x86: get_bios_ebda_length()"
@ 2016-04-02  0:51 Guenter Roeck
  2016-04-13 11:47 ` [tip:x86/platform] x86/platform: Remove unused get_bios_ebda_length() function tip-bot for Guenter Roeck
  0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2016-04-02  0:51 UTC (permalink / raw)
  To: Thomas Gleixner
  Cc: Ingo Molnar, H. Peter Anvin, x86, linux-kernel, Guenter Roeck,
	Mike Waychison

This reverts commit 57d5f9f808b7 ("x86: get_bios_ebda_length()").

get_bios_ebda_length() uses min_t() without including linux/kernel.h.
This may result in build errors with some configurations. Since the
function is not used anywhere in the kernel, let's just drop it.

Cc: Mike Waychison <mikew@google.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 arch/x86/include/asm/bios_ebda.h | 21 ---------------------
 1 file changed, 21 deletions(-)

diff --git a/arch/x86/include/asm/bios_ebda.h b/arch/x86/include/asm/bios_ebda.h
index aa6a3170ab5a..2b00c776f223 100644
--- a/arch/x86/include/asm/bios_ebda.h
+++ b/arch/x86/include/asm/bios_ebda.h
@@ -17,27 +17,6 @@ static inline unsigned int get_bios_ebda(void)
 	return address;	/* 0 means none */
 }
 
-/*
- * Return the sanitized length of the EBDA in bytes, if it exists.
- */
-static inline unsigned int get_bios_ebda_length(void)
-{
-	unsigned int address;
-	unsigned int length;
-
-	address = get_bios_ebda();
-	if (!address)
-		return 0;
-
-	/* EBDA length is byte 0 of the EBDA (stored in KiB) */
-	length = *(unsigned char *)phys_to_virt(address);
-	length <<= 10;
-
-	/* Trim the length if it extends beyond 640KiB */
-	length = min_t(unsigned int, (640 * 1024) - address, length);
-	return length;
-}
-
 void reserve_ebda_region(void);
 
 #ifdef CONFIG_X86_CHECK_BIOS_CORRUPTION
-- 
2.5.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [tip:x86/platform] x86/platform: Remove unused get_bios_ebda_length() function
  2016-04-02  0:51 [PATCH] x86: Revert "x86: get_bios_ebda_length()" Guenter Roeck
@ 2016-04-13 11:47 ` tip-bot for Guenter Roeck
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Guenter Roeck @ 2016-04-13 11:47 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: hpa, linux, mingo, torvalds, mikew, linux-kernel, tglx, peterz

Commit-ID:  47a541c3e19374ec9f5d3d96730a922e8480dda5
Gitweb:     http://git.kernel.org/tip/47a541c3e19374ec9f5d3d96730a922e8480dda5
Author:     Guenter Roeck <linux@roeck-us.net>
AuthorDate: Fri, 1 Apr 2016 17:51:54 -0700
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 13 Apr 2016 11:43:09 +0200

x86/platform: Remove unused get_bios_ebda_length() function

get_bios_ebda_length() uses min_t() without including linux/kernel.h.

This may result in build errors with some configurations. Since the
function is not used anywhere in the kernel, let's just drop it.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Waychison <mikew@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1459558314-5625-1-git-send-email-linux@roeck-us.net
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/include/asm/bios_ebda.h | 21 ---------------------
 1 file changed, 21 deletions(-)

diff --git a/arch/x86/include/asm/bios_ebda.h b/arch/x86/include/asm/bios_ebda.h
index aa6a317..2b00c77 100644
--- a/arch/x86/include/asm/bios_ebda.h
+++ b/arch/x86/include/asm/bios_ebda.h
@@ -17,27 +17,6 @@ static inline unsigned int get_bios_ebda(void)
 	return address;	/* 0 means none */
 }
 
-/*
- * Return the sanitized length of the EBDA in bytes, if it exists.
- */
-static inline unsigned int get_bios_ebda_length(void)
-{
-	unsigned int address;
-	unsigned int length;
-
-	address = get_bios_ebda();
-	if (!address)
-		return 0;
-
-	/* EBDA length is byte 0 of the EBDA (stored in KiB) */
-	length = *(unsigned char *)phys_to_virt(address);
-	length <<= 10;
-
-	/* Trim the length if it extends beyond 640KiB */
-	length = min_t(unsigned int, (640 * 1024) - address, length);
-	return length;
-}
-
 void reserve_ebda_region(void);
 
 #ifdef CONFIG_X86_CHECK_BIOS_CORRUPTION

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-04-13 11:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-02  0:51 [PATCH] x86: Revert "x86: get_bios_ebda_length()" Guenter Roeck
2016-04-13 11:47 ` [tip:x86/platform] x86/platform: Remove unused get_bios_ebda_length() function tip-bot for Guenter Roeck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®