mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Jiri Olsa <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: mingo@kernel.org, acme@redhat.com, jolsa@redhat.com,
	linux-kernel@vger.kernel.org, tglx@linutronix.de,
	wangnan0@huawei.com, hpa@zytor.com
Subject: [tip:perf/core] perf tools: Make sure fixdep is built before libbpf
Date: Fri, 30 Oct 2015 02:13:31 -0700	[thread overview]
Message-ID: <tip-50f1e6d0431d3343cb506037c43ce623bd15581f@git.kernel.org> (raw)
In-Reply-To: <20151028204450.GA25553@krava.redhat.com>

Commit-ID:  50f1e6d0431d3343cb506037c43ce623bd15581f
Gitweb:     http://git.kernel.org/tip/50f1e6d0431d3343cb506037c43ce623bd15581f
Author:     Jiri Olsa <jolsa@redhat.com>
AuthorDate: Wed, 28 Oct 2015 21:44:50 +0100
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 29 Oct 2015 17:16:21 -0300

perf tools: Make sure fixdep is built before libbpf

While doing 'make -C tools/perf build-test':

   LD       fixdep-in.o
   LINK     fixdep
 /bin/sh: /home/acme/git/linux/tools/build/fixdep: Permission denied
 make[6]: *** [bpf.o] Error 1
 make[5]: *** [libbpf-in.o] Error 2
 make[4]: *** [/home/acme/git/linux/tools/lib/bpf/libbpf.a] Error 2
 make[4]: *** Waiting for unfinished jobs....

The fixdep tool needs to be built as the first binary.  Libraries are
built in paralel, so each of them needs to depend on fixdep target.

Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/20151028204450.GA25553@krava.redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/Makefile.perf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index 1e2e2d1..0d19d54 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -430,7 +430,7 @@ $(LIBAPI)-clean:
 	$(call QUIET_CLEAN, libapi)
 	$(Q)$(MAKE) -C $(LIB_DIR) O=$(OUTPUT) clean >/dev/null
 
-$(LIBBPF): FORCE
+$(LIBBPF): fixdep FORCE
 	$(Q)$(MAKE) -C $(BPF_DIR) O=$(OUTPUT) $(OUTPUT)libbpf.a
 
 $(LIBBPF)-clean:

      parent reply	other threads:[~2015-10-30  9:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-28 16:30 tools/build: fixdep versus tools/lib/bpf Arnaldo Carvalho de Melo
2015-10-28 20:13 ` Jiri Olsa
2015-10-28 20:37   ` Arnaldo Carvalho de Melo
2015-10-28 20:44     ` Jiri Olsa
2015-10-28 21:01       ` Arnaldo Carvalho de Melo
2015-10-29  2:39         ` Wangnan (F)
2015-10-30  9:13       ` tip-bot for Jiri Olsa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-50f1e6d0431d3343cb506037c43ce623bd15581f@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=acme@redhat.com \
    --cc=hpa@zytor.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome