Re: tools/build: fixdep versus tools/lib/bpf

[Arnaldo Carvalho de Melo <acme@kernel.org>]

Em Wed, Oct 28, 2015 at 09:13:52PM +0100, Jiri Olsa escreveu:
> On Wed, Oct 28, 2015 at 01:30:40PM -0300, Arnaldo Carvalho de Melo wrote:
> > Hi Jiri, Wang,
> > 
> > 	I'm getting these while doing 'make -C tools/perf build-test':
> > 
> >   LD       fixdep-in.o
> >   LINK     fixdep
> > /bin/sh: /home/acme/git/linux/tools/build/fixdep: Permission denied
> > make[6]: *** [bpf.o] Error 1
> > make[5]: *** [libbpf-in.o] Error 2
> > make[4]: *** [/home/acme/git/linux/tools/lib/bpf/libbpf.a] Error 2
> > make[4]: *** Waiting for unfinished jobs....
> > 
> > 
> > It happens at different tests, i.e. seems like a race somewhere in the
> > build system, can you take a look? It happens with my perf/ebpf branch.
> 
> could not reproduce, but looks like attached patch should help

I'll test this now, i.e. make it go thru a 'make -C tools/perf
build-test'.

In the interest of speeding up things, please provide an explanation of
why this should be applied, so that I can add it to the changeset log.

Thanks a bunch!

- Arnaldo
 
> jirka
> 
> 
> ---
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index 1e2e2d1d26b7..0d19d5447d6c 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -430,7 +430,7 @@ $(LIBAPI)-clean:
>  	$(call QUIET_CLEAN, libapi)
>  	$(Q)$(MAKE) -C $(LIB_DIR) O=$(OUTPUT) clean >/dev/null
>  
> -$(LIBBPF): FORCE
> +$(LIBBPF): fixdep FORCE
>  	$(Q)$(MAKE) -C $(BPF_DIR) O=$(OUTPUT) $(OUTPUT)libbpf.a
>  
>  $(LIBBPF)-clean: