mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] x86/tsc: Change Fast TSC calibration failed from error to warning
@ 2014-12-09  6:27 Alexandre Demers
  2015-01-23 10:00 ` [tip:x86/urgent] x86/tsc: Change Fast TSC calibration failed from error to info tip-bot for Alexandre Demers
  0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Demers @ 2014-12-09  6:27 UTC (permalink / raw)
  To: tglx; +Cc: linux-kernel, mingo, hpa, x86, stable

Most users see this message when booting without knowning that it is of 
mostly no importance and that TSC calibration may have succeeded by another 
way.

As explained thoroufly by Paul Bolle in 2012 
(http://lkml.iu.edu//hypermail/linux/kernel/1209.3/00224.html), 
"Fast TSC calibration failed" should not be considered as an error since 
other calibration methods are being tried afterward. At most, those send a 
warning if they fail (not an error). So let's change the message from error 
to warning.

It should also fix bug 75971: fast tsc calibration failed on ubuntu 14.04 LTS

Tested on kernel 3.18.

v2: fixed comment.

Cc: stable@vger.kernel.org
Signed-off-by: Alexandre Demers <alexandre.f.demers@gmail.com>

---
 arch/x86/kernel/tsc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index b6025f9..5a22022 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -617,7 +617,7 @@ static unsigned long quick_pit_calibrate(void)
 			goto success;
 		}
 	}
-	pr_err("Fast TSC calibration failed\n");
+	pr_warn("Fast TSC calibration failed\n");
 	return 0;
 
 success:
-- 
2.1.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [tip:x86/urgent] x86/tsc: Change Fast TSC calibration failed from error to info
  2014-12-09  6:27 [PATCH v2] x86/tsc: Change Fast TSC calibration failed from error to warning Alexandre Demers
@ 2015-01-23 10:00 ` tip-bot for Alexandre Demers
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Alexandre Demers @ 2015-01-23 10:00 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: hpa, alexandre.f.demers, tglx, mingo, linux-kernel

Commit-ID:  520452172e6b318f3a8bd9d4fe1e25066393de25
Gitweb:     http://git.kernel.org/tip/520452172e6b318f3a8bd9d4fe1e25066393de25
Author:     Alexandre Demers <alexandre.f.demers@gmail.com>
AuthorDate: Tue, 9 Dec 2014 01:27:50 -0500
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 23 Jan 2015 10:53:52 +0100

x86/tsc: Change Fast TSC calibration failed from error to info

Many users see this message when booting without knowning that it is
of no importance and that TSC calibration may have succeeded by
another way.

As explained by Paul Bolle in
http://lkml.kernel.org/r/1348488259.1436.22.camel@x61.thuisdomein

  "Fast TSC calibration failed" should not be considered as an error
  since other calibration methods are being tried afterward. At most,
  those send a warning if they fail (not an error). So let's change
  the message from error to warning.

[ tglx: Make if pr_info. It's really not important at all ]

Fixes: c767a54ba065 x86/debug: Add KERN_<LEVEL> to bare printks, convert printks to pr_<level>
Signed-off-by: Alexandre Demers <alexandre.f.demers@gmail.com>
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/1418106470-6906-1-git-send-email-alexandre.f.demers@gmail.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

---
 arch/x86/kernel/tsc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index b7e50bb..5054497 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -617,7 +617,7 @@ static unsigned long quick_pit_calibrate(void)
 			goto success;
 		}
 	}
-	pr_err("Fast TSC calibration failed\n");
+	pr_info("Fast TSC calibration failed\n");
 	return 0;
 
 success:

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-01-23 10:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-09  6:27 [PATCH v2] x86/tsc: Change Fast TSC calibration failed from error to warning Alexandre Demers
2015-01-23 10:00 ` [tip:x86/urgent] x86/tsc: Change Fast TSC calibration failed from error to info tip-bot for Alexandre Demers

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®