* [tip:tracing/syscalls] tracing/core: fix missing mutex unlock on tracing_set_tracer()
[not found] <1237151439-6755-5-git-send-email-fweisbec@gmail.com>
@ 2009-03-16 8:19 ` Frederic Weisbecker
0 siblings, 0 replies; only message in thread
From: Frederic Weisbecker @ 2009-03-16 8:19 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, fweisbec, tglx, mingo
Commit-ID: 59f586db98919d7d9c43527b26c8de1cdf9ed912
Gitweb: http://git.kernel.org/tip/59f586db98919d7d9c43527b26c8de1cdf9ed912
Author: Frederic Weisbecker <fweisbec@gmail.com>
AuthorDate: Sun, 15 Mar 2009 22:10:39 +0100
Commit: Ingo Molnar <mingo@elte.hu>
CommitDate: Mon, 16 Mar 2009 09:13:17 +0100
tracing/core: fix missing mutex unlock on tracing_set_tracer()
Impact: fix possible locking imbalance
In case of ring buffer resize failure, tracing_set_tracer forgot to
release trace_types_lock. Fix it.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <1237151439-6755-5-git-send-email-fweisbec@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/trace/trace.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index efe3202..c0cf946 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -2494,7 +2494,7 @@ static int tracing_set_tracer(const char *buf)
if (!ring_buffer_expanded) {
ret = tracing_resize_ring_buffer(trace_buf_size);
if (ret < 0)
- return ret;
+ goto out;
ret = 0;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-03-16 8:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1237151439-6755-5-git-send-email-fweisbec@gmail.com>
2009-03-16 8:19 ` [tip:tracing/syscalls] tracing/core: fix missing mutex unlock on tracing_set_tracer() Frederic Weisbecker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome