mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Marc Zyngier <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: stuart.yoder@freescale.com, tglx@linutronix.de, hpa@zytor.com,
	linux-kernel@vger.kernel.org, p.fedin@samsung.com,
	jason@lakedaemon.net, mingo@kernel.org, marc.zyngier@arm.com
Subject: [tip:irq/urgent] irqchip/gic-v3-its: Add missing cache flushes
Date: Tue, 15 Sep 2015 08:48:53 -0700	[thread overview]
Message-ID: <tip-5a9a8915c8888b615521b17d70a4342187eae60b@git.kernel.org> (raw)
In-Reply-To: <1442142873-20213-3-git-send-email-marc.zyngier@arm.com>

Commit-ID:  5a9a8915c8888b615521b17d70a4342187eae60b
Gitweb:     http://git.kernel.org/tip/5a9a8915c8888b615521b17d70a4342187eae60b
Author:     Marc Zyngier <marc.zyngier@arm.com>
AuthorDate: Sun, 13 Sep 2015 12:14:32 +0100
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 15 Sep 2015 17:06:29 +0200

irqchip/gic-v3-its: Add missing cache flushes

When the ITS is configured for non-cacheable transactions, make sure
that the allocated, zeroed memory is flushed to the Point of
Coherency, allowing the ITS to observe the zeros instead of random
garbage (or even get its own data overwritten by zeros being evicted
from the cache...).

Fixes: 241a386c7dbb "irqchip: gicv3-its: Use non-cacheable accesses when no shareability"
Reported-and-tested-by: Stuart Yoder <stuart.yoder@freescale.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: Pavel Fedin <p.fedin@samsung.com>
Cc: Jason Cooper <jason@lakedaemon.net>
Link: http://lkml.kernel.org/r/1442142873-20213-3-git-send-email-marc.zyngier@arm.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 drivers/irqchip/irq-gic-v3-its.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
index 26b55c5..ac7ae2b 100644
--- a/drivers/irqchip/irq-gic-v3-its.c
+++ b/drivers/irqchip/irq-gic-v3-its.c
@@ -898,8 +898,10 @@ retry_baser:
 			 * non-cacheable as well.
 			 */
 			shr = tmp & GITS_BASER_SHAREABILITY_MASK;
-			if (!shr)
+			if (!shr) {
 				cache = GITS_BASER_nC;
+				__flush_dcache_area(base, alloc_size);
+			}
 			goto retry_baser;
 		}
 
@@ -1140,6 +1142,8 @@ static struct its_device *its_create_device(struct its_node *its, u32 dev_id,
 		return NULL;
 	}
 
+	__flush_dcache_area(itt, sz);
+
 	dev->its = its;
 	dev->itt = itt;
 	dev->nr_ites = nr_ites;

  reply	other threads:[~2015-09-15 15:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-13 11:14 [PATCH 0/3] GIC fixes for 4.3-rc2 Marc Zyngier
2015-09-13 11:14 ` [PATCH 1/3] irqchip/GIC: Add workaround for aliased GIC400 Marc Zyngier
2015-09-15 15:48   ` [tip:irq/urgent] " tip-bot for Marc Zyngier
2015-09-13 11:14 ` [PATCH 2/3] irqchip/gic-v3-its: Add missing cache flushes Marc Zyngier
2015-09-15 15:48   ` tip-bot for Marc Zyngier [this message]
2015-09-13 11:14 ` [PATCH 3/3] irqchip/GICv2m: Fix GICv2m build warning on 32 bits Marc Zyngier
2015-09-15 15:49   ` [tip:irq/urgent] " tip-bot for Pavel Fedin
2015-09-24  8:19   ` [PATCH 3/3] " Pavel Fedin
2015-09-24 14:11     ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-5a9a8915c8888b615521b17d70a4342187eae60b@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=hpa@zytor.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mingo@kernel.org \
    --cc=p.fedin@samsung.com \
    --cc=stuart.yoder@freescale.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®