[PATCH] arch:x86/boot/compressed/error: Add declaration for necessary head file

[PATCH] arch:x86/boot/compressed/error: Add declaration for necessary head file

[Zhengyi Shen]

Add declaration for the error.h file to correct the sparse warnings.

Sparse warnings:
arch/x86/boot/compressed/error.c:8:6:
	warning: symbol 'warn' was not declared. Should it be static?
arch/x86/boot/compressed/error.c:15:6:
	warning: symbol 'error' was not declared. Should it be static?

Signed-off-by: Zhengyi Shen <shenzhengyi@gmail.com>
---
 arch/x86/boot/compressed/error.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/boot/compressed/error.c b/arch/x86/boot/compressed/error.c
index 6248740..3192202 100644
--- a/arch/x86/boot/compressed/error.c
+++ b/arch/x86/boot/compressed/error.c
@@ -4,6 +4,7 @@
  * memcpy() and memmove() are defined for the compressed boot environment.
  */
 #include "misc.h"
+#include "error.h"
 
 void warn(char *m)
 {
-- 
2.7.4

Re: [PATCH] arch:x86/boot/compressed/error: Add declaration for necessary head file

[Kees Cook]

On Wed, Mar 29, 2017 at 12:00 AM, Zhengyi Shen <shenzhengyi@gmail.com> wrote:
> Add declaration for the error.h file to correct the sparse warnings.
>
> Sparse warnings:
> arch/x86/boot/compressed/error.c:8:6:
>         warning: symbol 'warn' was not declared. Should it be static?
> arch/x86/boot/compressed/error.c:15:6:
>         warning: symbol 'error' was not declared. Should it be static?
>
> Signed-off-by: Zhengyi Shen <shenzhengyi@gmail.com>

Thanks!

Acked-by: Kees Cook <keescook@chromium.org>

-Kees

> ---
>  arch/x86/boot/compressed/error.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/boot/compressed/error.c b/arch/x86/boot/compressed/error.c
> index 6248740..3192202 100644
> --- a/arch/x86/boot/compressed/error.c
> +++ b/arch/x86/boot/compressed/error.c
> @@ -4,6 +4,7 @@
>   * memcpy() and memmove() are defined for the compressed boot environment.
>   */
>  #include "misc.h"
> +#include "error.h"
>
>  void warn(char *m)
>  {
> --
> 2.7.4
>



-- 
Kees Cook
Pixel Security

[tip:x86/urgent] x86/boot: Include missing header file

[tip-bot for Zhengyi Shen]

Commit-ID:  6b1cc946ddfcfc17d66c7d02eafa14deeb183437
Gitweb:     http://git.kernel.org/tip/6b1cc946ddfcfc17d66c7d02eafa14deeb183437
Author:     Zhengyi Shen <shenzhengyi@gmail.com>
AuthorDate: Wed, 29 Mar 2017 15:00:20 +0800
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 31 Mar 2017 10:43:42 +0200

x86/boot: Include missing header file

Sparse complains about missing forward declarations:

arch/x86/boot/compressed/error.c:8:6:
	warning: symbol 'warn' was not declared. Should it be static?
arch/x86/boot/compressed/error.c:15:6:
	warning: symbol 'error' was not declared. Should it be static?

Include the missing header file.

Signed-off-by: Zhengyi Shen <shenzhengyi@gmail.com>
Acked-by: Kess Cook <keescook@chromium.org>
Link: http://lkml.kernel.org/r/1490770820-24472-1-git-send-email-shenzhengyi@gmail.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

---
 arch/x86/boot/compressed/error.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/boot/compressed/error.c b/arch/x86/boot/compressed/error.c
index 6248740..3192202 100644
--- a/arch/x86/boot/compressed/error.c
+++ b/arch/x86/boot/compressed/error.c
@@ -4,6 +4,7 @@
  * memcpy() and memmove() are defined for the compressed boot environment.
  */
 #include "misc.h"
+#include "error.h"
 
 void warn(char *m)
 {

[tip:x86/boot] x86/boot: Fix Sparse warning by including required header file

[tip-bot for Zhengyi Shen]

Commit-ID:  5af218439f3a4c9ca7139a40e5d047fe1ea39551
Gitweb:     http://git.kernel.org/tip/5af218439f3a4c9ca7139a40e5d047fe1ea39551
Author:     Zhengyi Shen <shenzhengyi@gmail.com>
AuthorDate: Wed, 29 Mar 2017 15:00:20 +0800
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Fri, 31 Mar 2017 08:13:54 +0200

x86/boot: Fix Sparse warning by including required header file

Include declarations for various symbols defined in the error.h header file
to fix the following Sparse warnings:

  arch/x86/boot/compressed/error.c:8:6:
	warning: symbol 'warn' was not declared. Should it be static?
  arch/x86/boot/compressed/error.c:15:6:
	warning: symbol 'error' was not declared. Should it be static?

Signed-off-by: Zhengyi Shen <shenzhengyi@gmail.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1490770820-24472-1-git-send-email-shenzhengyi@gmail.com
[ Fixed/enhanced the changelog. ]
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/boot/compressed/error.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/boot/compressed/error.c b/arch/x86/boot/compressed/error.c
index 6248740..3192202 100644
--- a/arch/x86/boot/compressed/error.c
+++ b/arch/x86/boot/compressed/error.c
@@ -4,6 +4,7 @@
  * memcpy() and memmove() are defined for the compressed boot environment.
  */
 #include "misc.h"
+#include "error.h"
 
 void warn(char *m)
 {