From: tip-bot for Andi Kleen <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: tglx@linutronix.de, mingo@kernel.org, acme@redhat.com,
linux-kernel@vger.kernel.org, hpa@zytor.com, jolsa@kernel.org,
ak@linux.intel.com
Subject: [tip:perf/urgent] perf hists browser: Clarify top/report browser help
Date: Sat, 21 Apr 2018 00:51:27 -0700 [thread overview]
Message-ID: <tip-6a02f06edea5a5910c787fd6c49b0552e8080e5d@git.kernel.org> (raw)
In-Reply-To: <20180406203812.3087-3-andi@firstfloor.org>
Commit-ID: 6a02f06edea5a5910c787fd6c49b0552e8080e5d
Gitweb: https://git.kernel.org/tip/6a02f06edea5a5910c787fd6c49b0552e8080e5d
Author: Andi Kleen <ak@linux.intel.com>
AuthorDate: Fri, 6 Apr 2018 13:38:10 -0700
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 18 Apr 2018 15:35:49 -0300
perf hists browser: Clarify top/report browser help
Clarify in the browser help that ESC in tui mode may go back to the
previous screen instead of just exiting (was not clear to me)
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Link: http://lkml.kernel.org/r/20180406203812.3087-3-andi@firstfloor.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/ui/browsers/hists.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
index 0eec06c105c6..e5f247247daa 100644
--- a/tools/perf/ui/browsers/hists.c
+++ b/tools/perf/ui/browsers/hists.c
@@ -2714,7 +2714,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
"h/?/F1 Show this window\n" \
"UP/DOWN/PGUP\n" \
"PGDN/SPACE Navigate\n" \
- "q/ESC/CTRL+C Exit browser\n\n" \
+ "q/ESC/CTRL+C Exit browser or go back to previous screen\n\n" \
"For multiple event sessions:\n\n" \
"TAB/UNTAB Switch events\n\n" \
"For symbolic views (--sort has sym):\n\n" \
next prev parent reply other threads:[~2018-04-21 7:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-06 20:38 Some minor fixes for perf user tools Andi Kleen
2018-04-06 20:38 ` [PATCH 1/4] perf, tools, mem: Allow all record/report options Andi Kleen
2018-04-21 7:50 ` [tip:perf/urgent] perf " tip-bot for Andi Kleen
2018-04-06 20:38 ` [PATCH 2/4] perf, tools: Clarify browser help Andi Kleen
2018-04-21 7:51 ` tip-bot for Andi Kleen [this message]
2018-04-06 20:38 ` [PATCH 3/4] perf, tools, record: Remove misleading error suggestion Andi Kleen
2018-04-21 7:51 ` [tip:perf/urgent] perf " tip-bot for Andi Kleen
2018-04-06 20:38 ` [PATCH 4/4] perf, tools, record: Remove suggestion to enable APIC Andi Kleen
2018-04-21 7:52 ` [tip:perf/urgent] perf " tip-bot for Andi Kleen
2018-04-13 13:13 ` Some minor fixes for perf user tools Jiri Olsa
2018-04-13 14:33 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-6a02f06edea5a5910c787fd6c49b0552e8080e5d@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome