mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Andi Kleen <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, jolsa@kernel.org, hpa@zytor.com,
	ak@linux.intel.com, mingo@kernel.org, tglx@linutronix.de,
	linux-kernel@vger.kernel.org
Subject: [tip:perf/urgent] perf record: Remove misleading error suggestion
Date: Sat, 21 Apr 2018 00:51:55 -0700	[thread overview]
Message-ID: <tip-ec3948451e0ba317e66873b48d6cc51d701d4eb0@git.kernel.org> (raw)
In-Reply-To: <20180406203812.3087-4-andi@firstfloor.org>

Commit-ID:  ec3948451e0ba317e66873b48d6cc51d701d4eb0
Gitweb:     https://git.kernel.org/tip/ec3948451e0ba317e66873b48d6cc51d701d4eb0
Author:     Andi Kleen <ak@linux.intel.com>
AuthorDate: Fri, 6 Apr 2018 13:38:11 -0700
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 18 Apr 2018 15:35:49 -0300

perf record: Remove misleading error suggestion

When perf record encounters an error setting up an event it suggests
to enable CONFIG_PERF_EVENTS. This is misleading because:

- Usually it is enabled (it is really hard to disable on x86)

- The problem is usually somewhere else, e.g. the CPU is not supported
or an invalid configuration has been used.

Remove the misleading suggestion.

Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Link: http://lkml.kernel.org/r/20180406203812.3087-4-andi@firstfloor.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/evsel.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index 1ac8d9236efd..66b62570c855 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -2894,8 +2894,7 @@ int perf_evsel__open_strerror(struct perf_evsel *evsel, struct target *target,
 
 	return scnprintf(msg, size,
 	"The sys_perf_event_open() syscall returned with %d (%s) for event (%s).\n"
-	"/bin/dmesg may provide additional information.\n"
-	"No CONFIG_PERF_EVENTS=y kernel support configured?",
+	"/bin/dmesg | grep -i perf may provide additional information.\n",
 			 err, str_error_r(err, sbuf, sizeof(sbuf)),
 			 perf_evsel__name(evsel));
 }

  reply	other threads:[~2018-04-21  7:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-06 20:38 Some minor fixes for perf user tools Andi Kleen
2018-04-06 20:38 ` [PATCH 1/4] perf, tools, mem: Allow all record/report options Andi Kleen
2018-04-21  7:50   ` [tip:perf/urgent] perf " tip-bot for Andi Kleen
2018-04-06 20:38 ` [PATCH 2/4] perf, tools: Clarify browser help Andi Kleen
2018-04-21  7:51   ` [tip:perf/urgent] perf hists browser: Clarify top/report " tip-bot for Andi Kleen
2018-04-06 20:38 ` [PATCH 3/4] perf, tools, record: Remove misleading error suggestion Andi Kleen
2018-04-21  7:51   ` tip-bot for Andi Kleen [this message]
2018-04-06 20:38 ` [PATCH 4/4] perf, tools, record: Remove suggestion to enable APIC Andi Kleen
2018-04-21  7:52   ` [tip:perf/urgent] perf " tip-bot for Andi Kleen
2018-04-13 13:13 ` Some minor fixes for perf user tools Jiri Olsa
2018-04-13 14:33   ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-ec3948451e0ba317e66873b48d6cc51d701d4eb0@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=acme@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome