* [PATCH] kernel/posix-cpu-timers.c: fix sparse warning
@ 2009-04-29 23:14 H Hartley Sweeten
2009-04-30 6:24 ` [tip:core/urgent] " tip-bot for H Hartley Sweeten
0 siblings, 1 reply; 2+ messages in thread
From: H Hartley Sweeten @ 2009-04-29 23:14 UTC (permalink / raw)
To: linux-kernel; +Cc: subrata
Sparse reports the following in kernel/posix-cpu-timers.c:
warning: symbol 'firing' shadows an earlier one
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Subrata Modak <subrata@linux.vnet.ibm.com>
---
diff --git a/kernel/posix-cpu-timers.c b/kernel/posix-cpu-timers.c
index c9dcf98..88f24ab 100644
--- a/kernel/posix-cpu-timers.c
+++ b/kernel/posix-cpu-timers.c
@@ -1420,17 +1420,17 @@ void run_posix_cpu_timers(struct task_struct *tsk)
* timer call will interfere.
*/
list_for_each_entry_safe(timer, next, &firing, it.cpu.entry) {
- int firing;
+ int cpu_firing;
spin_lock(&timer->it_lock);
list_del_init(&timer->it.cpu.entry);
- firing = timer->it.cpu.firing;
+ cpu_firing = timer->it.cpu.firing;
timer->it.cpu.firing = 0;
/*
* The firing flag is -1 if we collided with a reset
* of the timer, which already reported this
* almost-firing as an overrun. So don't generate an event.
*/
- if (likely(firing >= 0)) {
+ if (likely(cpu_firing >= 0)) {
cpu_timer_fire(timer);
}
spin_unlock(&timer->it_lock);
^ permalink raw reply [flat|nested] 2+ messages in thread* [tip:core/urgent] kernel/posix-cpu-timers.c: fix sparse warning
2009-04-29 23:14 [PATCH] kernel/posix-cpu-timers.c: fix sparse warning H Hartley Sweeten
@ 2009-04-30 6:24 ` tip-bot for H Hartley Sweeten
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for H Hartley Sweeten @ 2009-04-30 6:24 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, hartleys, tglx, subrata, hsweeten, mingo
Commit-ID: 6e85c5ba73c07b990798087e9b858c065db2b234
Gitweb: http://git.kernel.org/tip/6e85c5ba73c07b990798087e9b858c065db2b234
Author: H Hartley Sweeten <hartleys@visionengravers.com>
AuthorDate: Wed, 29 Apr 2009 19:14:32 -0400
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 30 Apr 2009 08:08:31 +0200
kernel/posix-cpu-timers.c: fix sparse warning
Sparse reports the following in kernel/posix-cpu-timers.c:
warning: symbol 'firing' shadows an earlier one
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Subrata Modak <subrata@linux.vnet.ibm.com>
LKML-Reference: <BD79186B4FD85F4B8E60E381CAEE1909016C1AFE@mi8nycmail19.Mi8.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/posix-cpu-timers.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/posix-cpu-timers.c b/kernel/posix-cpu-timers.c
index c9dcf98..bece7c0 100644
--- a/kernel/posix-cpu-timers.c
+++ b/kernel/posix-cpu-timers.c
@@ -1420,19 +1420,19 @@ void run_posix_cpu_timers(struct task_struct *tsk)
* timer call will interfere.
*/
list_for_each_entry_safe(timer, next, &firing, it.cpu.entry) {
- int firing;
+ int cpu_firing;
+
spin_lock(&timer->it_lock);
list_del_init(&timer->it.cpu.entry);
- firing = timer->it.cpu.firing;
+ cpu_firing = timer->it.cpu.firing;
timer->it.cpu.firing = 0;
/*
* The firing flag is -1 if we collided with a reset
* of the timer, which already reported this
* almost-firing as an overrun. So don't generate an event.
*/
- if (likely(firing >= 0)) {
+ if (likely(cpu_firing >= 0))
cpu_timer_fire(timer);
- }
spin_unlock(&timer->it_lock);
}
}
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-30 6:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-29 23:14 [PATCH] kernel/posix-cpu-timers.c: fix sparse warning H Hartley Sweeten
2009-04-30 6:24 ` [tip:core/urgent] " tip-bot for H Hartley Sweeten
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®