* [PATCH] x86/irq: correct comment about i8259 initialization
@ 2013-09-04 1:25 Yanchuan Nian
2013-09-04 6:13 ` [tip:irq/core] x86/irq: Correct " tip-bot for Yanchuan Nian
0 siblings, 1 reply; 2+ messages in thread
From: Yanchuan Nian @ 2013-09-04 1:25 UTC (permalink / raw)
To: mingo; +Cc: linux-kernel, x86, yinghai, pavel, tglx, Yanchuan Nian
From: Yanchuan Nian <ycnian@gmail.com>
0x30-0x3f have been used for ISA interrupts on i386 since 5 years ago,
but some comments about i8259 initialization were missed to update
at the same time.
Signed-off-by: Yanchuan Nian <ycnian@gmail.com>
---
arch/x86/kernel/i8259.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/x86/kernel/i8259.c b/arch/x86/kernel/i8259.c
index 9a5c460..2e977b5 100644
--- a/arch/x86/kernel/i8259.c
+++ b/arch/x86/kernel/i8259.c
@@ -312,8 +312,7 @@ static void init_8259A(int auto_eoi)
*/
outb_pic(0x11, PIC_MASTER_CMD); /* ICW1: select 8259A-1 init */
- /* ICW2: 8259A-1 IR0-7 mapped to 0x30-0x37 on x86-64,
- to 0x20-0x27 on i386 */
+ /* ICW2: 8259A-1 IR0-7 mapped to 0x30-0x37 */
outb_pic(IRQ0_VECTOR, PIC_MASTER_IMR);
/* 8259A-1 (the master) has a slave on IR2 */
--
1.8.1.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* [tip:irq/core] x86/irq: Correct comment about i8259 initialization
2013-09-04 1:25 [PATCH] x86/irq: correct comment about i8259 initialization Yanchuan Nian
@ 2013-09-04 6:13 ` tip-bot for Yanchuan Nian
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Yanchuan Nian @ 2013-09-04 6:13 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, ycnian, tglx
Commit-ID: 7752572f18f98ee796e173334b088a1d621d2da4
Gitweb: http://git.kernel.org/tip/7752572f18f98ee796e173334b088a1d621d2da4
Author: Yanchuan Nian <ycnian@gmail.com>
AuthorDate: Wed, 4 Sep 2013 09:25:24 +0800
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 4 Sep 2013 07:46:04 +0200
x86/irq: Correct comment about i8259 initialization
0x30-0x3f have been used for ISA interrupts on i386 as well
since 5 years ago, but old comments about i8259 initialization
were still referring to the old i386 usage of this port range.
Signed-off-by: Yanchuan Nian <ycnian@gmail.com>
Cc: yinghai@kernel.org
Cc: pavel@suse.cz
Link: http://lkml.kernel.org/r/1378257924-29446-1-git-send-email-ycnian@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/kernel/i8259.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/x86/kernel/i8259.c b/arch/x86/kernel/i8259.c
index 9a5c460..2e977b5 100644
--- a/arch/x86/kernel/i8259.c
+++ b/arch/x86/kernel/i8259.c
@@ -312,8 +312,7 @@ static void init_8259A(int auto_eoi)
*/
outb_pic(0x11, PIC_MASTER_CMD); /* ICW1: select 8259A-1 init */
- /* ICW2: 8259A-1 IR0-7 mapped to 0x30-0x37 on x86-64,
- to 0x20-0x27 on i386 */
+ /* ICW2: 8259A-1 IR0-7 mapped to 0x30-0x37 */
outb_pic(IRQ0_VECTOR, PIC_MASTER_IMR);
/* 8259A-1 (the master) has a slave on IR2 */
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-04 6:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-04 1:25 [PATCH] x86/irq: correct comment about i8259 initialization Yanchuan Nian
2013-09-04 6:13 ` [tip:irq/core] x86/irq: Correct " tip-bot for Yanchuan Nian
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome