* [PATCH] x86/boot/video: move video_segment variable to video.c
@ 2015-01-24 18:11 Alexander Kuleshov
2015-02-19 0:29 ` [tip:x86/boot] x86/boot/video: Move the 'video_segment' " tip-bot for Alexander Kuleshov
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Kuleshov @ 2015-01-24 18:11 UTC (permalink / raw)
To: Thomas Gleixner, H. Peter Anvin, Martin Mares, Ingo Molnar
Cc: x86, linux-kernel, Alexander Kuleshov
It's only user of the video_segment variable, so move it to video.c
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
arch/x86/boot/video-mode.c | 4 +---
arch/x86/boot/video.c | 2 ++
arch/x86/boot/video.h | 1 -
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/arch/x86/boot/video-mode.c b/arch/x86/boot/video-mode.c
index 748e8d0..aa8a96b 100644
--- a/arch/x86/boot/video-mode.c
+++ b/arch/x86/boot/video-mode.c
@@ -22,10 +22,8 @@
/*
* Common variables
*/
-int adapter; /* 0=CGA/MDA/HGC, 1=EGA, 2=VGA+ */
-u16 video_segment;
+int adapter; /* 0=CGA/MDA/HGC, 1=EGA, 2=VGA+ */
int force_x, force_y; /* Don't query the BIOS for cols/rows */
-
int do_restore; /* Screen contents changed during mode flip */
int graphic_mode; /* Graphic mode with linear frame buffer */
diff --git a/arch/x86/boot/video.c b/arch/x86/boot/video.c
index 43eda28..05111bb 100644
--- a/arch/x86/boot/video.c
+++ b/arch/x86/boot/video.c
@@ -17,6 +17,8 @@
#include "video.h"
#include "vesa.h"
+static u16 video_segment;
+
static void store_cursor_position(void)
{
struct biosregs ireg, oreg;
diff --git a/arch/x86/boot/video.h b/arch/x86/boot/video.h
index 0bb2549..b54e032 100644
--- a/arch/x86/boot/video.h
+++ b/arch/x86/boot/video.h
@@ -91,7 +91,6 @@ int mode_defined(u16 mode); /* video.c */
#define ADAPTER_VGA 2
extern int adapter;
-extern u16 video_segment;
extern int force_x, force_y; /* Don't query the BIOS for cols/rows */
extern int do_restore; /* Restore screen contents */
extern int graphic_mode; /* Graphics mode with linear frame buffer */
--
2.3.0.rc1.275.g028c360
^ permalink raw reply [flat|nested] 2+ messages in thread
* [tip:x86/boot] x86/boot/video: Move the 'video_segment' variable to video.c
2015-01-24 18:11 [PATCH] x86/boot/video: move video_segment variable to video.c Alexander Kuleshov
@ 2015-02-19 0:29 ` tip-bot for Alexander Kuleshov
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Alexander Kuleshov @ 2015-02-19 0:29 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, kuleshovmail, hpa, mingo, mj, tglx
Commit-ID: 79287cf8778df21e5ad6c3ac01615e02cf9dbae6
Gitweb: http://git.kernel.org/tip/79287cf8778df21e5ad6c3ac01615e02cf9dbae6
Author: Alexander Kuleshov <kuleshovmail@gmail.com>
AuthorDate: Sun, 25 Jan 2015 00:11:32 +0600
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 19 Feb 2015 00:25:05 +0100
x86/boot/video: Move the 'video_segment' variable to video.c
video.c is the only real user of the 'video_segment' variable,
so move it to video.c and make it static.
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Martin Mares <mj@ucw.cz>
Link: http://lkml.kernel.org/r/1422123092-28750-1-git-send-email-kuleshovmail@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/boot/video-mode.c | 4 +---
arch/x86/boot/video.c | 2 ++
arch/x86/boot/video.h | 1 -
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/arch/x86/boot/video-mode.c b/arch/x86/boot/video-mode.c
index 748e8d0..aa8a96b 100644
--- a/arch/x86/boot/video-mode.c
+++ b/arch/x86/boot/video-mode.c
@@ -22,10 +22,8 @@
/*
* Common variables
*/
-int adapter; /* 0=CGA/MDA/HGC, 1=EGA, 2=VGA+ */
-u16 video_segment;
+int adapter; /* 0=CGA/MDA/HGC, 1=EGA, 2=VGA+ */
int force_x, force_y; /* Don't query the BIOS for cols/rows */
-
int do_restore; /* Screen contents changed during mode flip */
int graphic_mode; /* Graphic mode with linear frame buffer */
diff --git a/arch/x86/boot/video.c b/arch/x86/boot/video.c
index 43eda28..05111bb 100644
--- a/arch/x86/boot/video.c
+++ b/arch/x86/boot/video.c
@@ -17,6 +17,8 @@
#include "video.h"
#include "vesa.h"
+static u16 video_segment;
+
static void store_cursor_position(void)
{
struct biosregs ireg, oreg;
diff --git a/arch/x86/boot/video.h b/arch/x86/boot/video.h
index 0bb2549..b54e032 100644
--- a/arch/x86/boot/video.h
+++ b/arch/x86/boot/video.h
@@ -91,7 +91,6 @@ int mode_defined(u16 mode); /* video.c */
#define ADAPTER_VGA 2
extern int adapter;
-extern u16 video_segment;
extern int force_x, force_y; /* Don't query the BIOS for cols/rows */
extern int do_restore; /* Restore screen contents */
extern int graphic_mode; /* Graphics mode with linear frame buffer */
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-19 0:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-24 18:11 [PATCH] x86/boot/video: move video_segment variable to video.c Alexander Kuleshov
2015-02-19 0:29 ` [tip:x86/boot] x86/boot/video: Move the 'video_segment' " tip-bot for Alexander Kuleshov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome