* [PATCH] kernel/softirq.c: fix sparse warning
@ 2009-04-16 23:30 H Hartley Sweeten
2009-04-17 0:00 ` [tip:core/urgent] " tip-bot for H Hartley Sweeten
0 siblings, 1 reply; 2+ messages in thread
From: H Hartley Sweeten @ 2009-04-16 23:30 UTC (permalink / raw)
To: linux-kernel
Fix sparse warning in kernel/softirq.c.
warning: do-while statement is not a compound statement
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
---
diff --git a/kernel/softirq.c b/kernel/softirq.c
index 2fecefa..b525dd3 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -472,9 +472,9 @@ void tasklet_kill(struct tasklet_struct *t)
printk("Attempt to kill tasklet from interrupt\n");
while (test_and_set_bit(TASKLET_STATE_SCHED, &t->state)) {
- do
+ do {
yield();
- while (test_bit(TASKLET_STATE_SCHED, &t->state));
+ } while (test_bit(TASKLET_STATE_SCHED, &t->state));
}
tasklet_unlock_wait(t);
clear_bit(TASKLET_STATE_SCHED, &t->state);
^ permalink raw reply [flat|nested] 2+ messages in thread* [tip:core/urgent] kernel/softirq.c: fix sparse warning
2009-04-16 23:30 [PATCH] kernel/softirq.c: fix sparse warning H Hartley Sweeten
@ 2009-04-17 0:00 ` tip-bot for H Hartley Sweeten
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for H Hartley Sweeten @ 2009-04-17 0:00 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, hartleys, tglx, hsweeten, mingo
Commit-ID: 79d381c9f2354b594dcab9b04dfcc0debf7294fe
Gitweb: http://git.kernel.org/tip/79d381c9f2354b594dcab9b04dfcc0debf7294fe
Author: H Hartley Sweeten <hartleys@visionengravers.com>
AuthorDate: Thu, 16 Apr 2009 19:30:18 -0400
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Fri, 17 Apr 2009 01:57:54 +0200
kernel/softirq.c: fix sparse warning
Fix sparse warning in kernel/softirq.c.
warning: do-while statement is not a compound statement
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
LKML-Reference: <BD79186B4FD85F4B8E60E381CAEE1909015F9033@mi8nycmail19.Mi8.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/softirq.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/softirq.c b/kernel/softirq.c
index 2fecefa..b525dd3 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -472,9 +472,9 @@ void tasklet_kill(struct tasklet_struct *t)
printk("Attempt to kill tasklet from interrupt\n");
while (test_and_set_bit(TASKLET_STATE_SCHED, &t->state)) {
- do
+ do {
yield();
- while (test_bit(TASKLET_STATE_SCHED, &t->state));
+ } while (test_bit(TASKLET_STATE_SCHED, &t->state));
}
tasklet_unlock_wait(t);
clear_bit(TASKLET_STATE_SCHED, &t->state);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-17 0:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-16 23:30 [PATCH] kernel/softirq.c: fix sparse warning H Hartley Sweeten
2009-04-17 0:00 ` [tip:core/urgent] " tip-bot for H Hartley Sweeten
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®