* [PATCH] perf/x86: test_aperfmperf and test_intel should be static
@ 2015-09-24 11:48 Geliang Tang
2015-09-25 12:22 ` [tip:perf/urgent] perf/x86: Change test_aperfmperf() and test_intel() to static tip-bot for Geliang Tang
0 siblings, 1 reply; 2+ messages in thread
From: Geliang Tang @ 2015-09-24 11:48 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Thomas Gleixner, H. Peter Anvin
Cc: Geliang Tang, x86, linux-kernel
Fixes the following sparse warnings:
arch/x86/kernel/cpu/perf_event_msr.c:13:6: warning: symbol
'test_aperfmperf' was not declared. Should it be static?
arch/x86/kernel/cpu/perf_event_msr.c:18:6: warning: symbol
'test_intel' was not declared. Should it be static?
Signed-off-by: Geliang Tang <geliangtang@163.com>
---
arch/x86/kernel/cpu/perf_event_msr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/cpu/perf_event_msr.c b/arch/x86/kernel/cpu/perf_event_msr.c
index 086b12e..f32ac13 100644
--- a/arch/x86/kernel/cpu/perf_event_msr.c
+++ b/arch/x86/kernel/cpu/perf_event_msr.c
@@ -10,12 +10,12 @@ enum perf_msr_id {
PERF_MSR_EVENT_MAX,
};
-bool test_aperfmperf(int idx)
+static bool test_aperfmperf(int idx)
{
return boot_cpu_has(X86_FEATURE_APERFMPERF);
}
-bool test_intel(int idx)
+static bool test_intel(int idx)
{
if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL ||
boot_cpu_data.x86 != 6)
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [tip:perf/urgent] perf/x86: Change test_aperfmperf() and test_intel() to static
2015-09-24 11:48 [PATCH] perf/x86: test_aperfmperf and test_intel should be static Geliang Tang
@ 2015-09-25 12:22 ` tip-bot for Geliang Tang
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Geliang Tang @ 2015-09-25 12:22 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, tglx, a.p.zijlstra, mingo, peterz, torvalds,
geliangtang, acme, hpa
Commit-ID: 7e5560a5648ab2bce7199c73b9c2a51b846f5541
Gitweb: http://git.kernel.org/tip/7e5560a5648ab2bce7199c73b9c2a51b846f5541
Author: Geliang Tang <geliangtang@163.com>
AuthorDate: Thu, 24 Sep 2015 04:48:53 -0700
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Fri, 25 Sep 2015 09:42:40 +0200
perf/x86: Change test_aperfmperf() and test_intel() to static
Fixes the following sparse warnings:
arch/x86/kernel/cpu/perf_event_msr.c:13:6: warning: symbol
'test_aperfmperf' was not declared. Should it be static?
arch/x86/kernel/cpu/perf_event_msr.c:18:6: warning: symbol
'test_intel' was not declared. Should it be static?
Signed-off-by: Geliang Tang <geliangtang@163.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/4588e8ab09638458f2451af572827108be3b4a36.1443123796.git.geliangtang@163.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/kernel/cpu/perf_event_msr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/cpu/perf_event_msr.c b/arch/x86/kernel/cpu/perf_event_msr.c
index 086b12e..f32ac13 100644
--- a/arch/x86/kernel/cpu/perf_event_msr.c
+++ b/arch/x86/kernel/cpu/perf_event_msr.c
@@ -10,12 +10,12 @@ enum perf_msr_id {
PERF_MSR_EVENT_MAX,
};
-bool test_aperfmperf(int idx)
+static bool test_aperfmperf(int idx)
{
return boot_cpu_has(X86_FEATURE_APERFMPERF);
}
-bool test_intel(int idx)
+static bool test_intel(int idx)
{
if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL ||
boot_cpu_data.x86 != 6)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-25 12:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-24 11:48 [PATCH] perf/x86: test_aperfmperf and test_intel should be static Geliang Tang
2015-09-25 12:22 ` [tip:perf/urgent] perf/x86: Change test_aperfmperf() and test_intel() to static tip-bot for Geliang Tang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome