[PATCH] x86/mmiotrace: remove redundant instruction prefix checks

[PATCH] x86/mmiotrace: remove redundant instruction prefix checks

[Akinobu Mita]

Get rid of the duplicated entries in prefix_codes[] to eliminate
redundant checks by skip_prefix().

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org
---
 arch/x86/mm/pf_in.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/mm/pf_in.c b/arch/x86/mm/pf_in.c
index df3d5c8..308e325 100644
--- a/arch/x86/mm/pf_in.c
+++ b/arch/x86/mm/pf_in.c
@@ -34,7 +34,7 @@
 /* IA32 Manual 3, 2-1 */
 static unsigned char prefix_codes[] = {
 	0xF0, 0xF2, 0xF3, 0x2E, 0x36, 0x3E, 0x26, 0x64,
-	0x65, 0x2E, 0x3E, 0x66, 0x67
+	0x65, 0x66, 0x67
 };
 /* IA32 Manual 3, 3-432*/
 static unsigned int reg_rop[] = {
-- 
1.6.0.6

Re: [PATCH] x86/mmiotrace: remove redundant instruction prefix checks

[Pekka Paalanen]

On Tue, 18 May 2010 08:48:30 +0900
Akinobu Mita <akinobu.mita@gmail.com> wrote:

> Get rid of the duplicated entries in prefix_codes[] to eliminate
> redundant checks by skip_prefix().
> 
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: x86@kernel.org

Acked-by: Pekka Paalanen <pq@iki.fi>

> ---
>  arch/x86/mm/pf_in.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/mm/pf_in.c b/arch/x86/mm/pf_in.c
> index df3d5c8..308e325 100644
> --- a/arch/x86/mm/pf_in.c
> +++ b/arch/x86/mm/pf_in.c
> @@ -34,7 +34,7 @@
>  /* IA32 Manual 3, 2-1 */
>  static unsigned char prefix_codes[] = {
>  	0xF0, 0xF2, 0xF3, 0x2E, 0x36, 0x3E, 0x26, 0x64,
> -	0x65, 0x2E, 0x3E, 0x66, 0x67
> +	0x65, 0x66, 0x67
>  };
>  /* IA32 Manual 3, 3-432*/
>  static unsigned int reg_rop[] = {
> -- 
> 1.6.0.6
> 
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-kernel" in the body of a message to
> majordomo@vger.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html Please read the FAQ
> at  http://www.tux.org/lkml/
> 


-- 
Pekka Paalanen
http://www.iki.fi/pq/

[tip:perf/core] x86/mmiotrace: Remove redundant instruction prefix checks

[tip-bot for Akinobu Mita]

Commit-ID:  841bca1393d315d79077f272c2918423e36dc364
Gitweb:     http://git.kernel.org/tip/841bca1393d315d79077f272c2918423e36dc364
Author:     Akinobu Mita <akinobu.mita@gmail.com>
AuthorDate: Tue, 18 May 2010 08:48:30 +0900
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Sun, 23 May 2010 11:02:43 +0200

x86/mmiotrace: Remove redundant instruction prefix checks

Get rid of the duplicated entries in prefix_codes[]
to eliminate redundant checks by skip_prefix().

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Acked-by: Pekka Paalanen <pq@iki.fi>
LKML-Reference: <1274140110-5841-1-git-send-email-akinobu.mita@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/mm/pf_in.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/mm/pf_in.c b/arch/x86/mm/pf_in.c
index df3d5c8..308e325 100644
--- a/arch/x86/mm/pf_in.c
+++ b/arch/x86/mm/pf_in.c
@@ -34,7 +34,7 @@
 /* IA32 Manual 3, 2-1 */
 static unsigned char prefix_codes[] = {
 	0xF0, 0xF2, 0xF3, 0x2E, 0x36, 0x3E, 0x26, 0x64,
-	0x65, 0x2E, 0x3E, 0x66, 0x67
+	0x65, 0x66, 0x67
 };
 /* IA32 Manual 3, 3-432*/
 static unsigned int reg_rop[] = {