[PATCH] x86/apic: fix two slight indenting

[PATCH] x86/apic: fix two slight indenting

[Yi Wang]

There are two inconsistent indenting in calibrate_APIC_clock()
and activate_managed(). Remove the surplus TAB.

Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
Reviewed-by: Jiang Biao <jiang.biao2@zte.com.cn>
---
 arch/x86/kernel/apic/apic.c   | 2 +-
 arch/x86/kernel/apic/vector.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index 5071cc7..f222ebc 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -937,7 +937,7 @@ static int __init calibrate_APIC_clock(void)
 
 	if (levt->features & CLOCK_EVT_FEAT_DUMMY) {
 		pr_warning("APIC timer disabled due to verification failure\n");
-			return -1;
+		return -1;
 	}
 
 	return 0;
diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c
index b708f59..19e0b2f 100644
--- a/arch/x86/kernel/apic/vector.c
+++ b/arch/x86/kernel/apic/vector.c
@@ -433,7 +433,7 @@ static int activate_managed(struct irq_data *irqd)
 		pr_err("Managed startup irq %u, no vector available\n",
 		       irqd->irq);
 	}
-       return ret;
+	return ret;
 }
 
 static int x86_vector_activate(struct irq_domain *dom, struct irq_data *irqd,
-- 
1.8.3.1

Re: [PATCH] x86/apic: fix two slight indenting

[Steven Rostedt]

This looks like it should go through the trivial tree. Although I'm not
the maintainer of this code, it looks reasonable to me, and I'll give
my:

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve


On Fri, 27 Jul 2018 14:15:03 +0800
Yi Wang <wang.yi59@zte.com.cn> wrote:

> There are two inconsistent indenting in calibrate_APIC_clock()
> and activate_managed(). Remove the surplus TAB.
> 
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> Reviewed-by: Jiang Biao <jiang.biao2@zte.com.cn>
> ---
>  arch/x86/kernel/apic/apic.c   | 2 +-
>  arch/x86/kernel/apic/vector.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
> index 5071cc7..f222ebc 100644
> --- a/arch/x86/kernel/apic/apic.c
> +++ b/arch/x86/kernel/apic/apic.c
> @@ -937,7 +937,7 @@ static int __init calibrate_APIC_clock(void)
>  
>  	if (levt->features & CLOCK_EVT_FEAT_DUMMY) {
>  		pr_warning("APIC timer disabled due to verification failure\n");
> -			return -1;
> +		return -1;
>  	}
>  
>  	return 0;
> diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c
> index b708f59..19e0b2f 100644
> --- a/arch/x86/kernel/apic/vector.c
> +++ b/arch/x86/kernel/apic/vector.c
> @@ -433,7 +433,7 @@ static int activate_managed(struct irq_data *irqd)
>  		pr_err("Managed startup irq %u, no vector available\n",
>  		       irqd->irq);
>  	}
> -       return ret;
> +	return ret;
>  }
>  
>  static int x86_vector_activate(struct irq_domain *dom, struct irq_data *irqd,

Fwd: [PATCH] x86/apic: fix two slight indenting

[Andy Shevchenko]

Restore Cc list (it seems I sent it privately)

---------- Forwarded message ----------
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Fri, Jul 27, 2018 at 1:33 PM
Subject: Re: [PATCH] x86/apic: fix two slight indenting
To: Yi Wang <wang.yi59@zte.com.cn>


On Fri, Jul 27, 2018 at 9:15 AM, Yi Wang <wang.yi59@zte.com.cn> wrote:
> There are two inconsistent indenting in calibrate_APIC_clock()
> and activate_managed(). Remove the surplus TAB.

>         if (levt->features & CLOCK_EVT_FEAT_DUMMY) {
>                 pr_warning("APIC timer disabled due to verification failure\n");
> -                       return -1;
> +               return -1;
>         }

Slightly better fix is to replace with appropriate ERRNO constant at
the same time.

To avoid bigger change for now, just change this one and IIUC one more
above in the same function.

--
With Best Regards,
Andy Shevchenko


-- 
With Best Regards,
Andy Shevchenko

[tip:x86/apic] x86/apic: Trivial coding style fixes

[tip-bot for Yi Wang]

Commit-ID:  843c408905010fbc44a564d2de6a3cd68d986abf
Gitweb:     https://git.kernel.org/tip/843c408905010fbc44a564d2de6a3cd68d986abf
Author:     Yi Wang <wang.yi59@zte.com.cn>
AuthorDate: Fri, 27 Jul 2018 14:15:03 +0800
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 30 Jul 2018 19:56:30 +0200

x86/apic: Trivial coding style fixes

There is inconsistent indenting in calibrate_APIC_clock() and
activate_managed(). Remove the surplus TAB.

Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Jiang Biao <jiang.biao2@zte.com.cn>
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Cc: hpa@zytor.com
Cc: douly.fnst@cn.fujitsu.com
Cc: jgross@suse.com
Cc: ville.syrjala@linux.intel.com
Cc: len.brown@intel.com
Cc: gregkh@linuxfoundation.org
Cc: zhong.weidong@zte.com.cn
Link: https://lkml.kernel.org/r/1532672103-32250-1-git-send-email-wang.yi59@zte.com.cn

---
 arch/x86/kernel/apic/apic.c   | 2 +-
 arch/x86/kernel/apic/vector.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index 2aabd4cb0e3f..00011bc33263 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -937,7 +937,7 @@ static int __init calibrate_APIC_clock(void)
 
 	if (levt->features & CLOCK_EVT_FEAT_DUMMY) {
 		pr_warning("APIC timer disabled due to verification failure\n");
-			return -1;
+		return -1;
 	}
 
 	return 0;
diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c
index a75de0792942..c943499375c3 100644
--- a/arch/x86/kernel/apic/vector.c
+++ b/arch/x86/kernel/apic/vector.c
@@ -415,7 +415,7 @@ static int activate_managed(struct irq_data *irqd)
 		pr_err("Managed startup irq %u, no vector available\n",
 		       irqd->irq);
 	}
-       return ret;
+	return ret;
 }
 
 static int x86_vector_activate(struct irq_domain *dom, struct irq_data *irqd,