mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] X86/UAPI: Use __u64 instead of u64 in hyperv.h
@ 2018-02-20  7:39 KarimAllah Ahmed
  2018-02-20 10:23 ` [tip:x86/urgent] x86/headers/UAPI: Use __u64 instead of u64 in <uapi/asm/hyperv.h> tip-bot for KarimAllah Ahmed
  2018-02-20 16:48 ` [PATCH] X86/UAPI: Use __u64 instead of u64 in hyperv.h KY Srinivasan
  0 siblings, 2 replies; 3+ messages in thread
From: KarimAllah Ahmed @ 2018-02-20  7:39 UTC (permalink / raw)
  To: linux-kernel, devel, x86
  Cc: Stephen Hemminger, KarimAllah Ahmed, Haiyang Zhang, Ingo Molnar,
	H . Peter Anvin, Thomas Gleixner

... since u64 has a hidden header dependency that was not there before
using it (i.e. it breaks our VMM build). Also, __u64 is the right way to
expose the data type through UAPI.

Fixes: 93286261 ("x86/hyperv: Reenlightenment notifications support")
Signed-off-by: KarimAllah Ahmed <karahmed@amazon.de>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: x86@kernel.org
Cc: devel@linuxdriverproject.org
Cc: linux-kernel@vger.kernel.org
---
 arch/x86/include/uapi/asm/hyperv.h | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/arch/x86/include/uapi/asm/hyperv.h b/arch/x86/include/uapi/asm/hyperv.h
index 197c2e6..0994143 100644
--- a/arch/x86/include/uapi/asm/hyperv.h
+++ b/arch/x86/include/uapi/asm/hyperv.h
@@ -241,24 +241,24 @@
 #define HV_X64_MSR_REENLIGHTENMENT_CONTROL	0x40000106
 
 struct hv_reenlightenment_control {
-	u64 vector:8;
-	u64 reserved1:8;
-	u64 enabled:1;
-	u64 reserved2:15;
-	u64 target_vp:32;
+	__u64 vector:8;
+	__u64 reserved1:8;
+	__u64 enabled:1;
+	__u64 reserved2:15;
+	__u64 target_vp:32;
 };
 
 #define HV_X64_MSR_TSC_EMULATION_CONTROL	0x40000107
 #define HV_X64_MSR_TSC_EMULATION_STATUS		0x40000108
 
 struct hv_tsc_emulation_control {
-	u64 enabled:1;
-	u64 reserved:63;
+	__u64 enabled:1;
+	__u64 reserved:63;
 };
 
 struct hv_tsc_emulation_status {
-	u64 inprogress:1;
-	u64 reserved:63;
+	__u64 inprogress:1;
+	__u64 reserved:63;
 };
 
 #define HV_X64_MSR_HYPERCALL_ENABLE		0x00000001
-- 
2.7.4

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [tip:x86/urgent] x86/headers/UAPI: Use __u64 instead of u64 in <uapi/asm/hyperv.h>
  2018-02-20  7:39 [PATCH] X86/UAPI: Use __u64 instead of u64 in hyperv.h KarimAllah Ahmed
@ 2018-02-20 10:23 ` tip-bot for KarimAllah Ahmed
  2018-02-20 16:48 ` [PATCH] X86/UAPI: Use __u64 instead of u64 in hyperv.h KY Srinivasan
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for KarimAllah Ahmed @ 2018-02-20 10:23 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: karahmed, peterz, linux-kernel, hpa, torvalds, tglx, kys,
	sthemmin, mingo, haiyangz

Commit-ID:  894266466aa74a226e58e23975118ff6231dd2e4
Gitweb:     https://git.kernel.org/tip/894266466aa74a226e58e23975118ff6231dd2e4
Author:     KarimAllah Ahmed <karahmed@amazon.de>
AuthorDate: Tue, 20 Feb 2018 08:39:51 +0100
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 20 Feb 2018 08:54:47 +0100

x86/headers/UAPI: Use __u64 instead of u64 in <uapi/asm/hyperv.h>

... since u64 has a hidden header dependency that was not there before
using it (i.e. it breaks our VMM build).

Also, __u64 is the right way to expose data types through UAPI.

Signed-off-by: KarimAllah Ahmed <karahmed@amazon.de>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Cc: devel@linuxdriverproject.org
Fixes: 93286261 ("x86/hyperv: Reenlightenment notifications support")
Link: http://lkml.kernel.org/r/1519112391-23773-1-git-send-email-karahmed@amazon.de
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/include/uapi/asm/hyperv.h | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/arch/x86/include/uapi/asm/hyperv.h b/arch/x86/include/uapi/asm/hyperv.h
index 197c2e6..0994143 100644
--- a/arch/x86/include/uapi/asm/hyperv.h
+++ b/arch/x86/include/uapi/asm/hyperv.h
@@ -241,24 +241,24 @@
 #define HV_X64_MSR_REENLIGHTENMENT_CONTROL	0x40000106
 
 struct hv_reenlightenment_control {
-	u64 vector:8;
-	u64 reserved1:8;
-	u64 enabled:1;
-	u64 reserved2:15;
-	u64 target_vp:32;
+	__u64 vector:8;
+	__u64 reserved1:8;
+	__u64 enabled:1;
+	__u64 reserved2:15;
+	__u64 target_vp:32;
 };
 
 #define HV_X64_MSR_TSC_EMULATION_CONTROL	0x40000107
 #define HV_X64_MSR_TSC_EMULATION_STATUS		0x40000108
 
 struct hv_tsc_emulation_control {
-	u64 enabled:1;
-	u64 reserved:63;
+	__u64 enabled:1;
+	__u64 reserved:63;
 };
 
 struct hv_tsc_emulation_status {
-	u64 inprogress:1;
-	u64 reserved:63;
+	__u64 inprogress:1;
+	__u64 reserved:63;
 };
 
 #define HV_X64_MSR_HYPERCALL_ENABLE		0x00000001

^ permalink raw reply	[flat|nested] 3+ messages in thread
* RE: [PATCH] X86/UAPI: Use __u64 instead of u64 in hyperv.h
  2018-02-20  7:39 [PATCH] X86/UAPI: Use __u64 instead of u64 in hyperv.h KarimAllah Ahmed
  2018-02-20 10:23 ` [tip:x86/urgent] x86/headers/UAPI: Use __u64 instead of u64 in <uapi/asm/hyperv.h> tip-bot for KarimAllah Ahmed
@ 2018-02-20 16:48 ` KY Srinivasan
  1 sibling, 0 replies; 3+ messages in thread
From: KY Srinivasan @ 2018-02-20 16:48 UTC (permalink / raw)
  To: KarimAllah Ahmed, linux-kernel, devel, x86
  Cc: Haiyang Zhang, Ingo Molnar, Stephen Hemminger, Thomas Gleixner,
	H . Peter Anvin



> -----Original Message-----
> From: KarimAllah Ahmed <karahmed@amazon.de>
> Sent: Monday, February 19, 2018 11:40 PM
> To: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org;
> x86@kernel.org
> Cc: KarimAllah Ahmed <karahmed@amazon.de>; KY Srinivasan
> <kys@microsoft.com>; Haiyang Zhang <haiyangz@microsoft.com>; Stephen
> Hemminger <sthemmin@microsoft.com>; Thomas Gleixner
> <tglx@linutronix.de>; Ingo Molnar <mingo@redhat.com>; H . Peter Anvin
> <hpa@zytor.com>
> Subject: [PATCH] X86/UAPI: Use __u64 instead of u64 in hyperv.h
> 
> ... since u64 has a hidden header dependency that was not there before
> using it (i.e. it breaks our VMM build). Also, __u64 is the right way to
> expose the data type through UAPI.
> 
> Fixes: 93286261 ("x86/hyperv: Reenlightenment notifications support")
> Signed-off-by: KarimAllah Ahmed <karahmed@amazon.de>
> Cc: K. Y. Srinivasan <kys@microsoft.com>
> Cc: Haiyang Zhang <haiyangz@microsoft.com>
> Cc: Stephen Hemminger <sthemmin@microsoft.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Cc: x86@kernel.org
> Cc: devel@linuxdriverproject.org
> Cc: linux-kernel@vger.kernel.org

Acked-by: K. Y. Srinivasan <kys@microsoft.com>
> ---
>  arch/x86/include/uapi/asm/hyperv.h | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/x86/include/uapi/asm/hyperv.h
> b/arch/x86/include/uapi/asm/hyperv.h
> index 197c2e6..0994143 100644
> --- a/arch/x86/include/uapi/asm/hyperv.h
> +++ b/arch/x86/include/uapi/asm/hyperv.h
> @@ -241,24 +241,24 @@
>  #define HV_X64_MSR_REENLIGHTENMENT_CONTROL	0x40000106
> 
>  struct hv_reenlightenment_control {
> -	u64 vector:8;
> -	u64 reserved1:8;
> -	u64 enabled:1;
> -	u64 reserved2:15;
> -	u64 target_vp:32;
> +	__u64 vector:8;
> +	__u64 reserved1:8;
> +	__u64 enabled:1;
> +	__u64 reserved2:15;
> +	__u64 target_vp:32;
>  };
> 
>  #define HV_X64_MSR_TSC_EMULATION_CONTROL	0x40000107
>  #define HV_X64_MSR_TSC_EMULATION_STATUS		0x40000108
> 
>  struct hv_tsc_emulation_control {
> -	u64 enabled:1;
> -	u64 reserved:63;
> +	__u64 enabled:1;
> +	__u64 reserved:63;
>  };
> 
>  struct hv_tsc_emulation_status {
> -	u64 inprogress:1;
> -	u64 reserved:63;
> +	__u64 inprogress:1;
> +	__u64 reserved:63;
>  };
> 
>  #define HV_X64_MSR_HYPERCALL_ENABLE		0x00000001
> --
> 2.7.4

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-20 16:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-20  7:39 [PATCH] X86/UAPI: Use __u64 instead of u64 in hyperv.h KarimAllah Ahmed
2018-02-20 10:23 ` [tip:x86/urgent] x86/headers/UAPI: Use __u64 instead of u64 in <uapi/asm/hyperv.h> tip-bot for KarimAllah Ahmed
2018-02-20 16:48 ` [PATCH] X86/UAPI: Use __u64 instead of u64 in hyperv.h KY Srinivasan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome