[PATCH] spinlock: indicate that a lockup is only suspected

[PATCH] spinlock: indicate that a lockup is only suspected

[Christian Borntraeger]

On an over-committed KVM system we got a
"BUG: spinlock lockup on CPU#2, swapper/2/0" on the heavily contended
virtio blk spinlock.
While we might want to reconsider the locking of virtio-blk (lock is
held while switching to the host) this patch tries to make the message
clearer: the lockup is only suspected

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
 lib/spinlock_debug.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/spinlock_debug.c b/lib/spinlock_debug.c
index 525d160..1d2be56 100644
--- a/lib/spinlock_debug.c
+++ b/lib/spinlock_debug.c
@@ -118,7 +118,7 @@ static void __spin_lock_debug(raw_spinlock_t *lock)
 		/* lockup suspected: */
 		if (print_once) {
 			print_once = 0;
-			spin_dump(lock, "lockup");
+			spin_dump(lock, "lockup suspected");
 #ifdef CONFIG_SMP
 			trigger_all_cpu_backtrace();
 #endif
-- 
1.7.10.3

[tip:core/urgent] spinlock: Indicate that a lockup is only suspected

[tip-bot for Christian Borntraeger]

Commit-ID:  8a173b1476d126674104c7c5c6cef0bcd824b001
Gitweb:     http://git.kernel.org/tip/8a173b1476d126674104c7c5c6cef0bcd824b001
Author:     Christian Borntraeger <borntraeger@de.ibm.com>
AuthorDate: Tue, 29 May 2012 11:18:44 +0200
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 6 Jun 2012 11:34:20 +0200

spinlock: Indicate that a lockup is only suspected

On an over-committed KVM system we got a:

  "BUG: spinlock lockup on CPU#2, swapper/2/0"

message on the heavily contended virtio blk spinlock.

While we might want to reconsider the locking of virtio-blk
(lock is held while switching to the host) this patch tries to
make the message clearer: the lockup is only suspected.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1338283124-7063-1-git-send-email-borntraeger@de.ibm.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 lib/spinlock_debug.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/spinlock_debug.c b/lib/spinlock_debug.c
index d0ec4f3..e91fbc2 100644
--- a/lib/spinlock_debug.c
+++ b/lib/spinlock_debug.c
@@ -118,7 +118,7 @@ static void __spin_lock_debug(raw_spinlock_t *lock)
 		/* lockup suspected: */
 		if (print_once) {
 			print_once = 0;
-			spin_dump(lock, "lockup");
+			spin_dump(lock, "lockup suspected");
 #ifdef CONFIG_SMP
 			trigger_all_cpu_backtrace();
 #endif