* [PATCH 2/3] perf/core: Move inline keyword at the beginning of declaration @ 2017-12-26 14:09 Mathieu Malaterre 2017-12-26 15:05 ` Arnaldo Carvalho de Melo 2018-06-26 20:23 ` [PATCH v2] " Mathieu Malaterre 0 siblings, 2 replies; 6+ messages in thread From: Mathieu Malaterre @ 2017-12-26 14:09 UTC (permalink / raw) Cc: Mathieu Malaterre, Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo, Alexander Shishkin, Jiri Olsa, Namhyung Kim, linux-kernel Fix non-fatal warning: kernel/events/core.c:6106:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration] static void __always_inline ^~~~~~ Signed-off-by: Mathieu Malaterre <malat@debian.org> --- kernel/events/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index 4df5b695bf0d..aa874d2b58b3 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -6103,7 +6103,7 @@ void perf_prepare_sample(struct perf_event_header *header, data->phys_addr = perf_virt_to_phys(data->addr); } -static void __always_inline +static __always_inline void __perf_event_output(struct perf_event *event, struct perf_sample_data *data, struct pt_regs *regs, -- 2.11.0 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] perf/core: Move inline keyword at the beginning of declaration 2017-12-26 14:09 [PATCH 2/3] perf/core: Move inline keyword at the beginning of declaration Mathieu Malaterre @ 2017-12-26 15:05 ` Arnaldo Carvalho de Melo 2017-12-26 18:23 ` Mathieu Malaterre 2018-06-26 20:23 ` [PATCH v2] " Mathieu Malaterre 1 sibling, 1 reply; 6+ messages in thread From: Arnaldo Carvalho de Melo @ 2017-12-26 15:05 UTC (permalink / raw) To: Mathieu Malaterre Cc: Peter Zijlstra, Ingo Molnar, Alexander Shishkin, Jiri Olsa, Namhyung Kim, linux-kernel Em Tue, Dec 26, 2017 at 03:09:13PM +0100, Mathieu Malaterre escreveu: > Fix non-fatal warning: > > kernel/events/core.c:6106:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration] > static void __always_inline > ^~~~~~ Can you please provide more context? When did this become a problem? What gcc version? - Arnaldo > Signed-off-by: Mathieu Malaterre <malat@debian.org> > --- > kernel/events/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/events/core.c b/kernel/events/core.c > index 4df5b695bf0d..aa874d2b58b3 100644 > --- a/kernel/events/core.c > +++ b/kernel/events/core.c > @@ -6103,7 +6103,7 @@ void perf_prepare_sample(struct perf_event_header *header, > data->phys_addr = perf_virt_to_phys(data->addr); > } > > -static void __always_inline > +static __always_inline void > __perf_event_output(struct perf_event *event, > struct perf_sample_data *data, > struct pt_regs *regs, > -- > 2.11.0 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] perf/core: Move inline keyword at the beginning of declaration 2017-12-26 15:05 ` Arnaldo Carvalho de Melo @ 2017-12-26 18:23 ` Mathieu Malaterre 2017-12-26 20:19 ` Arnaldo Carvalho de Melo 0 siblings, 1 reply; 6+ messages in thread From: Mathieu Malaterre @ 2017-12-26 18:23 UTC (permalink / raw) To: Arnaldo Carvalho de Melo Cc: Peter Zijlstra, Ingo Molnar, Alexander Shishkin, Jiri Olsa, Namhyung Kim, linux-kernel Hi Arnaldo, On Tue, Dec 26, 2017 at 4:05 PM, Arnaldo Carvalho de Melo <acme@kernel.org> wrote: > Em Tue, Dec 26, 2017 at 03:09:13PM +0100, Mathieu Malaterre escreveu: >> Fix non-fatal warning: >> >> kernel/events/core.c:6106:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration] >> static void __always_inline >> ^~~~~~ > > Can you please provide more context? When did this become a problem? > What gcc version? > I tend to use W=1 before submitting a patch since not everything is being caught by ./scripts/checkpatch.pl. So this trivial patch was simply a way for me to remove some warning pollution I was seeing on my branch (not clear why this specific warning is considered an error in other section of the linux tree). This is a custom pmac32 branch, gcc version is: $ powerpc-linux-gnu-gcc --version powerpc-linux-gnu-gcc (Debian 6.3.0-18) 6.3.0 20170516 Feel free to drop it if this is too much noise. Thanks > - Arnaldo > >> Signed-off-by: Mathieu Malaterre <malat@debian.org> >> --- >> kernel/events/core.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/kernel/events/core.c b/kernel/events/core.c >> index 4df5b695bf0d..aa874d2b58b3 100644 >> --- a/kernel/events/core.c >> +++ b/kernel/events/core.c >> @@ -6103,7 +6103,7 @@ void perf_prepare_sample(struct perf_event_header *header, >> data->phys_addr = perf_virt_to_phys(data->addr); >> } >> >> -static void __always_inline >> +static __always_inline void >> __perf_event_output(struct perf_event *event, >> struct perf_sample_data *data, >> struct pt_regs *regs, >> -- >> 2.11.0 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] perf/core: Move inline keyword at the beginning of declaration 2017-12-26 18:23 ` Mathieu Malaterre @ 2017-12-26 20:19 ` Arnaldo Carvalho de Melo 0 siblings, 0 replies; 6+ messages in thread From: Arnaldo Carvalho de Melo @ 2017-12-26 20:19 UTC (permalink / raw) To: Mathieu Malaterre Cc: Peter Zijlstra, Ingo Molnar, Alexander Shishkin, Jiri Olsa, Namhyung Kim, linux-kernel Em Tue, Dec 26, 2017 at 07:23:08PM +0100, Mathieu Malaterre escreveu: > Hi Arnaldo, > > On Tue, Dec 26, 2017 at 4:05 PM, Arnaldo Carvalho de Melo > <acme@kernel.org> wrote: > > Em Tue, Dec 26, 2017 at 03:09:13PM +0100, Mathieu Malaterre escreveu: > >> Fix non-fatal warning: > >> kernel/events/core.c:6106:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration] > >> static void __always_inline > >> ^~~~~~ > > Can you please provide more context? When did this become a problem? > > What gcc version? > I tend to use W=1 before submitting a patch since not everything is > being caught by ./scripts/checkpatch.pl. So this trivial patch was > simply a way for me to remove some warning pollution I was seeing on > my branch (not clear why this specific warning is considered an error > in other section of the linux tree). This is a custom pmac32 branch, > gcc version is: > $ powerpc-linux-gnu-gcc --version > powerpc-linux-gnu-gcc (Debian 6.3.0-18) 6.3.0 20170516 > Feel free to drop it if this is too much noise. Nah, I just like to have enough info on the cset as to where is that the problem takes place, which you now have provided and I'll add to the cset, thanks! - Arnaldo > Thanks > > > - Arnaldo > > > >> Signed-off-by: Mathieu Malaterre <malat@debian.org> > >> --- > >> kernel/events/core.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/kernel/events/core.c b/kernel/events/core.c > >> index 4df5b695bf0d..aa874d2b58b3 100644 > >> --- a/kernel/events/core.c > >> +++ b/kernel/events/core.c > >> @@ -6103,7 +6103,7 @@ void perf_prepare_sample(struct perf_event_header *header, > >> data->phys_addr = perf_virt_to_phys(data->addr); > >> } > >> > >> -static void __always_inline > >> +static __always_inline void > >> __perf_event_output(struct perf_event *event, > >> struct perf_sample_data *data, > >> struct pt_regs *regs, > >> -- > >> 2.11.0 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] perf/core: Move inline keyword at the beginning of declaration 2017-12-26 14:09 [PATCH 2/3] perf/core: Move inline keyword at the beginning of declaration Mathieu Malaterre 2017-12-26 15:05 ` Arnaldo Carvalho de Melo @ 2018-06-26 20:23 ` Mathieu Malaterre 2018-06-27 9:10 ` [tip:perf/urgent] " tip-bot for Mathieu Malaterre 1 sibling, 1 reply; 6+ messages in thread From: Mathieu Malaterre @ 2018-06-26 20:23 UTC (permalink / raw) To: Peter Zijlstra Cc: Ingo Molnar, Mathieu Malaterre, Ingo Molnar, Arnaldo Carvalho de Melo, Alexander Shishkin, Jiri Olsa, Namhyung Kim, linux-kernel Fix non-fatal warning triggered during compilation with W=1: kernel/events/core.c:6106:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration] static void __always_inline ^~~~~~ Signed-off-by: Mathieu Malaterre <malat@debian.org> --- v2: Explicit reference to W=1 kernel/events/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index 80cca2b30c4f..8f0434a9951a 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -6482,7 +6482,7 @@ void perf_prepare_sample(struct perf_event_header *header, data->phys_addr = perf_virt_to_phys(data->addr); } -static void __always_inline +static __always_inline void __perf_event_output(struct perf_event *event, struct perf_sample_data *data, struct pt_regs *regs, -- 2.11.0 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [tip:perf/urgent] perf/core: Move inline keyword at the beginning of declaration 2018-06-26 20:23 ` [PATCH v2] " Mathieu Malaterre @ 2018-06-27 9:10 ` tip-bot for Mathieu Malaterre 0 siblings, 0 replies; 6+ messages in thread From: tip-bot for Mathieu Malaterre @ 2018-06-27 9:10 UTC (permalink / raw) To: linux-tip-commits Cc: namhyung, torvalds, peterz, jolsa, malat, alexander.shishkin, acme, tglx, mingo, linux-kernel, hpa Commit-ID: 9331510135640429711afbd0c810686100824a79 Gitweb: https://git.kernel.org/tip/9331510135640429711afbd0c810686100824a79 Author: Mathieu Malaterre <malat@debian.org> AuthorDate: Tue, 26 Jun 2018 22:23:00 +0200 Committer: Ingo Molnar <mingo@kernel.org> CommitDate: Wed, 27 Jun 2018 09:55:58 +0200 perf/core: Move inline keyword at the beginning of declaration Fix non-fatal warning triggered during compilation with W=1: kernel/events/core.c:6106:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration] static void __always_inline ^~~~~~ Signed-off-by: Mathieu Malaterre <malat@debian.org> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Arnaldo Carvalho de Melo <acme@kernel.org> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Link: http://lkml.kernel.org/r/20180626202301.20270-1-malat@debian.org Signed-off-by: Ingo Molnar <mingo@kernel.org> --- kernel/events/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index 80cca2b30c4f..8f0434a9951a 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -6482,7 +6482,7 @@ void perf_prepare_sample(struct perf_event_header *header, data->phys_addr = perf_virt_to_phys(data->addr); } -static void __always_inline +static __always_inline void __perf_event_output(struct perf_event *event, struct perf_sample_data *data, struct pt_regs *regs, ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-06-27 9:10 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-12-26 14:09 [PATCH 2/3] perf/core: Move inline keyword at the beginning of declaration Mathieu Malaterre 2017-12-26 15:05 ` Arnaldo Carvalho de Melo 2017-12-26 18:23 ` Mathieu Malaterre 2017-12-26 20:19 ` Arnaldo Carvalho de Melo 2018-06-26 20:23 ` [PATCH v2] " Mathieu Malaterre 2018-06-27 9:10 ` [tip:perf/urgent] " tip-bot for Mathieu Malaterre
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
Powered by JetHome