[PATCH 1/3] perf help: Document missing options

[PATCH 1/3] perf help: Document missing options

[Sihyeon Jang]

Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Sihyeon Jang <uneedsihyeon@gmail.com>
---
 tools/perf/Documentation/perf-help.txt | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/tools/perf/Documentation/perf-help.txt b/tools/perf/Documentation/perf-help.txt
index 5143918..bb605af 100644
--- a/tools/perf/Documentation/perf-help.txt
+++ b/tools/perf/Documentation/perf-help.txt
@@ -7,7 +7,7 @@ perf-help - display help information about perf
 
 SYNOPSIS
 --------
-'perf help' [-a|--all] [COMMAND]
+'perf help' [--all] [--man|--web|--info] [COMMAND]
 
 DESCRIPTION
 -----------
@@ -33,6 +33,18 @@ OPTIONS
 	Prints all the available commands on the standard output. This
 	option supersedes any other option.
 
+-i::
+--info::
+	Shows info page.
+
+-m::
+--man::
+	Shows man page.
+
+-w::
+--web::
+	Shows manual in web browser.
+
 PERF
 ----
 Part of the linkperf:perf[1] suite
-- 
2.7.4

[PATCH 2/3] perf top: Document missing options

[Sihyeon Jang]

Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Sihyeon Jang <uneedsihyeon@gmail.com>
---
 tools/perf/Documentation/perf-top.txt | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tools/perf/Documentation/perf-top.txt b/tools/perf/Documentation/perf-top.txt
index 4353262..8a32cc7 100644
--- a/tools/perf/Documentation/perf-top.txt
+++ b/tools/perf/Documentation/perf-top.txt
@@ -268,6 +268,12 @@ INTERACTIVE PROMPTING KEYS
 [S]::
 	Stop annotation, return to full profile display.
 
+[K]::
+	Hide kernel symbols.
+
+[U]::
+	Hide user symbols.
+
 [z]::
 	Toggle event count zeroing across display updates.
 
-- 
2.7.4

Re: [PATCH 2/3] perf top: Document missing options

[Arnaldo Carvalho de Melo]

Em Sun, Nov 12, 2017 at 10:10:46AM +0900, Sihyeon Jang escreveu:
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Signed-off-by: Sihyeon Jang <uneedsihyeon@gmail.com>

applied
> ---
>  tools/perf/Documentation/perf-top.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/tools/perf/Documentation/perf-top.txt b/tools/perf/Documentation/perf-top.txt
> index 4353262..8a32cc7 100644
> --- a/tools/perf/Documentation/perf-top.txt
> +++ b/tools/perf/Documentation/perf-top.txt
> @@ -268,6 +268,12 @@ INTERACTIVE PROMPTING KEYS
>  [S]::
>  	Stop annotation, return to full profile display.
>  
> +[K]::
> +	Hide kernel symbols.
> +
> +[U]::
> +	Hide user symbols.
> +
>  [z]::
>  	Toggle event count zeroing across display updates.
>  
> -- 
> 2.7.4

[tip:perf/core] perf top: Document missing options

[tip-bot for Sihyeon Jang]

Commit-ID:  958964f803b27baffd238708842b527a1d30e110
Gitweb:     https://git.kernel.org/tip/958964f803b27baffd238708842b527a1d30e110
Author:     Sihyeon Jang <uneedsihyeon@gmail.com>
AuthorDate: Sun, 12 Nov 2017 10:10:46 +0900
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 16 Nov 2017 14:49:56 -0300

perf top: Document missing options

Signed-off-by: Sihyeon Jang <uneedsihyeon@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/1510449047-12941-2-git-send-email-uneedsihyeon@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/Documentation/perf-top.txt | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tools/perf/Documentation/perf-top.txt b/tools/perf/Documentation/perf-top.txt
index 4353262..8a32cc7 100644
--- a/tools/perf/Documentation/perf-top.txt
+++ b/tools/perf/Documentation/perf-top.txt
@@ -268,6 +268,12 @@ INTERACTIVE PROMPTING KEYS
 [S]::
 	Stop annotation, return to full profile display.
 
+[K]::
+	Hide kernel symbols.
+
+[U]::
+	Hide user symbols.
+
 [z]::
 	Toggle event count zeroing across display updates.
 

[PATCH 3/3] perf top: Remove a duplicate word

[Sihyeon Jang]

Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Sihyeon Jang <uneedsihyeon@gmail.com>
---
 tools/perf/builtin-top.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index adfeeb4..6fe5001 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -409,7 +409,7 @@ static void perf_top__print_mapped_keys(struct perf_top *top)
 	fprintf(stdout, "\t[S]     stop annotation.\n");
 
 	fprintf(stdout,
-		"\t[K]     hide kernel_symbols symbols.     \t(%s)\n",
+		"\t[K]     hide kernel symbols.             \t(%s)\n",
 		top->hide_kernel_symbols ? "yes" : "no");
 	fprintf(stdout,
 		"\t[U]     hide user symbols.               \t(%s)\n",
-- 
2.7.4

Re: [PATCH 3/3] perf top: Remove a duplicate word

[Arnaldo Carvalho de Melo]

Em Sun, Nov 12, 2017 at 10:10:47AM +0900, Sihyeon Jang escreveu:
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Signed-off-by: Sihyeon Jang <uneedsihyeon@gmail.com>

Thanks, applied.

- Arnaldo

> ---
>  tools/perf/builtin-top.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
> index adfeeb4..6fe5001 100644
> --- a/tools/perf/builtin-top.c
> +++ b/tools/perf/builtin-top.c
> @@ -409,7 +409,7 @@ static void perf_top__print_mapped_keys(struct perf_top *top)
>  	fprintf(stdout, "\t[S]     stop annotation.\n");
>  
>  	fprintf(stdout,
> -		"\t[K]     hide kernel_symbols symbols.     \t(%s)\n",
> +		"\t[K]     hide kernel symbols.             \t(%s)\n",
>  		top->hide_kernel_symbols ? "yes" : "no");
>  	fprintf(stdout,
>  		"\t[U]     hide user symbols.               \t(%s)\n",
> -- 
> 2.7.4

[tip:perf/core] perf top: Remove a duplicate word

[tip-bot for Sihyeon Jang]

Commit-ID:  8fce3743cea47db86dd13ab4c479158a872271e8
Gitweb:     https://git.kernel.org/tip/8fce3743cea47db86dd13ab4c479158a872271e8
Author:     Sihyeon Jang <uneedsihyeon@gmail.com>
AuthorDate: Sun, 12 Nov 2017 10:10:47 +0900
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 16 Nov 2017 14:49:56 -0300

perf top: Remove a duplicate word

Signed-off-by: Sihyeon Jang <uneedsihyeon@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/1510449047-12941-3-git-send-email-uneedsihyeon@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-top.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index 0789f95..68320ac 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -412,7 +412,7 @@ static void perf_top__print_mapped_keys(struct perf_top *top)
 	fprintf(stdout, "\t[S]     stop annotation.\n");
 
 	fprintf(stdout,
-		"\t[K]     hide kernel_symbols symbols.     \t(%s)\n",
+		"\t[K]     hide kernel symbols.             \t(%s)\n",
 		top->hide_kernel_symbols ? "yes" : "no");
 	fprintf(stdout,
 		"\t[U]     hide user symbols.               \t(%s)\n",

Re: [PATCH 1/3] perf help: Document missing options

[Arnaldo Carvalho de Melo]

Em Sun, Nov 12, 2017 at 10:10:45AM +0900, Sihyeon Jang escreveu:
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Signed-off-by: Sihyeon Jang <uneedsihyeon@gmail.com>
> ---
>  tools/perf/Documentation/perf-help.txt | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/Documentation/perf-help.txt b/tools/perf/Documentation/perf-help.txt
> index 5143918..bb605af 100644
> --- a/tools/perf/Documentation/perf-help.txt
> +++ b/tools/perf/Documentation/perf-help.txt
> @@ -7,7 +7,7 @@ perf-help - display help information about perf
>  
>  SYNOPSIS
>  --------
> -'perf help' [-a|--all] [COMMAND]
> +'perf help' [--all] [--man|--web|--info] [COMMAND]

Can you try figuring out if this actually works? I tried here and it
doesn't, its an area we took "for free" when we copied the initial
codebase from git.git, but I never looked at this area that much, now
that I try:

[acme@jouet linux]$ perf help
Config with no key for man viewer: childrenError: wrong config key-value pair top.children=true
[acme@jouet linux]$ 

Unsure if this is something that got broken by the 'perf config'
patches, Taeung?

- Arnaldo
  
>  DESCRIPTION
>  -----------
> @@ -33,6 +33,18 @@ OPTIONS
>  	Prints all the available commands on the standard output. This
>  	option supersedes any other option.
>  
> +-i::
> +--info::
> +	Shows info page.
> +
> +-m::
> +--man::
> +	Shows man page.
> +
> +-w::
> +--web::
> +	Shows manual in web browser.
> +
>  PERF
>  ----
>  Part of the linkperf:perf[1] suite
> -- 
> 2.7.4

Re: [PATCH 1/3] perf help: Document missing options

[Namhyung Kim]

Hi Arnaldo,

On Mon, Nov 13, 2017 at 03:29:56PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Sun, Nov 12, 2017 at 10:10:45AM +0900, Sihyeon Jang escreveu:
> > Cc: Jiri Olsa <jolsa@kernel.org>
> > Cc: Namhyung Kim <namhyung@kernel.org>
> > Signed-off-by: Sihyeon Jang <uneedsihyeon@gmail.com>
> > ---
> >  tools/perf/Documentation/perf-help.txt | 14 +++++++++++++-
> >  1 file changed, 13 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tools/perf/Documentation/perf-help.txt b/tools/perf/Documentation/perf-help.txt
> > index 5143918..bb605af 100644
> > --- a/tools/perf/Documentation/perf-help.txt
> > +++ b/tools/perf/Documentation/perf-help.txt
> > @@ -7,7 +7,7 @@ perf-help - display help information about perf
> >  
> >  SYNOPSIS
> >  --------
> > -'perf help' [-a|--all] [COMMAND]
> > +'perf help' [--all] [--man|--web|--info] [COMMAND]
> 
> Can you try figuring out if this actually works? I tried here and it
> doesn't, its an area we took "for free" when we copied the initial
> codebase from git.git, but I never looked at this area that much, now
> that I try:

Yeah, I'm not sure we need to keep it.


> 
> [acme@jouet linux]$ perf help
> Config with no key for man viewer: childrenError: wrong config key-value pair top.children=true
> [acme@jouet linux]$ 
> 
> Unsure if this is something that got broken by the 'perf config'
> patches, Taeung?

Looks like a bug in 8e99b6d4533c ("tools include: Adopt strstarts()
from the kernel").

Following patch should fix it:

Thanks,
Namhyung


>From 096b78b437b5758acc025498e88d73d9d471b3c0 Mon Sep 17 00:00:00 2001
From: Namhyung Kim <namhyung@kernel.org>
Date: Tue, 14 Nov 2017 09:10:43 +0900
Subject: [PATCH] perf help: Fix a bug during strstart() conversion

The commit 8e99b6d4533c changed prefixcmp() to strstart() but missed to
change the return value in some place.  It makes perf help print
annoying output even for sane config items like below:

  $ perf help
  '.root': unsupported man viewer sub key.
  ...

Fixes: 8e99b6d4533c ("tools include: Adopt strstarts() from the kernel")
Cc: Taeung Song <treeze.taeung@gmail.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/builtin-help.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/builtin-help.c b/tools/perf/builtin-help.c
index dbe4e4153bcf..ff51e5fc0daf 100644
--- a/tools/perf/builtin-help.c
+++ b/tools/perf/builtin-help.c
@@ -283,7 +283,7 @@ static int perf_help_config(const char *var, const char *value, void *cb)
 		add_man_viewer(value);
 		return 0;
 	}
-	if (!strstarts(var, "man."))
+	if (strstarts(var, "man."))
 		return add_man_viewer_info(var, value);
 
 	return 0;
@@ -313,7 +313,7 @@ static const char *cmd_to_page(const char *perf_cmd)
 
 	if (!perf_cmd)
 		return "perf";
-	else if (!strstarts(perf_cmd, "perf"))
+	else if (strstarts(perf_cmd, "perf"))
 		return perf_cmd;
 
 	return asprintf(&s, "perf-%s", perf_cmd) < 0 ? NULL : s;
-- 
2.15.0

Re: [PATCH 1/3] perf help: Document missing options

[Taeung Song]

Hi Arnaldo and Namhyung :)

On 11/14/2017 09:15 AM, Namhyung Kim wrote:
> Hi Arnaldo,
> 
> On Mon, Nov 13, 2017 at 03:29:56PM -0300, Arnaldo Carvalho de Melo wrote:
>> Em Sun, Nov 12, 2017 at 10:10:45AM +0900, Sihyeon Jang escreveu:
>>> Cc: Jiri Olsa <jolsa@kernel.org>
>>> Cc: Namhyung Kim <namhyung@kernel.org>
>>> Signed-off-by: Sihyeon Jang <uneedsihyeon@gmail.com>
>>> ---
>>>   tools/perf/Documentation/perf-help.txt | 14 +++++++++++++-
>>>   1 file changed, 13 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/tools/perf/Documentation/perf-help.txt b/tools/perf/Documentation/perf-help.txt
>>> index 5143918..bb605af 100644
>>> --- a/tools/perf/Documentation/perf-help.txt
>>> +++ b/tools/perf/Documentation/perf-help.txt
>>> @@ -7,7 +7,7 @@ perf-help - display help information about perf
>>>   
>>>   SYNOPSIS
>>>   --------
>>> -'perf help' [-a|--all] [COMMAND]
>>> +'perf help' [--all] [--man|--web|--info] [COMMAND]
>>
>> Can you try figuring out if this actually works? I tried here and it
>> doesn't, its an area we took "for free" when we copied the initial
>> codebase from git.git, but I never looked at this area that much, now
>> that I try:
> 
> Yeah, I'm not sure we need to keep it.
> 
> 
>>
>> [acme@jouet linux]$ perf help
>> Config with no key for man viewer: childrenError: wrong config key-value pair top.children=true
>> [acme@jouet linux]$
>>
>> Unsure if this is something that got broken by the 'perf config'
>> patches, Taeung?
> 
> Looks like a bug in 8e99b6d4533c ("tools include: Adopt strstarts()
> from the kernel").
> 
> Following patch should fix it:
> 
> Thanks,
> Namhyung

I also checked this error and test the below patch.
It seems that Namhyung already fixes it !!

Thanks,
Taeung

> 
> 
>  From 096b78b437b5758acc025498e88d73d9d471b3c0 Mon Sep 17 00:00:00 2001
> From: Namhyung Kim <namhyung@kernel.org>
> Date: Tue, 14 Nov 2017 09:10:43 +0900
> Subject: [PATCH] perf help: Fix a bug during strstart() conversion
> 
> The commit 8e99b6d4533c changed prefixcmp() to strstart() but missed to
> change the return value in some place.  It makes perf help print
> annoying output even for sane config items like below:
> 
>    $ perf help
>    '.root': unsupported man viewer sub key.
>    ...
> 
> Fixes: 8e99b6d4533c ("tools include: Adopt strstarts() from the kernel")
> Cc: Taeung Song <treeze.taeung@gmail.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
>   tools/perf/builtin-help.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/builtin-help.c b/tools/perf/builtin-help.c
> index dbe4e4153bcf..ff51e5fc0daf 100644
> --- a/tools/perf/builtin-help.c
> +++ b/tools/perf/builtin-help.c
> @@ -283,7 +283,7 @@ static int perf_help_config(const char *var, const char *value, void *cb)
>   		add_man_viewer(value);
>   		return 0;
>   	}
> -	if (!strstarts(var, "man."))
> +	if (strstarts(var, "man."))
>   		return add_man_viewer_info(var, value);
>   
>   	return 0;
> @@ -313,7 +313,7 @@ static const char *cmd_to_page(const char *perf_cmd)
>   
>   	if (!perf_cmd)
>   		return "perf";
> -	else if (!strstarts(perf_cmd, "perf"))
> +	else if (strstarts(perf_cmd, "perf"))
>   		return perf_cmd;
>   
>   	return asprintf(&s, "perf-%s", perf_cmd) < 0 ? NULL : s;
> 

Re: [PATCH 1/3] perf help: Document missing options

[Arnaldo Carvalho de Melo]

Em Tue, Nov 14, 2017 at 11:18:10AM +0900, Taeung Song escreveu:
> Hi Arnaldo and Namhyung :)
> 
> On 11/14/2017 09:15 AM, Namhyung Kim wrote:
> > Hi Arnaldo,
> > 
> > On Mon, Nov 13, 2017 at 03:29:56PM -0300, Arnaldo Carvalho de Melo wrote:
> > > Em Sun, Nov 12, 2017 at 10:10:45AM +0900, Sihyeon Jang escreveu:
> > > > Cc: Jiri Olsa <jolsa@kernel.org>
> > > > Cc: Namhyung Kim <namhyung@kernel.org>
> > > > Signed-off-by: Sihyeon Jang <uneedsihyeon@gmail.com>
> > > > ---
> > > >   tools/perf/Documentation/perf-help.txt | 14 +++++++++++++-
> > > >   1 file changed, 13 insertions(+), 1 deletion(-)
> > > > 
> > > > diff --git a/tools/perf/Documentation/perf-help.txt b/tools/perf/Documentation/perf-help.txt
> > > > index 5143918..bb605af 100644
> > > > --- a/tools/perf/Documentation/perf-help.txt
> > > > +++ b/tools/perf/Documentation/perf-help.txt
> > > > @@ -7,7 +7,7 @@ perf-help - display help information about perf
> > > >   SYNOPSIS
> > > >   --------
> > > > -'perf help' [-a|--all] [COMMAND]
> > > > +'perf help' [--all] [--man|--web|--info] [COMMAND]
> > > 
> > > Can you try figuring out if this actually works? I tried here and it
> > > doesn't, its an area we took "for free" when we copied the initial
> > > codebase from git.git, but I never looked at this area that much, now
> > > that I try:
> > 
> > Yeah, I'm not sure we need to keep it.
> > 
> > 
> > > 
> > > [acme@jouet linux]$ perf help
> > > Config with no key for man viewer: childrenError: wrong config key-value pair top.children=true
> > > [acme@jouet linux]$
> > > 
> > > Unsure if this is something that got broken by the 'perf config'
> > > patches, Taeung?
> > 
> > Looks like a bug in 8e99b6d4533c ("tools include: Adopt strstarts()
> > from the kernel").
> > 
> > Following patch should fix it:
> > 
> > Thanks,
> > Namhyung
> 
> I also checked this error and test the below patch.
> It seems that Namhyung already fixes it !!

Thanks for checking, added a Tested-by: Taeung,

- Arnaldo
 
> Thanks,
> Taeung
> 
> > 
> > 
> >  From 096b78b437b5758acc025498e88d73d9d471b3c0 Mon Sep 17 00:00:00 2001
> > From: Namhyung Kim <namhyung@kernel.org>
> > Date: Tue, 14 Nov 2017 09:10:43 +0900
> > Subject: [PATCH] perf help: Fix a bug during strstart() conversion
> > 
> > The commit 8e99b6d4533c changed prefixcmp() to strstart() but missed to
> > change the return value in some place.  It makes perf help print
> > annoying output even for sane config items like below:
> > 
> >    $ perf help
> >    '.root': unsupported man viewer sub key.
> >    ...
> > 
> > Fixes: 8e99b6d4533c ("tools include: Adopt strstarts() from the kernel")
> > Cc: Taeung Song <treeze.taeung@gmail.com>
> > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> > ---
> >   tools/perf/builtin-help.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tools/perf/builtin-help.c b/tools/perf/builtin-help.c
> > index dbe4e4153bcf..ff51e5fc0daf 100644
> > --- a/tools/perf/builtin-help.c
> > +++ b/tools/perf/builtin-help.c
> > @@ -283,7 +283,7 @@ static int perf_help_config(const char *var, const char *value, void *cb)
> >   		add_man_viewer(value);
> >   		return 0;
> >   	}
> > -	if (!strstarts(var, "man."))
> > +	if (strstarts(var, "man."))
> >   		return add_man_viewer_info(var, value);
> >   	return 0;
> > @@ -313,7 +313,7 @@ static const char *cmd_to_page(const char *perf_cmd)
> >   	if (!perf_cmd)
> >   		return "perf";
> > -	else if (!strstarts(perf_cmd, "perf"))
> > +	else if (strstarts(perf_cmd, "perf"))
> >   		return perf_cmd;
> >   	return asprintf(&s, "perf-%s", perf_cmd) < 0 ? NULL : s;
> > 

Re: [PATCH 1/3] perf help: Document missing options

[Arnaldo Carvalho de Melo]

Em Tue, Nov 14, 2017 at 09:15:42AM +0900, Namhyung Kim escreveu:
> Hi Arnaldo,
> 
> On Mon, Nov 13, 2017 at 03:29:56PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Sun, Nov 12, 2017 at 10:10:45AM +0900, Sihyeon Jang escreveu:
> > > Cc: Jiri Olsa <jolsa@kernel.org>
> > > Cc: Namhyung Kim <namhyung@kernel.org>
> > > Signed-off-by: Sihyeon Jang <uneedsihyeon@gmail.com>
> > > ---
> > >  tools/perf/Documentation/perf-help.txt | 14 +++++++++++++-
> > >  1 file changed, 13 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/tools/perf/Documentation/perf-help.txt b/tools/perf/Documentation/perf-help.txt
> > > index 5143918..bb605af 100644
> > > --- a/tools/perf/Documentation/perf-help.txt
> > > +++ b/tools/perf/Documentation/perf-help.txt
> > > @@ -7,7 +7,7 @@ perf-help - display help information about perf
> > >  
> > >  SYNOPSIS
> > >  --------
> > > -'perf help' [-a|--all] [COMMAND]
> > > +'perf help' [--all] [--man|--web|--info] [COMMAND]
> > 
> > Can you try figuring out if this actually works? I tried here and it
> > doesn't, its an area we took "for free" when we copied the initial
> > codebase from git.git, but I never looked at this area that much, now
> > that I try:
> 
> Yeah, I'm not sure we need to keep it.
> 
> 
> > 
> > [acme@jouet linux]$ perf help
> > Config with no key for man viewer: childrenError: wrong config key-value pair top.children=true
> > [acme@jouet linux]$ 
> > 
> > Unsure if this is something that got broken by the 'perf config'
> > patches, Taeung?
> 
> Looks like a bug in 8e99b6d4533c ("tools include: Adopt strstarts()
> from the kernel").

Wow, who did this?! ;-P
 
> Following patch should fix it:

Thanks! 
 
> Thanks,
> Namhyung
> 
> 
> >From 096b78b437b5758acc025498e88d73d9d471b3c0 Mon Sep 17 00:00:00 2001
> From: Namhyung Kim <namhyung@kernel.org>
> Date: Tue, 14 Nov 2017 09:10:43 +0900
> Subject: [PATCH] perf help: Fix a bug during strstart() conversion
> 
> The commit 8e99b6d4533c changed prefixcmp() to strstart() but missed to
> change the return value in some place.  It makes perf help print
> annoying output even for sane config items like below:
> 
>   $ perf help
>   '.root': unsupported man viewer sub key.
>   ...
> 
> Fixes: 8e99b6d4533c ("tools include: Adopt strstarts() from the kernel")
> Cc: Taeung Song <treeze.taeung@gmail.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
>  tools/perf/builtin-help.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/builtin-help.c b/tools/perf/builtin-help.c
> index dbe4e4153bcf..ff51e5fc0daf 100644
> --- a/tools/perf/builtin-help.c
> +++ b/tools/perf/builtin-help.c
> @@ -283,7 +283,7 @@ static int perf_help_config(const char *var, const char *value, void *cb)
>  		add_man_viewer(value);
>  		return 0;
>  	}
> -	if (!strstarts(var, "man."))
> +	if (strstarts(var, "man."))
>  		return add_man_viewer_info(var, value);
>  
>  	return 0;
> @@ -313,7 +313,7 @@ static const char *cmd_to_page(const char *perf_cmd)
>  
>  	if (!perf_cmd)
>  		return "perf";
> -	else if (!strstarts(perf_cmd, "perf"))
> +	else if (strstarts(perf_cmd, "perf"))
>  		return perf_cmd;
>  
>  	return asprintf(&s, "perf-%s", perf_cmd) < 0 ? NULL : s;
> -- 
> 2.15.0

[tip:perf/core] perf help: Fix a bug during strstart() conversion

[tip-bot for Namhyung Kim]

Commit-ID:  2f0af8600e82e9f950fc32908386b9c639f88d48
Gitweb:     https://git.kernel.org/tip/2f0af8600e82e9f950fc32908386b9c639f88d48
Author:     Namhyung Kim <namhyung@kernel.org>
AuthorDate: Tue, 14 Nov 2017 09:15:42 +0900
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 16 Nov 2017 14:49:59 -0300

perf help: Fix a bug during strstart() conversion

The commit 8e99b6d4533c changed prefixcmp() to strstart() but missed to
change the return value in some place.  It makes perf help print
annoying output even for sane config items like below:

  $ perf help
  '.root': unsupported man viewer sub key.
  ...

Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Tested-by: Taeung Song <treeze.taeung@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Sihyeon Jang <uneedsihyeon@gmail.com>
Cc: kernel-team@lge.com
Link: http://lkml.kernel.org/r/20171114001542.GA16464@sejong
Fixes: 8e99b6d4533c ("tools include: Adopt strstarts() from the kernel")
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-help.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/builtin-help.c b/tools/perf/builtin-help.c
index bd1fede..a0f7ed2 100644
--- a/tools/perf/builtin-help.c
+++ b/tools/perf/builtin-help.c
@@ -284,7 +284,7 @@ static int perf_help_config(const char *var, const char *value, void *cb)
 		add_man_viewer(value);
 		return 0;
 	}
-	if (!strstarts(var, "man."))
+	if (strstarts(var, "man."))
 		return add_man_viewer_info(var, value);
 
 	return 0;
@@ -314,7 +314,7 @@ static const char *cmd_to_page(const char *perf_cmd)
 
 	if (!perf_cmd)
 		return "perf";
-	else if (!strstarts(perf_cmd, "perf"))
+	else if (strstarts(perf_cmd, "perf"))
 		return perf_cmd;
 
 	return asprintf(&s, "perf-%s", perf_cmd) < 0 ? NULL : s;

[tip:perf/core] perf help: Fix a bug during strstart() conversion

[tip-bot for Namhyung Kim]

Commit-ID:  af98f2273fd0af31ce327cd1406b67c7be0b6734
Gitweb:     https://git.kernel.org/tip/af98f2273fd0af31ce327cd1406b67c7be0b6734
Author:     Namhyung Kim <namhyung@kernel.org>
AuthorDate: Tue, 14 Nov 2017 09:15:42 +0900
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 28 Nov 2017 14:21:18 -0300

perf help: Fix a bug during strstart() conversion

The commit 8e99b6d4533c changed prefixcmp() to strstart() but missed to
change the return value in some place.  It makes perf help print
annoying output even for sane config items like below:

  $ perf help
  '.root': unsupported man viewer sub key.
  ...

Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Tested-by: Taeung Song <treeze.taeung@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Sihyeon Jang <uneedsihyeon@gmail.com>
Cc: kernel-team@lge.com
Link: http://lkml.kernel.org/r/20171114001542.GA16464@sejong
Fixes: 8e99b6d4533c ("tools include: Adopt strstarts() from the kernel")
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-help.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/builtin-help.c b/tools/perf/builtin-help.c
index bd1fede..a0f7ed2 100644
--- a/tools/perf/builtin-help.c
+++ b/tools/perf/builtin-help.c
@@ -284,7 +284,7 @@ static int perf_help_config(const char *var, const char *value, void *cb)
 		add_man_viewer(value);
 		return 0;
 	}
-	if (!strstarts(var, "man."))
+	if (strstarts(var, "man."))
 		return add_man_viewer_info(var, value);
 
 	return 0;
@@ -314,7 +314,7 @@ static const char *cmd_to_page(const char *perf_cmd)
 
 	if (!perf_cmd)
 		return "perf";
-	else if (!strstarts(perf_cmd, "perf"))
+	else if (strstarts(perf_cmd, "perf"))
 		return perf_cmd;
 
 	return asprintf(&s, "perf-%s", perf_cmd) < 0 ? NULL : s;

[PATCH 13/14] perf: Document missing top options

[Shawn Bohrer]

Signed-off-by: Shawn Bohrer <shawn.bohrer@gmail.com>
---
 tools/perf/Documentation/perf-top.txt |   28 ++++++++++++++++++++++++----
 1 files changed, 24 insertions(+), 4 deletions(-)

diff --git a/tools/perf/Documentation/perf-top.txt b/tools/perf/Documentation/perf-top.txt
index 1f96876..f6eb1cd 100644
--- a/tools/perf/Documentation/perf-top.txt
+++ b/tools/perf/Documentation/perf-top.txt
@@ -12,7 +12,7 @@ SYNOPSIS
 
 DESCRIPTION
 -----------
-This command generates and displays a performance counter profile in realtime.
+This command generates and displays a performance counter profile in real time.
 
 
 OPTIONS
@@ -27,8 +27,8 @@ OPTIONS
 
 -C <cpu-list>::
 --cpu=<cpu>::
-Monitor only on the list of cpus provided. Multiple CPUs can be provided as a
-comma-sperated list with no space: 0,1. Ranges of CPUs are specified with -: 0-2.
+Monitor only on the list of CPUs provided. Multiple CPUs can be provided as a
+comma-separated list with no space: 0,1. Ranges of CPUs are specified with -: 0-2.
 Default is to monitor all CPUS.
 
 -d <seconds>::
@@ -50,6 +50,10 @@ Default is to monitor all CPUS.
 --count-filter=<count>::
 	Only display functions with more events than this.
 
+-g::
+--group::
+        Put the counters into a counter group.
+
 -F <freq>::
 --freq=<freq>::
 	Profile at this frequency.
@@ -68,7 +72,11 @@ Default is to monitor all CPUS.
 
 -p <pid>::
 --pid=<pid>::
-	Profile events on existing pid.
+	Profile events on existing Process ID.
+
+-t <tid>::
+--tid=<tid>::
+        Profile events on existing thread ID.
 
 -r <priority>::
 --realtime=<priority>::
@@ -78,6 +86,18 @@ Default is to monitor all CPUS.
 --sym-annotate=<symbol>::
         Annotate this symbol.
 
+-K::
+--hide_kernel_symbols::
+        Hide kernel symbols.
+
+-U::
+--hide_user_symbols::
+        Hide user symbols.
+
+-D::
+--dump-symtab::
+        Dump the symbol table used for profiling.
+
 -v::
 --verbose::
 	Be more verbose (show counter open errors, etc).
-- 
1.7.3.2

[tip:perf/core] perf top: Document missing options

[tip-bot for Shawn Bohrer]

Commit-ID:  2e7a988198b11877d844d147ec81c7caea82c314
Gitweb:     http://git.kernel.org/tip/2e7a988198b11877d844d147ec81c7caea82c314
Author:     Shawn Bohrer <shawn.bohrer@gmail.com>
AuthorDate: Tue, 30 Nov 2010 19:57:21 -0600
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 1 Dec 2010 18:22:48 -0200

perf top: Document missing options

Cc: Ingo Molnar <mingo@elte.hu>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <1291168642-11402-14-git-send-email-shawn.bohrer@gmail.com>
Signed-off-by: Shawn Bohrer <shawn.bohrer@gmail.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/Documentation/perf-top.txt |   28 ++++++++++++++++++++++++----
 1 files changed, 24 insertions(+), 4 deletions(-)

diff --git a/tools/perf/Documentation/perf-top.txt b/tools/perf/Documentation/perf-top.txt
index 1f96876..f6eb1cd 100644
--- a/tools/perf/Documentation/perf-top.txt
+++ b/tools/perf/Documentation/perf-top.txt
@@ -12,7 +12,7 @@ SYNOPSIS
 
 DESCRIPTION
 -----------
-This command generates and displays a performance counter profile in realtime.
+This command generates and displays a performance counter profile in real time.
 
 
 OPTIONS
@@ -27,8 +27,8 @@ OPTIONS
 
 -C <cpu-list>::
 --cpu=<cpu>::
-Monitor only on the list of cpus provided. Multiple CPUs can be provided as a
-comma-sperated list with no space: 0,1. Ranges of CPUs are specified with -: 0-2.
+Monitor only on the list of CPUs provided. Multiple CPUs can be provided as a
+comma-separated list with no space: 0,1. Ranges of CPUs are specified with -: 0-2.
 Default is to monitor all CPUS.
 
 -d <seconds>::
@@ -50,6 +50,10 @@ Default is to monitor all CPUS.
 --count-filter=<count>::
 	Only display functions with more events than this.
 
+-g::
+--group::
+        Put the counters into a counter group.
+
 -F <freq>::
 --freq=<freq>::
 	Profile at this frequency.
@@ -68,7 +72,11 @@ Default is to monitor all CPUS.
 
 -p <pid>::
 --pid=<pid>::
-	Profile events on existing pid.
+	Profile events on existing Process ID.
+
+-t <tid>::
+--tid=<tid>::
+        Profile events on existing thread ID.
 
 -r <priority>::
 --realtime=<priority>::
@@ -78,6 +86,18 @@ Default is to monitor all CPUS.
 --sym-annotate=<symbol>::
         Annotate this symbol.
 
+-K::
+--hide_kernel_symbols::
+        Hide kernel symbols.
+
+-U::
+--hide_user_symbols::
+        Hide user symbols.
+
+-D::
+--dump-symtab::
+        Dump the symbol table used for profiling.
+
 -v::
 --verbose::
 	Be more verbose (show counter open errors, etc).