* [PATCH 2.6.37-rc2] x86, asm: Add parentheses around one pushl_cfi argument
@ 2010-11-16 4:45 Tetsuo Handa
2010-11-16 7:39 ` Jan Beulich
2010-11-18 14:06 ` [tip:x86/urgent] x86, asm: Fix binutils 2.15 build failure tip-bot for Tetsuo Handa
0 siblings, 2 replies; 3+ messages in thread
From: Tetsuo Handa @ 2010-11-16 4:45 UTC (permalink / raw)
To: jbeulich, heukelum, mingo, hpa; +Cc: linux-kernel
>From ed935c12f0b2b09c1586d22925261378e0d7eb83 Mon Sep 17 00:00:00 2001
From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Date: Tue, 16 Nov 2010 13:33:07 +0900
Subject: [PATCH] x86, asm: Add parentheses around one pushl_cfi argument
Commit df5d1874 "x86: Use {push,pop}{l,q}_cfi in more places" caused GNU
assembler 2.15 (Debian Sarge) to fail. It is still failing as of commit
07bd8516 "x86, asm: Restore parentheses around one pushl_cfi argument".
This patch solves build failure with GNU assembler 2.15.
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
---
arch/x86/kernel/entry_32.S | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S
index 59e175e..591e601 100644
--- a/arch/x86/kernel/entry_32.S
+++ b/arch/x86/kernel/entry_32.S
@@ -395,7 +395,7 @@ sysenter_past_esp:
* A tiny bit of offset fixup is necessary - 4*4 means the 4 words
* pushed above; +8 corresponds to copy_thread's esp0 setting.
*/
- pushl_cfi (TI_sysenter_return-THREAD_SIZE_asm+8+4*4)(%esp)
+ pushl_cfi ((TI_sysenter_return)-THREAD_SIZE_asm+8+4*4)(%esp)
CFI_REL_OFFSET eip, 0
pushl_cfi %eax
--
1.7.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 2.6.37-rc2] x86, asm: Add parentheses around one pushl_cfi argument
2010-11-16 4:45 [PATCH 2.6.37-rc2] x86, asm: Add parentheses around one pushl_cfi argument Tetsuo Handa
@ 2010-11-16 7:39 ` Jan Beulich
2010-11-18 14:06 ` [tip:x86/urgent] x86, asm: Fix binutils 2.15 build failure tip-bot for Tetsuo Handa
1 sibling, 0 replies; 3+ messages in thread
From: Jan Beulich @ 2010-11-16 7:39 UTC (permalink / raw)
To: mingo, heukelum, Tetsuo Handa, hpa; +Cc: linux-kernel
>>> On 16.11.10 at 05:45, Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> wrote:
> From ed935c12f0b2b09c1586d22925261378e0d7eb83 Mon Sep 17 00:00:00 2001
> From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Date: Tue, 16 Nov 2010 13:33:07 +0900
> Subject: [PATCH] x86, asm: Add parentheses around one pushl_cfi argument
>
> Commit df5d1874 "x86: Use {push,pop}{l,q}_cfi in more places" caused GNU
> assembler 2.15 (Debian Sarge) to fail. It is still failing as of commit
> 07bd8516 "x86, asm: Restore parentheses around one pushl_cfi argument".
> This patch solves build failure with GNU assembler 2.15.
>
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Acked-by: Jan Beulich <jbeulich@novell.com>
> ---
> arch/x86/kernel/entry_32.S | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S
> index 59e175e..591e601 100644
> --- a/arch/x86/kernel/entry_32.S
> +++ b/arch/x86/kernel/entry_32.S
> @@ -395,7 +395,7 @@ sysenter_past_esp:
> * A tiny bit of offset fixup is necessary - 4*4 means the 4 words
> * pushed above; +8 corresponds to copy_thread's esp0 setting.
> */
> - pushl_cfi (TI_sysenter_return-THREAD_SIZE_asm+8+4*4)(%esp)
> + pushl_cfi ((TI_sysenter_return)-THREAD_SIZE_asm+8+4*4)(%esp)
> CFI_REL_OFFSET eip, 0
>
> pushl_cfi %eax
^ permalink raw reply [flat|nested] 3+ messages in thread* [tip:x86/urgent] x86, asm: Fix binutils 2.15 build failure
2010-11-16 4:45 [PATCH 2.6.37-rc2] x86, asm: Add parentheses around one pushl_cfi argument Tetsuo Handa
2010-11-16 7:39 ` Jan Beulich
@ 2010-11-18 14:06 ` tip-bot for Tetsuo Handa
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Tetsuo Handa @ 2010-11-18 14:06 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, jbeulich, penguin-kernel, tglx, mingo
Commit-ID: 96e612ffc301372d3a3b94e2cb5d1e0c1c207dd1
Gitweb: http://git.kernel.org/tip/96e612ffc301372d3a3b94e2cb5d1e0c1c207dd1
Author: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
AuthorDate: Tue, 16 Nov 2010 13:45:16 +0900
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 18 Nov 2010 09:25:11 +0100
x86, asm: Fix binutils 2.15 build failure
Add parentheses around one pushl_cfi argument.
Commit df5d1874 "x86: Use {push,pop}{l,q}_cfi in more places"
caused GNU assembler 2.15 (Debian Sarge) to fail. It is still
failing as of commit 07bd8516 "x86, asm: Restore parentheses
around one pushl_cfi argument". This patch solves build failure
with GNU assembler 2.15.
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Acked-by: Jan Beulich <jbeulich@novell.com>
Cc: heukelum@fastmail.fm
Cc: hpa@linux.intel.com
LKML-Reference: <201011160445.oAG4jGif079860@www262.sakura.ne.jp>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/entry_32.S | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S
index 59e175e..591e601 100644
--- a/arch/x86/kernel/entry_32.S
+++ b/arch/x86/kernel/entry_32.S
@@ -395,7 +395,7 @@ sysenter_past_esp:
* A tiny bit of offset fixup is necessary - 4*4 means the 4 words
* pushed above; +8 corresponds to copy_thread's esp0 setting.
*/
- pushl_cfi (TI_sysenter_return-THREAD_SIZE_asm+8+4*4)(%esp)
+ pushl_cfi ((TI_sysenter_return)-THREAD_SIZE_asm+8+4*4)(%esp)
CFI_REL_OFFSET eip, 0
pushl_cfi %eax
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-11-18 14:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-16 4:45 [PATCH 2.6.37-rc2] x86, asm: Add parentheses around one pushl_cfi argument Tetsuo Handa
2010-11-16 7:39 ` Jan Beulich
2010-11-18 14:06 ` [tip:x86/urgent] x86, asm: Fix binutils 2.15 build failure tip-bot for Tetsuo Handa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®