* [PATCH -tip] x86,apic - drop redundant bit assignment
@ 2009-07-22 20:52 Cyrill Gorcunov
2009-08-04 15:32 ` [tip:x86/apic] x86, apic: Drop " tip-bot for Cyrill Gorcunov
2009-08-05 10:55 ` tip-bot for Cyrill Gorcunov
0 siblings, 2 replies; 3+ messages in thread
From: Cyrill Gorcunov @ 2009-07-22 20:52 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Thomas Gleixner, H. Peter Anvin, Maciej W. Rozycki, LKML
cpu_has_apic has already investigated boot_cpu_data
X86_FEATURE_APIC bit for being clear if condition
is triggered. So there is no need to clear this bit
second time.
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
---
Please review. Is there some unobvious reason was before
to clear this bit? This snippet already here since long ago.
Perhaps I miss something?
arch/x86/kernel/apic/apic.c | 1 -
1 file changed, 1 deletion(-)
Index: linux-2.6.git/arch/x86/kernel/apic/apic.c
=====================================================================
--- linux-2.6.git.orig/arch/x86/kernel/apic/apic.c
+++ linux-2.6.git/arch/x86/kernel/apic/apic.c
@@ -1651,7 +1651,6 @@ int __init APIC_init_uniprocessor(void)
APIC_INTEGRATED(apic_version[boot_cpu_physical_apicid])) {
pr_err("BIOS bug, local APIC 0x%x not detected!...\n",
boot_cpu_physical_apicid);
- clear_cpu_cap(&boot_cpu_data, X86_FEATURE_APIC);
return -1;
}
#endif
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:x86/apic] x86, apic: Drop redundant bit assignment
2009-07-22 20:52 [PATCH -tip] x86,apic - drop redundant bit assignment Cyrill Gorcunov
@ 2009-08-04 15:32 ` tip-bot for Cyrill Gorcunov
2009-08-05 10:55 ` tip-bot for Cyrill Gorcunov
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Cyrill Gorcunov @ 2009-08-04 15:32 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, gorcunov, macro, tglx, gorcunov, mingo
Commit-ID: 5c0c5f2bcb98afd2af6eebad0b0b1f7ffd04d73a
Gitweb: http://git.kernel.org/tip/5c0c5f2bcb98afd2af6eebad0b0b1f7ffd04d73a
Author: Cyrill Gorcunov <gorcunov@gmail.com>
AuthorDate: Thu, 23 Jul 2009 00:52:59 +0400
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 4 Aug 2009 16:35:45 +0200
x86, apic: Drop redundant bit assignment
cpu_has_apic has already investigated boot_cpu_data
X86_FEATURE_APIC bit for being clear if condition is
triggered.
So there is no need to clear this bit second time.
Signed-off-by: Cyrill Gorcuno v <gorcunov@openvz.org>
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>
LKML-Reference: <20090722205259.GE15805@lenovo>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/apic/apic.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index a79e8a9..1221f68 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -1660,7 +1660,6 @@ int __init APIC_init_uniprocessor(void)
APIC_INTEGRATED(apic_version[boot_cpu_physical_apicid])) {
pr_err("BIOS bug, local APIC 0x%x not detected!...\n",
boot_cpu_physical_apicid);
- clear_cpu_cap(&boot_cpu_data, X86_FEATURE_APIC);
return -1;
}
#endif
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:x86/apic] x86, apic: Drop redundant bit assignment
2009-07-22 20:52 [PATCH -tip] x86,apic - drop redundant bit assignment Cyrill Gorcunov
2009-08-04 15:32 ` [tip:x86/apic] x86, apic: Drop " tip-bot for Cyrill Gorcunov
@ 2009-08-05 10:55 ` tip-bot for Cyrill Gorcunov
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Cyrill Gorcunov @ 2009-08-05 10:55 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, gorcunov, macro, tglx, gorcunov, mingo
Commit-ID: 9910887af84e33ba98fd6792029470ae80166208
Gitweb: http://git.kernel.org/tip/9910887af84e33ba98fd6792029470ae80166208
Author: Cyrill Gorcunov <gorcunov@gmail.com>
AuthorDate: Thu, 23 Jul 2009 00:52:59 +0400
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Wed, 5 Aug 2009 10:30:52 +0200
x86, apic: Drop redundant bit assignment
cpu_has_apic has already investigated boot_cpu_data
X86_FEATURE_APIC bit for being clear if condition is
triggered.
So there is no need to clear this bit second time.
Signed-off-by: Cyrill Gorcuno v <gorcunov@openvz.org>
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>
LKML-Reference: <20090722205259.GE15805@lenovo>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/apic/apic.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index 0a1c283..0b021c5 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -1651,7 +1651,6 @@ int __init APIC_init_uniprocessor(void)
APIC_INTEGRATED(apic_version[boot_cpu_physical_apicid])) {
pr_err("BIOS bug, local APIC 0x%x not detected!...\n",
boot_cpu_physical_apicid);
- clear_cpu_cap(&boot_cpu_data, X86_FEATURE_APIC);
return -1;
}
#endif
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-08-05 10:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-07-22 20:52 [PATCH -tip] x86,apic - drop redundant bit assignment Cyrill Gorcunov
2009-08-04 15:32 ` [tip:x86/apic] x86, apic: Drop " tip-bot for Cyrill Gorcunov
2009-08-05 10:55 ` tip-bot for Cyrill Gorcunov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome