mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] x86/xen: disable cpu0 hotplug for xen pv
@ 2018-09-12 17:41 Juergen Gross
  2018-09-12 19:22 ` [tip:x86/urgent] x86/xen: Disable CPU0 hotplug for Xen PV tip-bot for Juergen Gross
  0 siblings, 1 reply; 2+ messages in thread
From: Juergen Gross @ 2018-09-12 17:41 UTC (permalink / raw)
  To: linux-kernel, xen-devel, x86
  Cc: boris.ostrovsky, hpa, tglx, mingo, Juergen Gross

Xen pv guests don't allow cpu0 hotplug, so disable it.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 arch/x86/kernel/topology.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kernel/topology.c b/arch/x86/kernel/topology.c
index 12cbe2b88c0f..738bf42b0218 100644
--- a/arch/x86/kernel/topology.c
+++ b/arch/x86/kernel/topology.c
@@ -111,8 +111,10 @@ int arch_register_cpu(int num)
 	/*
 	 * Currently CPU0 is only hotpluggable on Intel platforms. Other
 	 * vendors can add hotplug support later.
+	 * Xen PV guests don't support CPU0 hotplug at all.
 	 */
-	if (c->x86_vendor != X86_VENDOR_INTEL)
+	if (c->x86_vendor != X86_VENDOR_INTEL ||
+	    boot_cpu_has(X86_FEATURE_XENPV))
 		cpu0_hotpluggable = 0;
 
 	/*
-- 
2.16.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [tip:x86/urgent] x86/xen: Disable CPU0 hotplug for Xen PV
  2018-09-12 17:41 [PATCH] x86/xen: disable cpu0 hotplug for xen pv Juergen Gross
@ 2018-09-12 19:22 ` tip-bot for Juergen Gross
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Juergen Gross @ 2018-09-12 19:22 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: torvalds, hpa, tglx, jgross, peterz, mingo, linux-kernel

Commit-ID:  999696752db1099aba595aac4f8d881f8c7cf4e6
Gitweb:     https://git.kernel.org/tip/999696752db1099aba595aac4f8d881f8c7cf4e6
Author:     Juergen Gross <jgross@suse.com>
AuthorDate: Wed, 12 Sep 2018 19:41:22 +0200
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 12 Sep 2018 21:15:02 +0200

x86/xen: Disable CPU0 hotplug for Xen PV

Xen PV guests don't allow CPU0 hotplug, so disable it.

Signed-off-by: Juergen Gross <jgross@suse.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: boris.ostrovsky@oracle.com
Cc: xen-devel@lists.xenproject.org
Link: http://lkml.kernel.org/r/20180912174122.24282-1-jgross@suse.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/kernel/topology.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kernel/topology.c b/arch/x86/kernel/topology.c
index 12cbe2b88c0f..738bf42b0218 100644
--- a/arch/x86/kernel/topology.c
+++ b/arch/x86/kernel/topology.c
@@ -111,8 +111,10 @@ int arch_register_cpu(int num)
 	/*
 	 * Currently CPU0 is only hotpluggable on Intel platforms. Other
 	 * vendors can add hotplug support later.
+	 * Xen PV guests don't support CPU0 hotplug at all.
 	 */
-	if (c->x86_vendor != X86_VENDOR_INTEL)
+	if (c->x86_vendor != X86_VENDOR_INTEL ||
+	    boot_cpu_has(X86_FEATURE_XENPV))
 		cpu0_hotpluggable = 0;
 
 	/*

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-09-12 19:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-12 17:41 [PATCH] x86/xen: disable cpu0 hotplug for xen pv Juergen Gross
2018-09-12 19:22 ` [tip:x86/urgent] x86/xen: Disable CPU0 hotplug for Xen PV tip-bot for Juergen Gross

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome