From: tip-bot for Rakib Mullick <rakib.mullick@gmail.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
rakib.mullick@gmail.com, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:x86/cleanups] x86, mpparse: Remove unnecessary variable
Date: Thu, 24 Mar 2011 09:01:59 GMT [thread overview]
Message-ID: <tip-9f1f1bfd8d7e579f07dbe56d6f93bd594da43b3d@git.kernel.org> (raw)
In-Reply-To: <AANLkTikh3y+is3xixKBdyHhr_cHxzPFJF729Fcvt8+Ns@mail.gmail.com>
Commit-ID: 9f1f1bfd8d7e579f07dbe56d6f93bd594da43b3d
Gitweb: http://git.kernel.org/tip/9f1f1bfd8d7e579f07dbe56d6f93bd594da43b3d
Author: Rakib Mullick <rakib.mullick@gmail.com>
AuthorDate: Wed, 23 Mar 2011 21:31:40 +0600
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 24 Mar 2011 09:05:40 +0100
x86, mpparse: Remove unnecessary variable
'ret' isn't used by check_slot(), gets initialized but has no real use,
so remove it.
Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
LKML-Reference: <AANLkTikh3y+is3xixKBdyHhr_cHxzPFJF729Fcvt8+Ns@mail.gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/mpparse.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kernel/mpparse.c b/arch/x86/kernel/mpparse.c
index 6f789a8..ef32d4c 100644
--- a/arch/x86/kernel/mpparse.c
+++ b/arch/x86/kernel/mpparse.c
@@ -722,14 +722,12 @@ inline void __init check_irq_src(struct mpc_intsrc *m, int *nr_m_spare) {}
static int
check_slot(unsigned long mpc_new_phys, unsigned long mpc_new_length, int count)
{
- int ret = 0;
-
if (!mpc_new_phys || count <= mpc_new_length) {
WARN(1, "update_mptable: No spare slots (length: %x)\n", count);
return -1;
}
- return ret;
+ return 0;
}
static int __init replace_intsrc_all(struct mpc_table *mpc,
prev parent reply other threads:[~2011-03-24 9:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 15:31 [PATCH] x86, mpparse: Reduce memory footprint Rakib Mullick
2011-03-24 9:01 ` tip-bot for Rakib Mullick [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-9f1f1bfd8d7e579f07dbe56d6f93bd594da43b3d@git.kernel.org \
--to=rakib.mullick@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome