mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] x86, mpparse: Reduce memory footprint
@ 2011-03-23 15:31 Rakib Mullick
  2011-03-24  9:01 ` [tip:x86/cleanups] x86, mpparse: Remove unnecessary variable tip-bot for Rakib Mullick
  0 siblings, 1 reply; 2+ messages in thread
From: Rakib Mullick @ 2011-03-23 15:31 UTC (permalink / raw)
  To: Ingo Molnar; +Cc: LKML, Thomas Gleixner, H. Peter Anvin

Reduce extra memory footprint overhead. ret isn't used by check_slot,
gets initialized but no real use, so remove it.

Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
---

diff --git a/arch/x86/kernel/mpparse.c b/arch/x86/kernel/mpparse.c
index 6f789a8..ef32d4c 100644
--- a/arch/x86/kernel/mpparse.c
+++ b/arch/x86/kernel/mpparse.c
@@ -722,14 +722,12 @@ inline void __init check_irq_src(struct
mpc_intsrc *m, int *nr_m_spare) {}
 static int
 check_slot(unsigned long mpc_new_phys, unsigned long mpc_new_length, int count)
 {
-	int ret = 0;
-
 	if (!mpc_new_phys || count <= mpc_new_length) {
 		WARN(1, "update_mptable: No spare slots (length: %x)\n", count);
 		return -1;
 	}

-	return ret;
+	return 0;
 }

 static int  __init replace_intsrc_all(struct mpc_table *mpc,

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [tip:x86/cleanups] x86, mpparse: Remove unnecessary variable
  2011-03-23 15:31 [PATCH] x86, mpparse: Reduce memory footprint Rakib Mullick
@ 2011-03-24  9:01 ` tip-bot for Rakib Mullick
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Rakib Mullick @ 2011-03-24  9:01 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, rakib.mullick, tglx, mingo

Commit-ID:  9f1f1bfd8d7e579f07dbe56d6f93bd594da43b3d
Gitweb:     http://git.kernel.org/tip/9f1f1bfd8d7e579f07dbe56d6f93bd594da43b3d
Author:     Rakib Mullick <rakib.mullick@gmail.com>
AuthorDate: Wed, 23 Mar 2011 21:31:40 +0600
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 24 Mar 2011 09:05:40 +0100

x86, mpparse: Remove unnecessary variable

'ret' isn't used by check_slot(), gets initialized but has no real use,
so remove it.

Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
LKML-Reference: <AANLkTikh3y+is3xixKBdyHhr_cHxzPFJF729Fcvt8+Ns@mail.gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/kernel/mpparse.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/mpparse.c b/arch/x86/kernel/mpparse.c
index 6f789a8..ef32d4c 100644
--- a/arch/x86/kernel/mpparse.c
+++ b/arch/x86/kernel/mpparse.c
@@ -722,14 +722,12 @@ inline void __init check_irq_src(struct mpc_intsrc *m, int *nr_m_spare) {}
 static int
 check_slot(unsigned long mpc_new_phys, unsigned long mpc_new_length, int count)
 {
-	int ret = 0;
-
 	if (!mpc_new_phys || count <= mpc_new_length) {
 		WARN(1, "update_mptable: No spare slots (length: %x)\n", count);
 		return -1;
 	}
 
-	return ret;
+	return 0;
 }
 
 static int  __init replace_intsrc_all(struct mpc_table *mpc,

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-03-24  9:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-23 15:31 [PATCH] x86, mpparse: Reduce memory footprint Rakib Mullick
2011-03-24  9:01 ` [tip:x86/cleanups] x86, mpparse: Remove unnecessary variable tip-bot for Rakib Mullick

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome