[PATCH] [perf]: update makefile message for installing required libs

[PATCH] [perf]: update makefile message for installing required libs

[neerajbadlani]

From: Neeraj Badlani <neerajbadlani@gmail.com>

In case of missing library (libslang), give hint to install library (libslang2-dev)
Since libslang-dev is not provided by Ubuntu's apt-package

Signed-off-by: Neeraj Badlani <neerajbadlani@gmail.com>
---
 tools/perf/config/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
index 5ad0255..e57d4d7 100644
--- a/tools/perf/config/Makefile
+++ b/tools/perf/config/Makefile
@@ -437,7 +437,7 @@ endif
 
 ifndef NO_SLANG
   ifneq ($(feature-libslang), 1)
-    msg := $(warning slang not found, disables TUI support. Please install slang-devel or libslang-dev);
+    msg := $(warning slang not found, disables TUI support. Please install slang-devel or libslang-dev or libslang2-dev);
     NO_SLANG := 1
   else
     # Fedora has /usr/include/slang/slang.h, but ubuntu /usr/include/slang.h
-- 
2.7.4

Re: [PATCH] [perf]: update makefile message for installing required libs

[Arnaldo Carvalho de Melo]

Em Mon, Jun 27, 2016 at 06:59:57AM -0700, neerajbadlani@gmail.com escreveu:
> From: Neeraj Badlani <neerajbadlani@gmail.com>
> 
> In case of missing library (libslang), give hint to install library (libslang2-dev)
> Since libslang-dev is not provided by Ubuntu's apt-package
> 
> Signed-off-by: Neeraj Badlani <neerajbadlani@gmail.com>
> ---
>  tools/perf/config/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> index 5ad0255..e57d4d7 100644
> --- a/tools/perf/config/Makefile
> +++ b/tools/perf/config/Makefile
> @@ -437,7 +437,7 @@ endif
>  
>  ifndef NO_SLANG
>    ifneq ($(feature-libslang), 1)
> -    msg := $(warning slang not found, disables TUI support. Please install slang-devel or libslang-dev);
> +    msg := $(warning slang not found, disables TUI support. Please install slang-devel or libslang-dev or libslang2-dev);

Too many 'or', I'll apply it as:

+    msg := $(warning slang not found, disables TUI support. Please install slang-devel, libslang-dev or libslang2-dev);

Thanks,

- Arnaldo

>      NO_SLANG := 1
>    else
>      # Fedora has /usr/include/slang/slang.h, but ubuntu /usr/include/slang.h
> -- 
> 2.7.4

[tip:perf/core] perf tools: Update makefile message for installing slang devel package

[tip-bot for Neeraj Badlani]

Commit-ID:  9f776ba11c8be311a5c23777bc9f3b96498cc6cc
Gitweb:     http://git.kernel.org/tip/9f776ba11c8be311a5c23777bc9f3b96498cc6cc
Author:     Neeraj Badlani <neerajbadlani@gmail.com>
AuthorDate: Mon, 27 Jun 2016 06:59:57 -0700
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 27 Jun 2016 12:44:22 -0300

perf tools: Update makefile message for installing slang devel package

In case of missing library (libslang), give hint to install library
(libslang2-dev), since libslang-dev is not provided by Ubuntu.

Signed-off-by: Neeraj Badlani <neerajbadlani@gmail.com>
Link: http://lkml.kernel.org/r/1467035997-9100-1-git-send-email-neerajbadlani@gmail.com
[ removed excessive 'or' usage ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/config/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
index 534c811..bf1a0a0 100644
--- a/tools/perf/config/Makefile
+++ b/tools/perf/config/Makefile
@@ -482,7 +482,7 @@ endif
 
 ifndef NO_SLANG
   ifneq ($(feature-libslang), 1)
-    msg := $(warning slang not found, disables TUI support. Please install slang-devel or libslang-dev);
+    msg := $(warning slang not found, disables TUI support. Please install slang-devel, libslang-dev or libslang2-dev);
     NO_SLANG := 1
   else
     # Fedora has /usr/include/slang/slang.h, but ubuntu /usr/include/slang.h