mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Yinghai Lu <yinghai@kernel.org>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	yinghai@kernel.org, tglx@linutronix.de, jens.axboe@oracle.com
Subject: [tip:x86/urgent] x86/pci: Intel ioh bus num reg accessing fix
Date: Mon, 4 Jan 2010 21:42:55 GMT	[thread overview]
Message-ID: <tip-a557aae29cf5916295c234d4b10ba3f8f29b8a96@git.kernel.org> (raw)
In-Reply-To: <1261525263-13763-3-git-send-email-yinghai@kernel.org>

Commit-ID:  a557aae29cf5916295c234d4b10ba3f8f29b8a96
Gitweb:     http://git.kernel.org/tip/a557aae29cf5916295c234d4b10ba3f8f29b8a96
Author:     Yinghai Lu <yinghai@kernel.org>
AuthorDate: Tue, 22 Dec 2009 15:40:40 -0800
Committer:  H. Peter Anvin <hpa@zytor.com>
CommitDate: Mon, 4 Jan 2010 13:21:51 -0800

x86/pci: Intel ioh bus num reg accessing fix

It is above 0x100 (PCI-Express extended register space), so if mmconf
is not enable, we can't access it.

[ hpa: changed the bound from 0x200 to 0x120, which is the tight
  bound. ]

Reported-by: Jens Axboe <jens.axboe@oracle.com>
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
LKML-Reference: <1261525263-13763-3-git-send-email-yinghai@kernel.org>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
---
 arch/x86/pci/intel_bus.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/arch/x86/pci/intel_bus.c b/arch/x86/pci/intel_bus.c
index b7a55dc..f81a2fa 100644
--- a/arch/x86/pci/intel_bus.c
+++ b/arch/x86/pci/intel_bus.c
@@ -49,6 +49,10 @@ static void __devinit pci_root_bus_res(struct pci_dev *dev)
 	u64 mmioh_base, mmioh_end;
 	int bus_base, bus_end;
 
+	/* some sys doesn't get mmconf enabled */
+	if (dev->cfg_size < 0x120)
+		return;
+
 	if (pci_root_num >= PCI_ROOT_NR) {
 		printk(KERN_DEBUG "intel_bus.c: PCI_ROOT_NR is too small\n");
 		return;

  reply	other threads:[~2010-01-04 21:43 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-22 23:40 [PATCH -v2 0/25] x86: use early_res instead of bootmem before slab Yinghai Lu
2009-12-22 23:40 ` [PATCH 01/25] x86: fix size for ex trampoline with 32bit Yinghai Lu
2010-01-04 21:42   ` [tip:x86/urgent] x86: Fix " tip-bot for Yinghai Lu
2009-12-22 23:40 ` [PATCH 02/25] x86/pci: intel ioh bus num reg accessing fix Yinghai Lu
2010-01-04 21:42   ` tip-bot for Yinghai Lu [this message]
2009-12-22 23:40 ` [PATCH 03/25] bootmem: move out map assigning out of loop Yinghai Lu
2009-12-22 23:40 ` [PATCH 04/25] x86/pci: don't check mmconf again if it is from MSR with amd faml0h Yinghai Lu
2009-12-22 23:40 ` [PATCH 05/25] x86: move range related operation to one file Yinghai Lu
2009-12-22 23:40 ` [PATCH 06/25] x86: check range in update range Yinghai Lu
2009-12-22 23:40 ` [PATCH 07/25] x86/pci: use resource_size_t in update_res Yinghai Lu
2009-12-22 23:40 ` [PATCH 08/25] x86/pci: amd one chain system to use pci read out res Yinghai Lu
2009-12-22 23:40 ` [PATCH 09/25] x86/pci: use u64 instead of size_t in amd_bus.c Yinghai Lu
2009-12-22 23:40 ` [PATCH 10/25] x86/pci: add cap_resource Yinghai Lu
2009-12-22 23:40 ` [PATCH 11/25] x86/pci: enable pci root res read out for 32bit too Yinghai Lu
2009-12-22 23:40 ` [PATCH 12/25] x86: call early_res_to_bootmem one time Yinghai Lu
2009-12-22 23:40 ` [PATCH 13/25] x86: introduce max_early_res and early_res_count Yinghai Lu
2009-12-22 23:40 ` [PATCH 14/25] x86: dynamic increase early_res array size Yinghai Lu
2009-12-22 23:40 ` [PATCH 15/25] x86: print bootmem free before pci_iommu_alloc and free_all_bootmem Yinghai Lu
2009-12-22 23:40 ` [PATCH 16/25] x86: make early_node_mem get mem > 4g if possible Yinghai Lu
2009-12-22 23:40 ` [PATCH 17/25] x86: only call dma32_reserve_bootmem 64bit !CONFIG_NUMA Yinghai Lu
2009-12-22 23:40 ` [PATCH 18/25] x86: make 64 bit use early_res instead of bootmem before slab Yinghai Lu
2009-12-22 23:40 ` [PATCH 19/25] sparsemem: put usemap for one node together Yinghai Lu
2009-12-22 23:40 ` [PATCH 20/25] sparsemem: put mem map " Yinghai Lu
2009-12-22 23:40 ` [PATCH 21/25] x86: change range end to start+size Yinghai Lu
2009-12-22 23:41 ` [PATCH 22/25] x86: move bios page reserve early to head32/64.c Yinghai Lu
2009-12-22 23:41 ` [PATCH 23/25] x86: seperate early_res related code from e820.c Yinghai Lu
2009-12-22 23:41 ` [PATCH 24/25] x86: add find_early_area_size Yinghai Lu
2009-12-22 23:41 ` [PATCH 25/25] x86: move back find_e820_area to e820.c Yinghai Lu
2010-01-04 17:48 ` [PATCH -v2 0/25] x86: use early_res instead of bootmem before slab Christoph Lameter
2010-01-04 21:13   ` Yinghai Lu
2010-01-04 21:19     ` Christoph Lameter
2010-01-04 21:23       ` Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-a557aae29cf5916295c234d4b10ba3f8f29b8a96@git.kernel.org \
    --to=yinghai@kernel.org \
    --cc=hpa@zytor.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome