From: tip-bot for Dave Hansen <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: brgerst@gmail.com, jpoimboe@redhat.com, mingo@kernel.org,
tglx@linutronix.de, linux-kernel@vger.kernel.org,
dave.hansen@linux.intel.com, hpa@zytor.com, luto@kernel.org,
torvalds@linux-foundation.org, peterz@infradead.org,
bp@alien8.de, dvlasenk@redhat.com
Subject: [tip:x86/urgent] x86/mpx/selftests: Fix up weird arrays
Date: Tue, 21 Nov 2017 00:40:24 -0800 [thread overview]
Message-ID: <tip-a6400120d042397675fcf694060779d21e9e762d@git.kernel.org> (raw)
In-Reply-To: <20171111001229.58A7933D@viggo.jf.intel.com>
Commit-ID: a6400120d042397675fcf694060779d21e9e762d
Gitweb: https://git.kernel.org/tip/a6400120d042397675fcf694060779d21e9e762d
Author: Dave Hansen <dave.hansen@linux.intel.com>
AuthorDate: Fri, 10 Nov 2017 16:12:29 -0800
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 21 Nov 2017 09:34:52 +0100
x86/mpx/selftests: Fix up weird arrays
The MPX hardware data structurse are defined in a weird way: they define
their size in bytes and then union that with the type with which we want
to access them.
Yes, this is weird, but it does work. But, new GCC's complain that we
are accessing the array out of bounds. Just make it a zero-sized array
so gcc will stop complaining. There was not really a bug here.
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20171111001229.58A7933D@viggo.jf.intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
tools/testing/selftests/x86/mpx-hw.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/x86/mpx-hw.h b/tools/testing/selftests/x86/mpx-hw.h
index 3f00939..d1b61ab 100644
--- a/tools/testing/selftests/x86/mpx-hw.h
+++ b/tools/testing/selftests/x86/mpx-hw.h
@@ -52,14 +52,14 @@
struct mpx_bd_entry {
union {
char x[MPX_BOUNDS_DIR_ENTRY_SIZE_BYTES];
- void *contents[1];
+ void *contents[0];
};
} __attribute__((packed));
struct mpx_bt_entry {
union {
char x[MPX_BOUNDS_TABLE_ENTRY_SIZE_BYTES];
- unsigned long contents[1];
+ unsigned long contents[0];
};
} __attribute__((packed));
next prev parent reply other threads:[~2017-11-21 8:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-11 0:12 [PATCH 0/4] MPX and Protection Keys Updates Dave Hansen
2017-11-11 0:12 ` [PATCH 1/4] x86, pkeys: update documentation about availability Dave Hansen
2017-11-21 8:39 ` [tip:x86/urgent] x86/pkeys: Update " tip-bot for Dave Hansen
2017-11-11 0:12 ` [PATCH 2/4] x86, selftests, mpx: fix up weird arrays Dave Hansen
2017-11-21 8:32 ` Ingo Molnar
2017-11-21 8:40 ` tip-bot for Dave Hansen [this message]
2017-11-11 0:12 ` [PATCH 3/4] x86, selftests, protection_keys: rename si_pkey Dave Hansen
2017-11-21 8:32 ` Ingo Molnar
2017-11-21 8:40 ` [tip:x86/urgent] x86/pkeys/selftests: Rename 'si_pkey' to 'siginfo_pkey' tip-bot for Dave Hansen
2017-11-11 0:12 ` [PATCH 4/4] x86, selftests: fix protection keys write() warining Dave Hansen
2017-11-21 8:41 ` [tip:x86/urgent] x86/pkeys/selftests: Fix protection keys write() warning tip-bot for Dave Hansen
2017-11-21 8:34 ` [PATCH 0/4] MPX and Protection Keys Updates Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-a6400120d042397675fcf694060779d21e9e762d@git.kernel.org \
--to=tipbot@zytor.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dave.hansen@linux.intel.com \
--cc=dvlasenk@redhat.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome