mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: x86@kernel.org, Dave Hansen <dave.hansen@linux.intel.com>
Subject: [PATCH 4/4] x86, selftests: fix protection keys write() warining
Date: Fri, 10 Nov 2017 16:12:32 -0800	[thread overview]
Message-ID: <20171111001232.94813E58@viggo.jf.intel.com> (raw)
In-Reply-To: <20171111001226.810E7A73@viggo.jf.intel.com>


From: Dave Hansen <dave.hansen@linux.intel.com>

write() is marked as having a must-check return value.  Check it and
abort if we fail to write an error message from a signal handler.

Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
---

 b/tools/testing/selftests/x86/pkey-helpers.h |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff -puN tools/testing/selftests/x86/pkey-helpers.h~x86-selftests-protection-keys-write-warning tools/testing/selftests/x86/pkey-helpers.h
--- a/tools/testing/selftests/x86/pkey-helpers.h~x86-selftests-protection-keys-write-warning	2017-11-10 15:29:29.240207938 -0800
+++ b/tools/testing/selftests/x86/pkey-helpers.h	2017-11-10 15:29:29.244207938 -0800
@@ -30,6 +30,7 @@ static inline void sigsafe_printf(const
 	if (!dprint_in_signal) {
 		vprintf(format, ap);
 	} else {
+		int ret;
 		int len = vsnprintf(dprint_in_signal_buffer,
 				    DPRINT_IN_SIGNAL_BUF_SIZE,
 				    format, ap);
@@ -39,7 +40,9 @@ static inline void sigsafe_printf(const
 		 */
 		if (len > DPRINT_IN_SIGNAL_BUF_SIZE)
 			len = DPRINT_IN_SIGNAL_BUF_SIZE;
-		write(1, dprint_in_signal_buffer, len);
+		ret = write(1, dprint_in_signal_buffer, len);
+		if (ret < 0)
+			abort();
 	}
 	va_end(ap);
 }
_

  parent reply	other threads:[~2017-11-11  0:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-11  0:12 [PATCH 0/4] MPX and Protection Keys Updates Dave Hansen
2017-11-11  0:12 ` [PATCH 1/4] x86, pkeys: update documentation about availability Dave Hansen
2017-11-21  8:39   ` [tip:x86/urgent] x86/pkeys: Update " tip-bot for Dave Hansen
2017-11-11  0:12 ` [PATCH 2/4] x86, selftests, mpx: fix up weird arrays Dave Hansen
2017-11-21  8:32   ` Ingo Molnar
2017-11-21  8:40   ` [tip:x86/urgent] x86/mpx/selftests: Fix " tip-bot for Dave Hansen
2017-11-11  0:12 ` [PATCH 3/4] x86, selftests, protection_keys: rename si_pkey Dave Hansen
2017-11-21  8:32   ` Ingo Molnar
2017-11-21  8:40   ` [tip:x86/urgent] x86/pkeys/selftests: Rename 'si_pkey' to 'siginfo_pkey' tip-bot for Dave Hansen
2017-11-11  0:12 ` Dave Hansen [this message]
2017-11-21  8:41   ` [tip:x86/urgent] x86/pkeys/selftests: Fix protection keys write() warning tip-bot for Dave Hansen
2017-11-21  8:34 ` [PATCH 0/4] MPX and Protection Keys Updates Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171111001232.94813E58@viggo.jf.intel.com \
    --to=dave.hansen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome