mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Matthias Kaehlcke <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: groeck@chromium.org, mka@chromium.org,
	linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
	mingo@kernel.org, nick.desaulniers@gmail.com, tglx@linutronix.de,
	dianders@chromium.org, shile.zhang@nokia.com,
	peterz@infradead.org, hpa@zytor.com
Subject: [tip:sched/core] sched/sysctl: Fix attributes of some extern declarations
Date: Wed, 1 Nov 2017 01:45:55 -0700	[thread overview]
Message-ID: <tip-a9903f04e0a4ea522d959c2f287cdf0ab029e324@git.kernel.org> (raw)
In-Reply-To: <20171030180816.170850-1-mka@chromium.org>

Commit-ID:  a9903f04e0a4ea522d959c2f287cdf0ab029e324
Gitweb:     https://git.kernel.org/tip/a9903f04e0a4ea522d959c2f287cdf0ab029e324
Author:     Matthias Kaehlcke <mka@chromium.org>
AuthorDate: Mon, 30 Oct 2017 11:08:16 -0700
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 1 Nov 2017 09:36:17 +0100

sched/sysctl: Fix attributes of some extern declarations

The definition of sysctl_sched_migration_cost, sysctl_sched_nr_migrate
and sysctl_sched_time_avg includes the attribute const_debug. This
attribute is not part of the extern declaration of these variables in
include/linux/sched/sysctl.h, while it is in kernel/sched/sched.h,
and as a result Clang generates warnings like this:

  kernel/sched/sched.h:1618:33: warning: section attribute is specified on redeclared variable [-Wsection]
  extern const_debug unsigned int sysctl_sched_time_avg;
                                ^
  ./include/linux/sched/sysctl.h:42:21: note: previous declaration is here
  extern unsigned int sysctl_sched_time_avg;

The header only declares the variables when CONFIG_SCHED_DEBUG is defined,
therefore it is not necessary to duplicate the definition of const_debug.
Instead we can use the attribute __read_mostly, which is the expansion of
const_debug when CONFIG_SCHED_DEBUG=y is set.

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Nick Desaulniers <nick.desaulniers@gmail.com>
Cc: Douglas Anderson <dianders@chromium.org>
Cc: Guenter Roeck <groeck@chromium.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Shile Zhang <shile.zhang@nokia.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20171030180816.170850-1-mka@chromium.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 include/linux/sched/sysctl.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/linux/sched/sysctl.h b/include/linux/sched/sysctl.h
index 0f5ecd4..d34c823 100644
--- a/include/linux/sched/sysctl.h
+++ b/include/linux/sched/sysctl.h
@@ -37,9 +37,9 @@ extern unsigned int sysctl_numa_balancing_scan_period_max;
 extern unsigned int sysctl_numa_balancing_scan_size;
 
 #ifdef CONFIG_SCHED_DEBUG
-extern unsigned int sysctl_sched_migration_cost;
-extern unsigned int sysctl_sched_nr_migrate;
-extern unsigned int sysctl_sched_time_avg;
+extern __read_mostly unsigned int sysctl_sched_migration_cost;
+extern __read_mostly unsigned int sysctl_sched_nr_migrate;
+extern __read_mostly unsigned int sysctl_sched_time_avg;
 
 int sched_proc_update_handler(struct ctl_table *table, int write,
 		void __user *buffer, size_t *length,

      parent reply	other threads:[~2017-11-01  8:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-30 18:08 [PATCH v2] " Matthias Kaehlcke
2017-10-31  9:57 ` Ingo Molnar
2017-10-31 22:31   ` Matthias Kaehlcke
2017-11-01  4:33     ` Nick Desaulniers
2017-11-01  8:34     ` Ingo Molnar
2017-11-01  8:45 ` tip-bot for Matthias Kaehlcke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-a9903f04e0a4ea522d959c2f287cdf0ab029e324@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=dianders@chromium.org \
    --cc=groeck@chromium.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mka@chromium.org \
    --cc=nick.desaulniers@gmail.com \
    --cc=peterz@infradead.org \
    --cc=shile.zhang@nokia.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome