* [PATCH] Don't continue booting if we can't load the specified initrd.
@ 2012-05-16 17:43 Peter Jones
2012-05-16 21:45 ` [tip:x86/cleanups] x86: Don't continue booting if we can' t " tip-bot for Peter Jones
0 siblings, 1 reply; 2+ messages in thread
From: Peter Jones @ 2012-05-16 17:43 UTC (permalink / raw)
To: hpa; +Cc: linux-kernel, x86, Peter Jones
If we've determined we can't do what the user asked, trying to do
something else isn't going to make the user's life better.
Without this the screen scrolls a bit and then you get a panic
anyway, and it's nice not to have so much scroll after the real
problem in bug reports.
---
arch/x86/kernel/setup.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 1a29015..37ef116 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -393,10 +393,9 @@ static void __init reserve_initrd(void)
initrd_start = 0;
if (ramdisk_size >= (end_of_lowmem>>1)) {
- memblock_free(ramdisk_image, ramdisk_end - ramdisk_image);
- printk(KERN_ERR "initrd too large to handle, "
- "disabling initrd\n");
- return;
+ panic("initrd too large to handle, "
+ "disabling initrd (%lld needed, %lld available)\n",
+ ramdisk_size, end_of_lowmem>>1);
}
printk(KERN_INFO "RAMDISK: %08llx - %08llx\n", ramdisk_image,
--
1.7.10.1
^ permalink raw reply [flat|nested] 2+ messages in thread* [tip:x86/cleanups] x86: Don't continue booting if we can' t load the specified initrd
2012-05-16 17:43 [PATCH] Don't continue booting if we can't load the specified initrd Peter Jones
@ 2012-05-16 21:45 ` tip-bot for Peter Jones
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Peter Jones @ 2012-05-16 21:45 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, pjones, hpa, mingo, tglx, hpa
Commit-ID: ab7b64e9ee1e930ffe9d7f5b5eebe618a3b3a03b
Gitweb: http://git.kernel.org/tip/ab7b64e9ee1e930ffe9d7f5b5eebe618a3b3a03b
Author: Peter Jones <pjones@redhat.com>
AuthorDate: Wed, 16 May 2012 13:43:26 -0400
Committer: H. Peter Anvin <hpa@linux.intel.com>
CommitDate: Wed, 16 May 2012 13:59:52 -0700
x86: Don't continue booting if we can't load the specified initrd
If we've determined we can't do what the user asked, trying to do
something else isn't going to make the user's life better.
Without this the screen scrolls a bit and then you get a panic
anyway, and it's nice not to have so much scroll after the real
problem in bug reports.
Link: http://lkml.kernel.org/r/1337190206-12121-1-git-send-email-pjones@redhat.com
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
---
arch/x86/kernel/setup.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 1a29015..37ef116 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -393,10 +393,9 @@ static void __init reserve_initrd(void)
initrd_start = 0;
if (ramdisk_size >= (end_of_lowmem>>1)) {
- memblock_free(ramdisk_image, ramdisk_end - ramdisk_image);
- printk(KERN_ERR "initrd too large to handle, "
- "disabling initrd\n");
- return;
+ panic("initrd too large to handle, "
+ "disabling initrd (%lld needed, %lld available)\n",
+ ramdisk_size, end_of_lowmem>>1);
}
printk(KERN_INFO "RAMDISK: %08llx - %08llx\n", ramdisk_image,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-16 21:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-16 17:43 [PATCH] Don't continue booting if we can't load the specified initrd Peter Jones
2012-05-16 21:45 ` [tip:x86/cleanups] x86: Don't continue booting if we can' t " tip-bot for Peter Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome