* [PATCH] x86,vdso: Set VM_MAYREAD for the vvar vma
@ 2014-07-25 23:27 Andy Lutomirski
2014-07-25 23:27 ` Andy Lutomirski
2014-07-25 23:36 ` [tip:x86/vdso] x86/vdso: " tip-bot for Andy Lutomirski
0 siblings, 2 replies; 3+ messages in thread
From: Andy Lutomirski @ 2014-07-25 23:27 UTC (permalink / raw)
To: hpa, x86, linux-kernel; +Cc: Andy Lutomirski
AFAIK this has no effect whatsoever unless x86 suddenly turns into a
nommu architecture. Nonetheless, not setting it is suspicious.
Reported-by: Nathan Lynch <Nathan_Lynch@mentor.com>
Signed-off-by: Andy Lutomirski <luto@amacapital.net>
---
arch/x86/vdso/vma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/vdso/vma.c b/arch/x86/vdso/vma.c
index dbef622..970463b 100644
--- a/arch/x86/vdso/vma.c
+++ b/arch/x86/vdso/vma.c
@@ -138,7 +138,7 @@ static int map_vdso(const struct vdso_image *image, bool calculate_addr)
vma = _install_special_mapping(mm,
addr,
-image->sym_vvar_start,
- VM_READ,
+ VM_READ|VM_MAYREAD,
&vvar_mapping);
if (IS_ERR(vma)) {
--
1.9.3
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] x86,vdso: Set VM_MAYREAD for the vvar vma
2014-07-25 23:27 [PATCH] x86,vdso: Set VM_MAYREAD for the vvar vma Andy Lutomirski
@ 2014-07-25 23:27 ` Andy Lutomirski
2014-07-25 23:36 ` [tip:x86/vdso] x86/vdso: " tip-bot for Andy Lutomirski
1 sibling, 0 replies; 3+ messages in thread
From: Andy Lutomirski @ 2014-07-25 23:27 UTC (permalink / raw)
To: H. Peter Anvin, X86 ML, linux-kernel; +Cc: Andy Lutomirski
On Fri, Jul 25, 2014 at 4:27 PM, Andy Lutomirski <luto@amacapital.net> wrote:
> AFAIK this has no effect whatsoever unless x86 suddenly turns into a
> nommu architecture. Nonetheless, not setting it is suspicious.
Sorry, forgot to mention: this is based on tip/x86/vdso.
--Andy
>
> Reported-by: Nathan Lynch <Nathan_Lynch@mentor.com>
> Signed-off-by: Andy Lutomirski <luto@amacapital.net>
> ---
> arch/x86/vdso/vma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/vdso/vma.c b/arch/x86/vdso/vma.c
> index dbef622..970463b 100644
> --- a/arch/x86/vdso/vma.c
> +++ b/arch/x86/vdso/vma.c
> @@ -138,7 +138,7 @@ static int map_vdso(const struct vdso_image *image, bool calculate_addr)
> vma = _install_special_mapping(mm,
> addr,
> -image->sym_vvar_start,
> - VM_READ,
> + VM_READ|VM_MAYREAD,
> &vvar_mapping);
>
> if (IS_ERR(vma)) {
> --
> 1.9.3
>
--
Andy Lutomirski
AMA Capital Management, LLC
^ permalink raw reply [flat|nested] 3+ messages in thread* [tip:x86/vdso] x86/vdso: Set VM_MAYREAD for the vvar vma
2014-07-25 23:27 [PATCH] x86,vdso: Set VM_MAYREAD for the vvar vma Andy Lutomirski
2014-07-25 23:27 ` Andy Lutomirski
@ 2014-07-25 23:36 ` tip-bot for Andy Lutomirski
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Andy Lutomirski @ 2014-07-25 23:36 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, luto, hpa, mingo, Nathan_Lynch, tglx, hpa
Commit-ID: ac379835e820de27429b5c4eadf4c1b40320cff4
Gitweb: http://git.kernel.org/tip/ac379835e820de27429b5c4eadf4c1b40320cff4
Author: Andy Lutomirski <luto@amacapital.net>
AuthorDate: Fri, 25 Jul 2014 16:27:01 -0700
Committer: H. Peter Anvin <hpa@linux.intel.com>
CommitDate: Fri, 25 Jul 2014 16:32:53 -0700
x86/vdso: Set VM_MAYREAD for the vvar vma
The VVAR area can, obviously, be read; that is kind of the point.
AFAIK this has no effect whatsoever unless x86 suddenly turns into a
nommu architecture. Nonetheless, not setting it is suspicious.
Reported-by: Nathan Lynch <Nathan_Lynch@mentor.com>
Signed-off-by: Andy Lutomirski <luto@amacapital.net>
Link: http://lkml.kernel.org/r/e4c8bf4bc2725bda22c4a4b7d0c82adcd8f8d9b8.1406330779.git.luto@amacapital.net
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
---
arch/x86/vdso/vma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/vdso/vma.c b/arch/x86/vdso/vma.c
index dbef622..970463b 100644
--- a/arch/x86/vdso/vma.c
+++ b/arch/x86/vdso/vma.c
@@ -138,7 +138,7 @@ static int map_vdso(const struct vdso_image *image, bool calculate_addr)
vma = _install_special_mapping(mm,
addr,
-image->sym_vvar_start,
- VM_READ,
+ VM_READ|VM_MAYREAD,
&vvar_mapping);
if (IS_ERR(vma)) {
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-25 23:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-25 23:27 [PATCH] x86,vdso: Set VM_MAYREAD for the vvar vma Andy Lutomirski
2014-07-25 23:27 ` Andy Lutomirski
2014-07-25 23:36 ` [tip:x86/vdso] x86/vdso: " tip-bot for Andy Lutomirski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®