* [PATCH] x86/boot/e820: remove a redundant self assignment
@ 2017-04-13 15:59 Colin King
2017-04-14 9:45 ` [tip:x86/mm] x86/boot/e820: Remove " tip-bot for Colin King
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-04-13 15:59 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, H . Peter Anvin, x86, Denys Vlasenko
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Remove a redundant self assignment of table->nr_entries, it does
nothing and is an artifact of code simplification re-work.
Detected by CoverityScan, CID#1428450 ("Self assignment")
Fixes: 441ac2f33dd7 ("x86/boot/e820: Simplify e820__update_table()")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
arch/x86/kernel/e820.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c
index 6e9b26fa6d05..d78a586ba8dc 100644
--- a/arch/x86/kernel/e820.c
+++ b/arch/x86/kernel/e820.c
@@ -270,7 +270,6 @@ int __init e820__update_table(struct e820_table *table)
if (table->nr_entries < 2)
return -1;
- table->nr_entries = table->nr_entries;
BUG_ON(table->nr_entries > max_nr_entries);
/* Bail out if we find any unreasonable addresses in the map: */
--
2.11.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* [tip:x86/mm] x86/boot/e820: Remove a redundant self assignment
2017-04-13 15:59 [PATCH] x86/boot/e820: remove a redundant self assignment Colin King
@ 2017-04-14 9:45 ` tip-bot for Colin King
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Colin King @ 2017-04-14 9:45 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, dvlasenk, tglx, colin.king
Commit-ID: ace2fb5a8b65d6aba530068ea9331f18e10ef565
Gitweb: http://git.kernel.org/tip/ace2fb5a8b65d6aba530068ea9331f18e10ef565
Author: Colin King <colin.king@canonical.com>
AuthorDate: Thu, 13 Apr 2017 16:59:12 +0100
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 14 Apr 2017 11:43:21 +0200
x86/boot/e820: Remove a redundant self assignment
Remove a redundant self assignment of table->nr_entries, it does
nothing and is an artifact of code simplification re-work.
Detected by CoverityScan, CID#1428450 ("Self assignment")
Fixes: 441ac2f33dd7 ("x86/boot/e820: Simplify e820__update_table()")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Cc: kernel-janitors@vger.kernel.org
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Link: http://lkml.kernel.org/r/20170413155912.12078-1-colin.king@canonical.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/kernel/e820.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c
index 6e9b26f..d78a586 100644
--- a/arch/x86/kernel/e820.c
+++ b/arch/x86/kernel/e820.c
@@ -270,7 +270,6 @@ int __init e820__update_table(struct e820_table *table)
if (table->nr_entries < 2)
return -1;
- table->nr_entries = table->nr_entries;
BUG_ON(table->nr_entries > max_nr_entries);
/* Bail out if we find any unreasonable addresses in the map: */
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-14 9:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-13 15:59 [PATCH] x86/boot/e820: remove a redundant self assignment Colin King
2017-04-14 9:45 ` [tip:x86/mm] x86/boot/e820: Remove " tip-bot for Colin King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome