[PATCH] Fix typo IBRS_ATT, which should be IBRS_ALL

[PATCH] Fix typo IBRS_ATT, which should be IBRS_ALL

[Darren Kenny]

Fixes a typo in commit 117cc7a908c83697b0b737d15ae1eb5943afe35b
("x86/retpoline: Fill return stack buffer on vmexit")

Signed-off-by: Darren Kenny <darren.kenny@oracle.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
 arch/x86/include/asm/nospec-branch.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/nospec-branch.h b/arch/x86/include/asm/nospec-branch.h
index 4ad4108..5b778d2 100644
--- a/arch/x86/include/asm/nospec-branch.h
+++ b/arch/x86/include/asm/nospec-branch.h
@@ -201,7 +201,7 @@ extern char __indirect_thunk_end[];
  * On VMEXIT we must ensure that no RSB predictions learned in the guest
  * can be followed in the host, by overwriting the RSB completely. Both
  * retpoline and IBRS mitigations for Spectre v2 need this; only on future
- * CPUs with IBRS_ATT *might* it be avoided.
+ * CPUs with IBRS_ALL *might* it be avoided.
  */
 static inline void vmexit_fill_RSB(void)
 {
-- 
2.9.5

[tip:x86/pti] x86/speculation: Fix typo IBRS_ATT, which should be IBRS_ALL

[tip-bot for Darren Kenny]

Commit-ID:  af189c95a371b59f493dbe0f50c0a09724868881
Gitweb:     https://git.kernel.org/tip/af189c95a371b59f493dbe0f50c0a09724868881
Author:     Darren Kenny <darren.kenny@oracle.com>
AuthorDate: Fri, 2 Feb 2018 19:12:20 +0000
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 2 Feb 2018 23:13:57 +0100

x86/speculation: Fix typo IBRS_ATT, which should be IBRS_ALL

Fixes: 117cc7a908c83 ("x86/retpoline: Fill return stack buffer on vmexit")
Signed-off-by: Darren Kenny <darren.kenny@oracle.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Arjan van de Ven <arjan@linux.intel.com>
Cc: David Woodhouse <dwmw@amazon.co.uk>
Link: https://lkml.kernel.org/r/20180202191220.blvgkgutojecxr3b@starbug-vm.ie.oracle.com

---
 arch/x86/include/asm/nospec-branch.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/nospec-branch.h b/arch/x86/include/asm/nospec-branch.h
index d15d471..4d57894 100644
--- a/arch/x86/include/asm/nospec-branch.h
+++ b/arch/x86/include/asm/nospec-branch.h
@@ -150,7 +150,7 @@ extern char __indirect_thunk_end[];
  * On VMEXIT we must ensure that no RSB predictions learned in the guest
  * can be followed in the host, by overwriting the RSB completely. Both
  * retpoline and IBRS mitigations for Spectre v2 need this; only on future
- * CPUs with IBRS_ATT *might* it be avoided.
+ * CPUs with IBRS_ALL *might* it be avoided.
  */
 static inline void vmexit_fill_RSB(void)
 {

Re: [PATCH] Fix typo IBRS_ATT, which should be IBRS_ALL

[David Woodhouse]

[-- Attachment #1: Type: text/plain, Size: 470 bytes --]

On Fri, 2018-02-02 at 19:12 +0000, Darren Kenny wrote:
> Fixes a typo in commit 117cc7a908c83697b0b737d15ae1eb5943afe35b
> ("x86/retpoline: Fill return stack buffer on vmexit")
> 
> Signed-off-by: Darren Kenny <darren.kenny@oracle.com>
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Not strictly a typo; that was the original name for it. "IBRS all the
time". But yes, it should be IBRS_ALL now.

Acked-by: David Woodhouse <dwmw@amazon.co.uk>

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5213 bytes --]

Re: [PATCH] Fix typo IBRS_ATT, which should be IBRS_ALL

[Darren Kenny]

On Fri, Feb 02, 2018 at 11:42:12PM +0000, David Woodhouse wrote:
>On Fri, 2018-02-02 at 19:12 +0000, Darren Kenny wrote:
>> Fixes a typo in commit 117cc7a908c83697b0b737d15ae1eb5943afe35b
>> ("x86/retpoline: Fill return stack buffer on vmexit")
>>
>> Signed-off-by: Darren Kenny <darren.kenny@oracle.com>
>> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>
>Not strictly a typo; that was the original name for it. "IBRS all the
>time". But yes, it should be IBRS_ALL now.
>
>Acked-by: David Woodhouse <dwmw@amazon.co.uk>

Thanks David.

I'll send out another patch with this snippet of information in it
too, and including your Acked-by.

(The subject like will be slightly different)

Thanks,

Darren.

Re: [PATCH] Fix typo IBRS_ATT, which should be IBRS_ALL

[David Woodhouse]

[-- Attachment #1: Type: text/plain, Size: 810 bytes --]

On Mon, 2018-02-05 at 11:00 +0000, Darren Kenny wrote:
> On Fri, Feb 02, 2018 at 11:42:12PM +0000, David Woodhouse wrote:
> > 
> > On Fri, 2018-02-02 at 19:12 +0000, Darren Kenny wrote:
> > > 
> > > Fixes a typo in commit 117cc7a908c83697b0b737d15ae1eb5943afe35b
> > > ("x86/retpoline: Fill return stack buffer on vmexit")
> > > 
> > > Signed-off-by: Darren Kenny <darren.kenny@oracle.com>
> > > Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > Not strictly a typo; that was the original name for it. "IBRS all
> > the
> > time". But yes, it should be IBRS_ALL now.
> > 
> > Acked-by: David Woodhouse <dwmw@amazon.co.uk>
> Thanks David.
> 
> I'll send out another patch with this snippet of information in it
> too, and including your Acked-by.

It's in Linus's tree already.

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5213 bytes --]