* [PATCH] irqchip: crossbar: Fix incorrect type of local variables
@ 2017-02-23 9:48 Franck Demathieu
2017-03-01 9:10 ` [tip:irq/urgent] irqchip/crossbar: " tip-bot for Franck Demathieu
0 siblings, 1 reply; 2+ messages in thread
From: Franck Demathieu @ 2017-02-23 9:48 UTC (permalink / raw)
To: tglx, jason, marc.zyngier; +Cc: linux-kernel
The max and entry variables are unsigned according to the dt-bindings.
Fix following 3 sparse issues (-Wtypesign):
drivers/irqchip/irq-crossbar.c:222:52: warning: incorrect type in argument 3 (different signedness)
drivers/irqchip/irq-crossbar.c:222:52: expected unsigned int [usertype] *out_value
drivers/irqchip/irq-crossbar.c:222:52: got int *<noident>
drivers/irqchip/irq-crossbar.c:245:56: warning: incorrect type in argument 4 (different signedness)
drivers/irqchip/irq-crossbar.c:245:56: expected unsigned int [usertype] *out_value
drivers/irqchip/irq-crossbar.c:245:56: got int *<noident>
drivers/irqchip/irq-crossbar.c:263:56: warning: incorrect type in argument 4 (different signedness)
drivers/irqchip/irq-crossbar.c:263:56: expected unsigned int [usertype] *out_value
drivers/irqchip/irq-crossbar.c:263:56: got int *<noident>
Signed-off-by: Franck Demathieu <fdemathieu@gmail.com>
---
drivers/irqchip/irq-crossbar.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
index 1eef56a..05bbf17 100644
--- a/drivers/irqchip/irq-crossbar.c
+++ b/drivers/irqchip/irq-crossbar.c
@@ -198,7 +198,8 @@ static int crossbar_domain_translate(struct irq_domain *d,
static int __init crossbar_of_init(struct device_node *node)
{
- int i, size, max = 0, reserved = 0, entry;
+ int i, size, reserved = 0;
+ u32 max = 0, entry;
const __be32 *irqsr;
int ret = -ENOMEM;
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread* [tip:irq/urgent] irqchip/crossbar: Fix incorrect type of local variables
2017-02-23 9:48 [PATCH] irqchip: crossbar: Fix incorrect type of local variables Franck Demathieu
@ 2017-03-01 9:10 ` tip-bot for Franck Demathieu
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Franck Demathieu @ 2017-03-01 9:10 UTC (permalink / raw)
To: linux-tip-commits; +Cc: mingo, linux-kernel, hpa, fdemathieu, tglx
Commit-ID: b28ace12661fbcfd90959c1e84ff5a85113a82a1
Gitweb: http://git.kernel.org/tip/b28ace12661fbcfd90959c1e84ff5a85113a82a1
Author: Franck Demathieu <fdemathieu@gmail.com>
AuthorDate: Thu, 23 Feb 2017 10:48:55 +0100
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 1 Mar 2017 10:08:20 +0100
irqchip/crossbar: Fix incorrect type of local variables
The max and entry variables are unsigned according to the dt-bindings.
Fix following 3 sparse issues (-Wtypesign):
drivers/irqchip/irq-crossbar.c:222:52: warning: incorrect type in argument 3 (different signedness)
drivers/irqchip/irq-crossbar.c:222:52: expected unsigned int [usertype] *out_value
drivers/irqchip/irq-crossbar.c:222:52: got int *<noident>
drivers/irqchip/irq-crossbar.c:245:56: warning: incorrect type in argument 4 (different signedness)
drivers/irqchip/irq-crossbar.c:245:56: expected unsigned int [usertype] *out_value
drivers/irqchip/irq-crossbar.c:245:56: got int *<noident>
drivers/irqchip/irq-crossbar.c:263:56: warning: incorrect type in argument 4 (different signedness)
drivers/irqchip/irq-crossbar.c:263:56: expected unsigned int [usertype] *out_value
drivers/irqchip/irq-crossbar.c:263:56: got int *<noident>
Signed-off-by: Franck Demathieu <fdemathieu@gmail.com>
Cc: marc.zyngier@arm.com
Cc: jason@lakedaemon.net
Link: http://lkml.kernel.org/r/20170223094855.6546-1-fdemathieu@gmail.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
drivers/irqchip/irq-crossbar.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
index 1eef56a..05bbf17 100644
--- a/drivers/irqchip/irq-crossbar.c
+++ b/drivers/irqchip/irq-crossbar.c
@@ -198,7 +198,8 @@ static const struct irq_domain_ops crossbar_domain_ops = {
static int __init crossbar_of_init(struct device_node *node)
{
- int i, size, max = 0, reserved = 0, entry;
+ int i, size, reserved = 0;
+ u32 max = 0, entry;
const __be32 *irqsr;
int ret = -ENOMEM;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-01 10:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-23 9:48 [PATCH] irqchip: crossbar: Fix incorrect type of local variables Franck Demathieu
2017-03-01 9:10 ` [tip:irq/urgent] irqchip/crossbar: " tip-bot for Franck Demathieu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®