* [PATCH v4] x86/boot/early_serial_console: Remove unnecessary check
@ 2014-12-31 7:12 Alexander Kuleshov
2014-12-31 13:57 ` Borislav Petkov
2015-01-16 8:07 ` [tip:x86/cleanups] x86, early_serial_console: " tip-bot for Alexander Kuleshov
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Kuleshov @ 2014-12-31 7:12 UTC (permalink / raw)
To: Borislav Petkov
Cc: H. Peter Anvin, Thomas Gleixner, Ingo Molnar, linux-kernel,
Alexander Kuleshov
There is already the same check before.
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
arch/x86/boot/early_serial_console.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/boot/early_serial_console.c b/arch/x86/boot/early_serial_console.c
index 5df2869..2b1c403 100644
--- a/arch/x86/boot/early_serial_console.c
+++ b/arch/x86/boot/early_serial_console.c
@@ -74,8 +74,8 @@ static void parse_earlyprintk(void)
static const int bases[] = { 0x3f8, 0x2f8 };
int idx = 0;
- if (!strncmp(arg + pos, "ttyS", 4))
- pos += 4;
+ /* += strlen("ttyS"); */
+ pos += 4;
if (arg[pos++] == '1')
idx = 1;
--
2.2.1.202.g44ae4ee.dirty
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v4] x86/boot/early_serial_console: Remove unnecessary check
2014-12-31 7:12 [PATCH v4] x86/boot/early_serial_console: Remove unnecessary check Alexander Kuleshov
@ 2014-12-31 13:57 ` Borislav Petkov
2015-01-16 8:07 ` [tip:x86/cleanups] x86, early_serial_console: " tip-bot for Alexander Kuleshov
1 sibling, 0 replies; 3+ messages in thread
From: Borislav Petkov @ 2014-12-31 13:57 UTC (permalink / raw)
To: Alexander Kuleshov
Cc: H. Peter Anvin, Thomas Gleixner, Ingo Molnar, linux-kernel
On Wed, Dec 31, 2014 at 01:12:38PM +0600, Alexander Kuleshov wrote:
> There is already the same check before.
>
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Acked-by: Borislav Petkov <bp@suse.de>
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:x86/cleanups] x86, early_serial_console: Remove unnecessary check
2014-12-31 7:12 [PATCH v4] x86/boot/early_serial_console: Remove unnecessary check Alexander Kuleshov
2014-12-31 13:57 ` Borislav Petkov
@ 2015-01-16 8:07 ` tip-bot for Alexander Kuleshov
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Alexander Kuleshov @ 2015-01-16 8:07 UTC (permalink / raw)
To: linux-tip-commits; +Cc: bp, hpa, tglx, linux-kernel, mingo, kuleshovmail
Commit-ID: b34630014dad0ba69aadd8deb231ddc6d2efcf53
Gitweb: http://git.kernel.org/tip/b34630014dad0ba69aadd8deb231ddc6d2efcf53
Author: Alexander Kuleshov <kuleshovmail@gmail.com>
AuthorDate: Wed, 31 Dec 2014 13:12:38 +0600
Committer: Borislav Petkov <bp@suse.de>
CommitDate: Tue, 13 Jan 2015 12:14:44 +0100
x86, early_serial_console: Remove unnecessary check
We do this check already a couple of lines up.
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Link: http://lkml.kernel.org/r/1420009958-4803-1-git-send-email-kuleshovmail@gmail.com
Signed-off-by: Borislav Petkov <bp@suse.de>
---
arch/x86/boot/early_serial_console.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/boot/early_serial_console.c b/arch/x86/boot/early_serial_console.c
index 790586d..45a0768 100644
--- a/arch/x86/boot/early_serial_console.c
+++ b/arch/x86/boot/early_serial_console.c
@@ -72,8 +72,8 @@ static void parse_earlyprintk(void)
static const int bases[] = { 0x3f8, 0x2f8 };
int idx = 0;
- if (!strncmp(arg + pos, "ttyS", 4))
- pos += 4;
+ /* += strlen("ttyS"); */
+ pos += 4;
if (arg[pos++] == '1')
idx = 1;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-16 8:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-31 7:12 [PATCH v4] x86/boot/early_serial_console: Remove unnecessary check Alexander Kuleshov
2014-12-31 13:57 ` Borislav Petkov
2015-01-16 8:07 ` [tip:x86/cleanups] x86, early_serial_console: " tip-bot for Alexander Kuleshov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome