* [PATCH RESEND] x86, AMD: Set ARAT feature on AMD processors
@ 2011-03-15 16:13 Boris Ostrovsky
2011-03-16 13:57 ` [tip:x86/urgent] " tip-bot for Boris Ostrovsky
0 siblings, 1 reply; 2+ messages in thread
From: Boris Ostrovsky @ 2011-03-15 16:13 UTC (permalink / raw)
To: hpa, mingo, tglx
Cc: borislav.petkov, andreas.herrmann3, mark.langsdorf, linux-kernel,
Boris Ostrovsky
From: Boris Ostrovsky <boris.ostrovsky@amd.com>
Support for Always Running APIC timer (ARAT) was introduced in commit
db954b5898dd3ef3ef93f4144158ea8f97deb058. This feature allows us to
avoid switching timers from LAPIC to something else (e.g. HPET) and
go into timer broadcasts when entering deep C-states.
AMD processors don't provide a CPUID bit for that feature but they also
keep APIC timers running in deep C-states (except for cases when the
processor is affected by erratum 400). Therefore we should set ARAT
feature bit on AMD CPUs.
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@amd.com>
Tested-by: Borislav Petkov <borislav.petkov@amd.com>
Acked-by: Andreas Herrmann <andreas.herrmann3@amd.com>
Acked-by: Mark Langsdorf <mark.langsdorf@amd.com>
---
arch/x86/kernel/cpu/amd.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
index 7c7bedb..48eaa1b 100644
--- a/arch/x86/kernel/cpu/amd.c
+++ b/arch/x86/kernel/cpu/amd.c
@@ -594,6 +594,10 @@ static void __cpuinit init_amd(struct cpuinfo_x86 *c)
}
}
#endif
+
+ /* As a rule processors have APIC timer running in deep C states */
+ if (c->x86 >= 0xf && !cpu_has_amd_erratum(amd_erratum_400))
+ set_cpu_cap(c, X86_FEATURE_ARAT);
}
#ifdef CONFIG_X86_32
--
1.7.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [tip:x86/urgent] x86, AMD: Set ARAT feature on AMD processors
2011-03-15 16:13 [PATCH RESEND] x86, AMD: Set ARAT feature on AMD processors Boris Ostrovsky
@ 2011-03-16 13:57 ` tip-bot for Boris Ostrovsky
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Boris Ostrovsky @ 2011-03-16 13:57 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, andreas.herrmann3, boris.ostrovsky,
mark.langsdorf, tglx, mingo, borislav.petkov
Commit-ID: b87cf80af3ba4b4c008b4face3c68d604e1715c6
Gitweb: http://git.kernel.org/tip/b87cf80af3ba4b4c008b4face3c68d604e1715c6
Author: Boris Ostrovsky <boris.ostrovsky@amd.com>
AuthorDate: Tue, 15 Mar 2011 12:13:44 -0400
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Wed, 16 Mar 2011 14:03:33 +0100
x86, AMD: Set ARAT feature on AMD processors
Support for Always Running APIC timer (ARAT) was introduced in
commit db954b5898dd3ef3ef93f4144158ea8f97deb058. This feature
allows us to avoid switching timers from LAPIC to something else
(e.g. HPET) and go into timer broadcasts when entering deep
C-states.
AMD processors don't provide a CPUID bit for that feature but
they also keep APIC timers running in deep C-states (except for
cases when the processor is affected by erratum 400). Therefore
we should set ARAT feature bit on AMD CPUs.
Tested-by: Borislav Petkov <borislav.petkov@amd.com>
Acked-by: Andreas Herrmann <andreas.herrmann3@amd.com>
Acked-by: Mark Langsdorf <mark.langsdorf@amd.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@amd.com>
LKML-Reference: <1300205624-4813-1-git-send-email-ostr@amd64.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/cpu/amd.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
index 7c7bedb..48eaa1b 100644
--- a/arch/x86/kernel/cpu/amd.c
+++ b/arch/x86/kernel/cpu/amd.c
@@ -594,6 +594,10 @@ static void __cpuinit init_amd(struct cpuinfo_x86 *c)
}
}
#endif
+
+ /* As a rule processors have APIC timer running in deep C states */
+ if (c->x86 >= 0xf && !cpu_has_amd_erratum(amd_erratum_400))
+ set_cpu_cap(c, X86_FEATURE_ARAT);
}
#ifdef CONFIG_X86_32
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-16 13:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-15 16:13 [PATCH RESEND] x86, AMD: Set ARAT feature on AMD processors Boris Ostrovsky
2011-03-16 13:57 ` [tip:x86/urgent] " tip-bot for Boris Ostrovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome