[PATCH 0/1] x86/platform/UV: UV Fix patches for Intel processors

[PATCH 0/1] x86/platform/UV: UV Fix patches for Intel processors

[mike.travis]

Updates to UV4 fix patches.

-- 

[PATCH 1/1] x86/platform/UV: Fix critical UV MMR address error

[mike.travis]

[-- Attachment #1: fix-gam-mmioh-config1 --]
[-- Type: text/plain, Size: 1076 bytes --]

A critical error was found testing the fixed UV4 HUB in that an MMR
address was found to be incorrect.  This causes the virtual address
space for accessing the MMIOH1 region to be allocated with the
incorrect size.

Signed-off-by: Mike Travis <travis@sgi.com>
---
 arch/x86/include/asm/uv/uv_mmrs.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-4.4.orig/arch/x86/include/asm/uv/uv_mmrs.h
+++ linux-4.4/arch/x86/include/asm/uv/uv_mmrs.h
@@ -3833,7 +3833,7 @@ union uvh_rh_gam_mmioh_overlay_config0_m
 #define UV1H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR uv_undefined("UV1H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR")
 #define UV2H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR uv_undefined("UV2H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR")
 #define UV3H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR 0x1603000UL
-#define UV4H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR 0x483000UL
+#define UV4H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR 0x484000UL
 #define UVH_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR (				\
 	is_uv1_hub() ? UV1H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR :		\
 	is_uv2_hub() ? UV2H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR :		\

-- 

Re: [PATCH 1/1] x86/platform/UV: Fix critical UV MMR address error

[Thomas Gleixner]

On Wed, 28 Mar 2018, mike.travis@hpe.com wrote:

> A critical error was found testing the fixed UV4 HUB in that an MMR
> address was found to be incorrect.  This causes the virtual address
> space for accessing the MMIOH1 region to be allocated with the
> incorrect size.

Even if this is not intended for stable, despite the diff 

> --- linux-4.4.orig/arch/x86/include/asm/uv/uv_mmrs.h
> +++ linux-4.4/arch/x86/include/asm/uv/uv_mmrs.h

suggesting that this is against a kernel, which receives respiration
treatment, it would be appreciated if you could add a Fixes tag next time.

That spares me the time to figure out which commit introduced the wreckage
and therefore the scope of the fix. Added it myself.

Thanks,

	tglx

> @@ -3833,7 +3833,7 @@ union uvh_rh_gam_mmioh_overlay_config0_m
>  #define UV1H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR uv_undefined("UV1H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR")
>  #define UV2H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR uv_undefined("UV2H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR")
>  #define UV3H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR 0x1603000UL
> -#define UV4H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR 0x483000UL
> +#define UV4H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR 0x484000UL
>  #define UVH_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR (				\
>  	is_uv1_hub() ? UV1H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR :		\
>  	is_uv2_hub() ? UV2H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR :		\
> 
> -- 
> 

[tip:x86/urgent] x86/platform/UV: Fix critical UV MMR address error

[tip-bot for mike.travis@hpe.com]

Commit-ID:  bd47a85acd727e27b7283daff557865ad04c59f6
Gitweb:     https://git.kernel.org/tip/bd47a85acd727e27b7283daff557865ad04c59f6
Author:     mike.travis@hpe.com <mike.travis@hpe.com>
AuthorDate: Wed, 28 Mar 2018 12:40:11 -0500
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 28 Mar 2018 20:19:45 +0200

x86/platform/UV: Fix critical UV MMR address error

A critical error was found testing the fixed UV4 HUB in that an MMR address
was found to be incorrect.  This causes the virtual address space for
accessing the MMIOH1 region to be allocated with the incorrect size.

Fixes: 673aa20c55a1 ("x86/platform/UV: Update uv_mmrs.h to prepare for UV4A fixes")
Signed-off-by: Mike Travis <travis@sgi.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Dimitri Sivanich <dimitri.sivanich@hpe.com>
Cc: Russ Anderson <russ.anderson@hpe.com>
Cc: Andrew Banman <andrew.banman@hpe.com>
Link: https://lkml.kernel.org/r/20180328174011.041801248@stormcage.americas.sgi.com

---
 arch/x86/include/asm/uv/uv_mmrs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/uv/uv_mmrs.h b/arch/x86/include/asm/uv/uv_mmrs.h
index ecb9ddef128f..62c79e26a59a 100644
--- a/arch/x86/include/asm/uv/uv_mmrs.h
+++ b/arch/x86/include/asm/uv/uv_mmrs.h
@@ -3833,7 +3833,7 @@ union uvh_rh_gam_mmioh_overlay_config0_mmr_u {
 #define UV1H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR uv_undefined("UV1H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR")
 #define UV2H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR uv_undefined("UV2H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR")
 #define UV3H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR 0x1603000UL
-#define UV4H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR 0x483000UL
+#define UV4H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR 0x484000UL
 #define UVH_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR (				\
 	is_uv1_hub() ? UV1H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR :		\
 	is_uv2_hub() ? UV2H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR :		\

Re: [PATCH 1/1] x86/platform/UV: Fix critical UV MMR address error

[Mike Travis]

On 3/28/2018 11:17 AM, Thomas Gleixner wrote:
> On Wed, 28 Mar 2018, mike.travis@hpe.com wrote:
> 
>> A critical error was found testing the fixed UV4 HUB in that an MMR
>> address was found to be incorrect.  This causes the virtual address
>> space for accessing the MMIOH1 region to be allocated with the
>> incorrect size.
> 
> Even if this is not intended for stable, despite the diff

Yes, I realized I missed 'stable' a moment or two after hitting send.
> 
>> --- linux-4.4.orig/arch/x86/include/asm/uv/uv_mmrs.h
>> +++ linux-4.4/arch/x86/include/asm/uv/uv_mmrs.h
> 
> suggesting that this is against a kernel, which receives respiration
> treatment, it would be appreciated if you could add a Fixes tag next time.

Sorry I didn't know about that.  Here it is:

Commit-ID:  673aa20c55a138621d1340d343cd6b07c1cb4e92
Gitweb: 
https://.kernel.org/tip/673aa20c55a13862git1d1340d343cd6b07c1cb4e92
Author:     Mike Travis <mike.travis@hpe.com>
AuthorDate: Mon, 8 Jan 2018 13:39:59 -0600
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 16 Jan 2018 03:58:36 +0100

x86/platform/UV: Update uv_mmrs.h to prepare for UV4A fixes

Regenerate uv_mmrs.h file to accommodate fixes to UV4A MMRs.
> 
> That spares me the time to figure out which commit introduced the wreckage
> and therefore the scope of the fix. Added it myself.

Oh, well the above should be the same as what you found.
> 
> Thanks,
> 
> 	tglx

Thank You!
> 
>> @@ -3833,7 +3833,7 @@ union uvh_rh_gam_mmioh_overlay_config0_m
>>   #define UV1H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR uv_undefined("UV1H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR")
>>   #define UV2H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR uv_undefined("UV2H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR")
>>   #define UV3H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR 0x1603000UL
>> -#define UV4H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR 0x483000UL
>> +#define UV4H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR 0x484000UL
>>   #define UVH_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR (				\
>>   	is_uv1_hub() ? UV1H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR :		\
>>   	is_uv2_hub() ? UV2H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR :		\
>>
>> -- 
>>