mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] PM / irq: Fix comment describing suspend_device_irqs()
@ 2009-07-04 22:22 Rafael J. Wysocki
  2009-07-05 11:09 ` [tip:irq/core] genirq: " tip-bot for Rafael J. Wysocki
  0 siblings, 1 reply; 2+ messages in thread
From: Rafael J. Wysocki @ 2009-07-04 22:22 UTC (permalink / raw)
  To: Linux-pm mailing list; +Cc: LKML, Andrew Morton, Ingo Molnar, Thomas Gleixner

From: Rafael J. Wysocki <rjw@sisk.pl>

The kerneldoc comment describing suspend_device_irqs() is currently
misleading, because generally the function doesn't really disable
interrupt lines at the chip level.  Replace it with a more accurate
one.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
 kernel/irq/pm.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Index: linux-2.6/kernel/irq/pm.c
===================================================================
--- linux-2.6.orig/kernel/irq/pm.c
+++ linux-2.6/kernel/irq/pm.c
@@ -15,10 +15,10 @@
 /**
  * suspend_device_irqs - disable all currently enabled interrupt lines
  *
- * During system-wide suspend or hibernation device interrupts need to be
- * disabled at the chip level and this function is provided for this purpose.
- * It disables all interrupt lines that are enabled at the moment and sets the
- * IRQ_SUSPENDED flag for them.
+ * During system-wide suspend or hibernation device drivers need to be prevented
+ * from receiving interrupts and this function is provided for this purpose.
+ * It marks all interrupt lines in use, except for the timer ones, as disabled
+ * and sets the IRQ_SUSPENDED flag for each of them.
  */
 void suspend_device_irqs(void)
 {

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [tip:irq/core] genirq: Fix comment describing suspend_device_irqs()
  2009-07-04 22:22 [PATCH] PM / irq: Fix comment describing suspend_device_irqs() Rafael J. Wysocki
@ 2009-07-05 11:09 ` tip-bot for Rafael J. Wysocki
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Rafael J. Wysocki @ 2009-07-05 11:09 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, tglx, rjw

Commit-ID:  c71320d0c445e01555a86fa6523609db47eeaef6
Gitweb:     http://git.kernel.org/tip/c71320d0c445e01555a86fa6523609db47eeaef6
Author:     Rafael J. Wysocki <rjw@sisk.pl>
AuthorDate: Sun, 5 Jul 2009 00:22:34 +0200
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Sun, 5 Jul 2009 13:07:00 +0200

genirq: Fix comment describing suspend_device_irqs()

The kerneldoc comment describing suspend_device_irqs() is currently
misleading, because generally the function doesn't really disable
interrupt lines at the chip level.  Replace it with a more accurate
one.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
LKML-Reference: <200907050022.35117.rjw@sisk.pl>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>


---
 kernel/irq/pm.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/kernel/irq/pm.c b/kernel/irq/pm.c
index 638d8be..a0bb09e 100644
--- a/kernel/irq/pm.c
+++ b/kernel/irq/pm.c
@@ -15,10 +15,10 @@
 /**
  * suspend_device_irqs - disable all currently enabled interrupt lines
  *
- * During system-wide suspend or hibernation device interrupts need to be
- * disabled at the chip level and this function is provided for this purpose.
- * It disables all interrupt lines that are enabled at the moment and sets the
- * IRQ_SUSPENDED flag for them.
+ * During system-wide suspend or hibernation device drivers need to be prevented
+ * from receiving interrupts and this function is provided for this purpose.
+ * It marks all interrupt lines in use, except for the timer ones, as disabled
+ * and sets the IRQ_SUSPENDED flag for each of them.
  */
 void suspend_device_irqs(void)
 {

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-07-05 11:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-07-04 22:22 [PATCH] PM / irq: Fix comment describing suspend_device_irqs() Rafael J. Wysocki
2009-07-05 11:09 ` [tip:irq/core] genirq: " tip-bot for Rafael J. Wysocki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome