mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 3/3] perf tests: remove getpgrp from mmap-basic
@ 2015-04-16 13:52 riku.voipio
  2015-05-29 18:37 ` [tip:perf/core] perf tests: Remove " tip-bot for Riku Voipio
  0 siblings, 1 reply; 2+ messages in thread
From: riku.voipio @ 2015-04-16 13:52 UTC (permalink / raw)
  To: a.p.zijlstra, paulus, mingo, linux-kernel; +Cc: Riku Voipio

From: Riku Voipio <riku.voipio@linaro.org>

mmap-basic fails on arm64.

 4: read samples using the mmap interface                    :
read samples using the mmap interface: FAILED!

This is because arm64 doesn't come with getpgrp()
syscall. The syscall is a BSD compatibility wrapper,
Archs that don't define __ARCH_WANT_SYS_GETPGRP do
not have this. Remove it, since getpgid is already
used in the testcase.

Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
---
 tools/perf/tests/mmap-basic.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/tools/perf/tests/mmap-basic.c b/tools/perf/tests/mmap-basic.c
index 9b9622a..5855cf4 100644
--- a/tools/perf/tests/mmap-basic.c
+++ b/tools/perf/tests/mmap-basic.c
@@ -23,10 +23,8 @@ int test__basic_mmap(void)
 	struct cpu_map *cpus;
 	struct perf_evlist *evlist;
 	cpu_set_t cpu_set;
-	const char *syscall_names[] = { "getsid", "getppid", "getpgrp",
-					"getpgid", };
-	pid_t (*syscalls[])(void) = { (void *)getsid, getppid, getpgrp,
-				      (void*)getpgid };
+	const char *syscall_names[] = { "getsid", "getppid", "getpgid", };
+	pid_t (*syscalls[])(void) = { (void *)getsid, getppid, (void*)getpgid };
 #define nsyscalls ARRAY_SIZE(syscall_names)
 	unsigned int nr_events[nsyscalls],
 		     expected_nr_events[nsyscalls], i, j;
-- 
2.1.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [tip:perf/core] perf tests: Remove getpgrp from mmap-basic
  2015-04-16 13:52 [PATCH 3/3] perf tests: remove getpgrp from mmap-basic riku.voipio
@ 2015-05-29 18:37 ` tip-bot for Riku Voipio
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Riku Voipio @ 2015-05-29 18:37 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: linux-kernel, acme, mingo, hpa, riku.voipio, a.p.zijlstra, tglx

Commit-ID:  cec83938707a7055c1f9decd81f2741420518e64
Gitweb:     http://git.kernel.org/tip/cec83938707a7055c1f9decd81f2741420518e64
Author:     Riku Voipio <riku.voipio@linaro.org>
AuthorDate: Thu, 16 Apr 2015 16:52:55 +0300
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 29 May 2015 12:43:42 -0300

perf tests: Remove getpgrp from mmap-basic

mmap-basic fails on arm64.

 4: read samples using the mmap interface: read samples using the mmap interface: FAILED!

This is because arm64 doesn't come with getpgrp() syscall. The syscall
is a BSD compatibility wrapper, Archs that don't define
__ARCH_WANT_SYS_GETPGRP do not have this. Remove it, since getpgid is
already used in the testcase.

Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
Reviewed-by: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1429192375-13706-4-git-send-email-riku.voipio@linaro.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/tests/mmap-basic.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/tools/perf/tests/mmap-basic.c b/tools/perf/tests/mmap-basic.c
index 9b9622a..5855cf4 100644
--- a/tools/perf/tests/mmap-basic.c
+++ b/tools/perf/tests/mmap-basic.c
@@ -23,10 +23,8 @@ int test__basic_mmap(void)
 	struct cpu_map *cpus;
 	struct perf_evlist *evlist;
 	cpu_set_t cpu_set;
-	const char *syscall_names[] = { "getsid", "getppid", "getpgrp",
-					"getpgid", };
-	pid_t (*syscalls[])(void) = { (void *)getsid, getppid, getpgrp,
-				      (void*)getpgid };
+	const char *syscall_names[] = { "getsid", "getppid", "getpgid", };
+	pid_t (*syscalls[])(void) = { (void *)getsid, getppid, (void*)getpgid };
 #define nsyscalls ARRAY_SIZE(syscall_names)
 	unsigned int nr_events[nsyscalls],
 		     expected_nr_events[nsyscalls], i, j;

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-05-29 18:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-16 13:52 [PATCH 3/3] perf tests: remove getpgrp from mmap-basic riku.voipio
2015-05-29 18:37 ` [tip:perf/core] perf tests: Remove " tip-bot for Riku Voipio

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome