mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] timers: Remove duplicate setting of new_base in __mod_timer()
@ 2009-12-17  0:15 Simon Horman
  2009-12-17  0:36 ` [tip:timers/urgent] " tip-bot for Simon Horman
  0 siblings, 1 reply; 2+ messages in thread
From: Simon Horman @ 2009-12-17  0:15 UTC (permalink / raw)
  To: linux-kernel; +Cc: Thomas Gleixner

new_base is set using per_cpu(tvec_bases, cpu) after selecting the desired
value of cpu immediately below so this line is a unnecessary.

Signed-off-by: Simon Horman <horms@verge.net.au>

Index: linux-2.6/kernel/timer.c
===================================================================
--- linux-2.6.orig/kernel/timer.c	2009-12-17 07:02:57.000000000 +0900
+++ linux-2.6/kernel/timer.c	2009-12-17 07:03:17.000000000 +0900
@@ -656,8 +656,6 @@ __mod_timer(struct timer_list *timer, un
 
 	debug_activate(timer, expires);
 
-	new_base = __get_cpu_var(tvec_bases);
-
 	cpu = smp_processor_id();
 
 #if defined(CONFIG_NO_HZ) && defined(CONFIG_SMP)

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [tip:timers/urgent] timers: Remove duplicate setting of new_base in __mod_timer()
  2009-12-17  0:15 [PATCH] timers: Remove duplicate setting of new_base in __mod_timer() Simon Horman
@ 2009-12-17  0:36 ` tip-bot for Simon Horman
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Simon Horman @ 2009-12-17  0:36 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: linux-kernel, horms, hpa, mingo, tglx

Commit-ID:  cf1e367ee84e02ac349ad0858eb65e8a6a511c8b
Gitweb:     http://git.kernel.org/tip/cf1e367ee84e02ac349ad0858eb65e8a6a511c8b
Author:     Simon Horman <horms@verge.net.au>
AuthorDate: Thu, 17 Dec 2009 11:15:42 +1100
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 17 Dec 2009 01:30:49 +0100

timers: Remove duplicate setting of new_base in __mod_timer()

new_base is set using per_cpu(tvec_bases, cpu) after selecting the
desired value of cpu immediately below so this line is a unnecessary.

Signed-off-by: Simon Horman <horms@verge.net.au>
LKML-Reference: <20091217001542.GD25317@verge.net.au>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

---
 kernel/timer.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/kernel/timer.c b/kernel/timer.c
index 5db5a8d..15533b7 100644
--- a/kernel/timer.c
+++ b/kernel/timer.c
@@ -656,8 +656,6 @@ __mod_timer(struct timer_list *timer, unsigned long expires,
 
 	debug_activate(timer, expires);
 
-	new_base = __get_cpu_var(tvec_bases);
-
 	cpu = smp_processor_id();
 
 #if defined(CONFIG_NO_HZ) && defined(CONFIG_SMP)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-12-17  0:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-12-17  0:15 [PATCH] timers: Remove duplicate setting of new_base in __mod_timer() Simon Horman
2009-12-17  0:36 ` [tip:timers/urgent] " tip-bot for Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®