mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] perf lock: dropping unsupported ':r' modifier
@ 2011-07-30 14:13 Zhu Yanhai
  2011-08-10  8:25 ` [tip:perf/urgent] perf lock: Dropping " tip-bot for Zhu Yanhai
  0 siblings, 1 reply; 2+ messages in thread
From: Zhu Yanhai @ 2011-07-30 14:13 UTC (permalink / raw)
  To: a.p.zijlstra, paulus, mingo, acme; +Cc: linux-kernel, Zhu Yanhai

Looks to me like the :r modifier is not supported anymore, so remove it from
the list of events. Without this fix 'perf lock record' doesn't work.

Signed-off-by: Zhu Yanhai <gaoyang.zyh@taobao.com>
---
 tools/perf/builtin-lock.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
index 9ac05aa..899080a 100644
--- a/tools/perf/builtin-lock.c
+++ b/tools/perf/builtin-lock.c
@@ -942,10 +942,10 @@ static const char *record_args[] = {
 	"-f",
 	"-m", "1024",
 	"-c", "1",
-	"-e", "lock:lock_acquire:r",
-	"-e", "lock:lock_acquired:r",
-	"-e", "lock:lock_contended:r",
-	"-e", "lock:lock_release:r",
+	"-e", "lock:lock_acquire",
+	"-e", "lock:lock_acquired",
+	"-e", "lock:lock_contended",
+	"-e", "lock:lock_release",
 };
 
 static int __cmd_record(int argc, const char **argv)
-- 
1.5.5.6


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [tip:perf/urgent] perf lock: Dropping unsupported ':r' modifier
  2011-07-30 14:13 [PATCH] perf lock: dropping unsupported ':r' modifier Zhu Yanhai
@ 2011-08-10  8:25 ` tip-bot for Zhu Yanhai
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Zhu Yanhai @ 2011-08-10  8:25 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: acme, linux-kernel, paulus, hpa, mingo, a.p.zijlstra, tglx,
	zhu.yanhai, gaoyang.zyh, mingo

Commit-ID:  cf8dc9ff29b55955197ae6f628b19f7f41f6e582
Gitweb:     http://git.kernel.org/tip/cf8dc9ff29b55955197ae6f628b19f7f41f6e582
Author:     Zhu Yanhai <zhu.yanhai@gmail.com>
AuthorDate: Sat, 30 Jul 2011 22:13:52 +0800
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 8 Aug 2011 09:41:35 -0300

perf lock: Dropping unsupported ':r' modifier

Looks to me like the :r modifier is not supported anymore, so remove it
from the list of events. Without this fix 'perf lock record' doesn't
work.

Cc: Ingo Molnar <mingo@elte.hu>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Zhu Yanhai <gaoyang.zyh@taobao.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1312035232-9534-1-git-send-email-gaoyang.zyh@taobao.com
Signed-off-by: Zhu Yanhai <gaoyang.zyh@taobao.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-lock.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
index 9ac05aa..899080a 100644
--- a/tools/perf/builtin-lock.c
+++ b/tools/perf/builtin-lock.c
@@ -942,10 +942,10 @@ static const char *record_args[] = {
 	"-f",
 	"-m", "1024",
 	"-c", "1",
-	"-e", "lock:lock_acquire:r",
-	"-e", "lock:lock_acquired:r",
-	"-e", "lock:lock_contended:r",
-	"-e", "lock:lock_release:r",
+	"-e", "lock:lock_acquire",
+	"-e", "lock:lock_acquired",
+	"-e", "lock:lock_contended",
+	"-e", "lock:lock_release",
 };
 
 static int __cmd_record(int argc, const char **argv)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-08-10  8:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-30 14:13 [PATCH] perf lock: dropping unsupported ':r' modifier Zhu Yanhai
2011-08-10  8:25 ` [tip:perf/urgent] perf lock: Dropping " tip-bot for Zhu Yanhai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome