[PATCH] perf/core: Remove unused function perf_cgroup_event_cgrp_time()

[PATCH] perf/core: Remove unused function perf_cgroup_event_cgrp_time()

[Matthias Kaehlcke]

The function was added by commit e5d1367f17ba ("perf: Add cgroup
support") in 2011 and hasn't been used since then. Removing it fixes the
following warning when building with clang:

    kernel/events/core.c:696:19: error: unused function
        'perf_cgroup_event_cgrp_time' [-Werror,-Wunused-function]

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
 kernel/events/core.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index 6e75a5c9412d..9058fc7ca1fb 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -925,11 +925,6 @@ static inline int is_cgroup_event(struct perf_event *event)
 	return 0;
 }
 
-static inline u64 perf_cgroup_event_cgrp_time(struct perf_event *event)
-{
-	return 0;
-}
-
 static inline void update_cgrp_time_from_event(struct perf_event *event)
 {
 }
-- 
2.13.0.219.gdb65acc882-goog

Re: [PATCH] perf/core: Remove unused function perf_cgroup_event_cgrp_time()

[Doug Anderson]

Hi,

On Tue, May 23, 2017 at 2:51 PM, Matthias Kaehlcke <mka@chromium.org> wrote:
> The function was added by commit e5d1367f17ba ("perf: Add cgroup
> support") in 2011 and hasn't been used since then. Removing it fixes the
> following warning when building with clang:
>
>     kernel/events/core.c:696:19: error: unused function
>         'perf_cgroup_event_cgrp_time' [-Werror,-Wunused-function]
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
>  kernel/events/core.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 6e75a5c9412d..9058fc7ca1fb 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -925,11 +925,6 @@ static inline int is_cgroup_event(struct perf_event *event)
>         return 0;
>  }
>
> -static inline u64 perf_cgroup_event_cgrp_time(struct perf_event *event)
> -{
> -       return 0;
> -}
> -
>  static inline void update_cgrp_time_from_event(struct perf_event *event)
>  {
>  }

Definitely seems like no reason to keep this around.  FWIW:

Reviewed-by: Douglas Anderson <dianders@chromium.org>

[tip:perf/core] perf/core: Remove unused perf_cgroup_event_cgrp_time() function

[tip-bot for Matthias Kaehlcke]

Commit-ID:  d0fabd1cb8b70073a0f44f1cf8b663b5e7241c74
Gitweb:     http://git.kernel.org/tip/d0fabd1cb8b70073a0f44f1cf8b663b5e7241c74
Author:     Matthias Kaehlcke <mka@chromium.org>
AuthorDate: Tue, 23 May 2017 14:51:32 -0700
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 8 Jun 2017 10:12:39 +0200

perf/core: Remove unused perf_cgroup_event_cgrp_time() function

The function was added by commit e5d1367f17ba ("perf: Add cgroup
support") in 2011 and hasn't been used since then. Removing it fixes the
following warning when building with Clang:

    kernel/events/core.c:696:19: error: unused function 'perf_cgroup_event_cgrp_time' [-Werror,-Wunused-function]

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Douglas Anderson <dianders@chromium.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20170523215132.189049-1-mka@chromium.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/events/core.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index 407dad6..bc63f8d 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -925,11 +925,6 @@ static inline int is_cgroup_event(struct perf_event *event)
 	return 0;
 }
 
-static inline u64 perf_cgroup_event_cgrp_time(struct perf_event *event)
-{
-	return 0;
-}
-
 static inline void update_cgrp_time_from_event(struct perf_event *event)
 {
 }