[PATCH] Added some addition debug prints for pb_keys

[PATCH] Added some addition debug prints for pb_keys

[Alan Cox]

From: Michael Demeter <michael.demeter@intel.com>

Added additional debug output that we always seem to add
during power ons to validate firmware operation.

Signed-off-by: Michael Demeter <michael.demeter@intel.com>
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Signed-off-by: Alan Cox <alan@linux.intel.com>
---

 arch/x86/platform/mrst/mrst.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)


diff --git a/arch/x86/platform/mrst/mrst.c b/arch/x86/platform/mrst/mrst.c
index a9a4732..3002cc86 100644
--- a/arch/x86/platform/mrst/mrst.c
+++ b/arch/x86/platform/mrst/mrst.c
@@ -1035,6 +1035,8 @@ static int __init pb_keys_init(void)
 	num = sizeof(gpio_button) / sizeof(struct gpio_keys_button);
 	for (i = 0; i < num; i++) {
 		gb[i].gpio = get_gpio_by_name(gb[i].desc);
+		pr_debug("info[%2d]: name = %s,"
+				"gpio = %d\n", i, gb[i].desc, gb[i].gpio);
 		if (gb[i].gpio == -1)
 			continue;
 

Re: [PATCH] Added some addition debug prints for pb_keys

[Ingo Molnar]

* Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

> From: Michael Demeter <michael.demeter@intel.com>
> 
> Added additional debug output that we always seem to add
> during power ons to validate firmware operation.
> 
> Signed-off-by: Michael Demeter <michael.demeter@intel.com>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> ---
> 
>  arch/x86/platform/mrst/mrst.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> 
> diff --git a/arch/x86/platform/mrst/mrst.c b/arch/x86/platform/mrst/mrst.c
> index a9a4732..3002cc86 100644
> --- a/arch/x86/platform/mrst/mrst.c
> +++ b/arch/x86/platform/mrst/mrst.c
> @@ -1035,6 +1035,8 @@ static int __init pb_keys_init(void)
>  	num = sizeof(gpio_button) / sizeof(struct gpio_keys_button);
>  	for (i = 0; i < num; i++) {
>  		gb[i].gpio = get_gpio_by_name(gb[i].desc);
> +		pr_debug("info[%2d]: name = %s,"
> +				"gpio = %d\n", i, gb[i].desc, gb[i].gpio);

I've fixed this to lie on a single line - there's no point in 
line-breaking pr_debug()s in general - especially not the format 
string.

Note that merging the format string unearthed a small formatting 
ugly:

	"info[%2d]: name = %s,gpio = %d\n"

I edited that to the probably intended:

	"info[%2d]: name = %s, gpio = %d\n"

Thanks,

	Ingo

[tip:x86/platform] x86/mrst: Add additional debug prints for pb_keys

[tip-bot for Michael Demeter]

Commit-ID:  d79a8869d8a4b565b12a88faeff834b09a36368c
Gitweb:     http://git.kernel.org/tip/d79a8869d8a4b565b12a88faeff834b09a36368c
Author:     Michael Demeter <michael.demeter@intel.com>
AuthorDate: Thu, 15 Dec 2011 22:31:23 +0000
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Sun, 18 Dec 2011 09:37:07 +0100

x86/mrst: Add additional debug prints for pb_keys

Added additional debug output that we always seem to add
during power ons to validate firmware operation.

Signed-off-by: Michael Demeter <michael.demeter@intel.com>
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Signed-off-by: Alan Cox <alan@linux.intel.com>
Link: http://lkml.kernel.org/r/20111215223116.10166.50803.stgit@bob.linux.org.uk
[ fixed line breaks, formatting and commit title. ]
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/platform/mrst/mrst.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/x86/platform/mrst/mrst.c b/arch/x86/platform/mrst/mrst.c
index 6a21f60..b6a33d2 100644
--- a/arch/x86/platform/mrst/mrst.c
+++ b/arch/x86/platform/mrst/mrst.c
@@ -983,6 +983,7 @@ static int __init pb_keys_init(void)
 	num = sizeof(gpio_button) / sizeof(struct gpio_keys_button);
 	for (i = 0; i < num; i++) {
 		gb[i].gpio = get_gpio_by_name(gb[i].desc);
+		pr_debug("info[%2d]: name = %s, gpio = %d\n", i, gb[i].desc, gb[i].gpio);
 		if (gb[i].gpio == -1)
 			continue;