mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Ingo Molnar <mingo@elte.hu>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	torvalds@linux-foundation.org, arjan@linux.intel.com,
	efault@gmx.de, elendil@planet.nl, peterz@infradead.org,
	tglx@linutronix.de, mingo@elte.hu
Subject: [tip:sched/urgent] Revert "x86, timers: Check for pending timers after (device) interrupts"
Date: Fri, 9 Oct 2009 14:23:35 GMT	[thread overview]
Message-ID: <tip-e7ab0f7b50bc4688fb5cf65de5d42e3b882fb8d1@git.kernel.org> (raw)
In-Reply-To: <20091008064041.67219b13@infradead.org>

Commit-ID:  e7ab0f7b50bc4688fb5cf65de5d42e3b882fb8d1
Gitweb:     http://git.kernel.org/tip/e7ab0f7b50bc4688fb5cf65de5d42e3b882fb8d1
Author:     Ingo Molnar <mingo@elte.hu>
AuthorDate: Fri, 9 Oct 2009 15:58:20 +0200
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Fri, 9 Oct 2009 15:58:20 +0200

Revert "x86, timers: Check for pending timers after (device) interrupts"

This reverts commit 9bcbdd9c58617f1301dd4f17c738bb9bc73aca70.

The real bug producing LatencyTop latencies has been fixed in:

  f5dc375: sched: Update the clock of runqueue select_task_rq() selected

And the commit being reverted here triggers local timer processing
from every device IRQ. If device IRQs come in at a high frequency,
this could cause a performance regression.

The commit being reverted here purely 'fixed' the reported latency
as a side effect, because CPUs were being moved out of idle more
often.

Acked-by: Peter Zijlstra <peterz@infradead.org>
Cc: Arjan van de Ven <arjan@linux.intel.com>
Cc: Frans Pop <elendil@planet.nl>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Thomas Gleixner <tglx@linutronix.de>
LKML-Reference: <20091008064041.67219b13@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/kernel/irq.c |    2 --
 arch/x86/kernel/smp.c |    1 -
 2 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
index 3912061..74656d1 100644
--- a/arch/x86/kernel/irq.c
+++ b/arch/x86/kernel/irq.c
@@ -244,7 +244,6 @@ unsigned int __irq_entry do_IRQ(struct pt_regs *regs)
 				__func__, smp_processor_id(), vector, irq);
 	}
 
-	run_local_timers();
 	irq_exit();
 
 	set_irq_regs(old_regs);
@@ -269,7 +268,6 @@ void smp_generic_interrupt(struct pt_regs *regs)
 	if (generic_interrupt_extension)
 		generic_interrupt_extension();
 
-	run_local_timers();
 	irq_exit();
 
 	set_irq_regs(old_regs);
diff --git a/arch/x86/kernel/smp.c b/arch/x86/kernel/smp.c
index d915d95..ec1de97 100644
--- a/arch/x86/kernel/smp.c
+++ b/arch/x86/kernel/smp.c
@@ -198,7 +198,6 @@ void smp_reschedule_interrupt(struct pt_regs *regs)
 {
 	ack_APIC_irq();
 	inc_irq_stat(irq_resched_count);
-	run_local_timers();
 	/*
 	 * KVM uses this interrupt to force a cpu out of guest mode
 	 */

  parent reply	other threads:[~2009-10-09 14:24 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-05 13:00 [.32-rc3] scheduler: iwlagn consistently high in "waiting for CPU" Frans Pop
2009-10-05 14:13 ` Frans Pop
2009-10-05 14:24   ` Arjan van de Ven
2009-10-06 15:49     ` Frans Pop
2009-10-07 17:10       ` Frans Pop
2009-10-07 18:10         ` Mike Galbraith
2009-10-07 18:34         ` Frans Pop
2009-10-08  4:05           ` Mike Galbraith
2009-10-08  6:23             ` Mike Galbraith
2009-10-08 13:40             ` Arjan van de Ven
2009-10-08 14:13               ` Mike Galbraith
2009-10-08 14:54                 ` Mike Galbraith
2009-10-08 14:55               ` Frans Pop
2009-10-08 15:09                 ` Arjan van de Ven
2009-10-08 18:23                 ` Mike Galbraith
2009-10-08 20:34                   ` Markus Trippelsdorf
2009-10-09  3:35                     ` Mike Galbraith
2009-10-09  3:51                       ` Markus Trippelsdorf
2009-10-08 20:59                   ` Frans Pop
2009-10-09  3:04                     ` Mike Galbraith
2009-10-09  6:35                     ` Mike Galbraith
2009-10-09  7:13                       ` Peter Zijlstra
2009-10-09  7:55                       ` Sedat Dilek
2009-10-09  8:06                         ` Peter Zijlstra
2009-10-09 14:23                       ` [tip:sched/urgent] sched: Update the clock of runqueue select_task_rq() selected tip-bot for Mike Galbraith
2009-10-09 16:27                       ` [.32-rc3] scheduler: iwlagn consistently high in "waiting for CPU" Frans Pop
2009-10-09 20:06                         ` Mike Galbraith
2009-10-08 15:30               ` [tip:timers/urgent] x86, timers: Check for pending timers after (device) interrupts tip-bot for Arjan van de Ven
2009-10-09 14:23               ` tip-bot for Ingo Molnar [this message]
2009-10-08 11:24           ` [.32-rc3] scheduler: iwlagn consistently high in "waiting for CPU" Mike Galbraith
2009-10-08 13:09             ` Frans Pop
2009-10-08 13:18               ` Mike Galbraith
2009-10-08 13:45             ` Arjan van de Ven
2009-10-08 14:15               ` Mike Galbraith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-e7ab0f7b50bc4688fb5cf65de5d42e3b882fb8d1@git.kernel.org \
    --to=mingo@elte.hu \
    --cc=arjan@linux.intel.com \
    --cc=efault@gmx.de \
    --cc=elendil@planet.nl \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome