linux-next: origin tree build warning

linux-next: origin tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1655 bytes --]

Hi ,

Today's linux-next build (x86_64 allmodconfig) produced this warning:

arch/x86/mm/mmio-mod.c: In function 'print_pte':
arch/x86/mm/mmio-mod.c:100: warning: too many arguments for format
arch/x86/mm/mmio-mod.c:106: warning: too many arguments for format
arch/x86/mm/mmio-mod.c:110: warning: too many arguments for format
arch/x86/mm/mmio-mod.c: In function 'die_kmmio_nesting_error':
arch/x86/mm/mmio-mod.c:123: warning: too many arguments for format
arch/x86/mm/mmio-mod.c:134: warning: too many arguments for format
arch/x86/mm/mmio-mod.c:136: warning: too many arguments for format
arch/x86/mm/mmio-mod.c: In function 'mmiotrace_ioremap':
arch/x86/mm/mmio-mod.c:286: warning: too many arguments for format
arch/x86/mm/mmio-mod.c: In function 'iounmap_trace_core':
arch/x86/mm/mmio-mod.c:305: warning: too many arguments for format
arch/x86/mm/mmio-mod.c: In function 'clear_trace_list':
arch/x86/mm/mmio-mod.c:367: warning: too many arguments for format
arch/x86/mm/mmio-mod.c: In function 'enter_uniprocessor':
arch/x86/mm/mmio-mod.c:404: warning: too many arguments for format
arch/x86/mm/mmio-mod.c:406: warning: too many arguments for format
arch/x86/mm/mmio-mod.c: In function 'leave_uniprocessor':
arch/x86/mm/mmio-mod.c:426: warning: too many arguments for format
arch/x86/mm/mmio-mod.c:428: warning: too many arguments for format

Caused by commit 3a0340be06a9356eb61f6804107480acbe62c069 ("x86:
mmio-mod.c: Use pr_fmt").  Was this even build tested?  The patch doesn't
even match the commit message.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: origin tree build warning

[Joe Perches]

On Mon, 2009-12-14 at 10:24 +1100, Stephen Rothwell wrote:
> Today's linux-next build (x86_64 allmodconfig) produced this warning:
> 
> arch/x86/mm/mmio-mod.c: In function 'print_pte':
> Caused by commit 3a0340be06a9356eb61f6804107480acbe62c069 ("x86:
> mmio-mod.c: Use pr_fmt").  Was this even build tested?  The patch doesn't
> even match the commit message.

Dunno how that happened, it was tested here
with #define pr_fmt(fmt) "mmiotrace: " fmt

Here's the diff necessary to make it work.

Signed-off-by: Joe Perches <joe@perches.com>

diff --git a/arch/x86/mm/mmio-mod.c b/arch/x86/mm/mmio-mod.c
index 4c765e9..34a3291 100644
--- a/arch/x86/mm/mmio-mod.c
+++ b/arch/x86/mm/mmio-mod.c
@@ -20,7 +20,7 @@
  * Derived from the read-mod example from relay-examples by Tom Zanussi.
  */
 
-#define pr_fmt(fmt) "mmiotrace: "
+#define pr_fmt(fmt) "mmiotrace: " fmt
 
 #define DEBUG 1
 

[tip:x86/urgent] x86: Fix build warning in arch/x86/mm/mmio-mod.c

[tip-bot for Joe Perches]

Commit-ID:  eba11d6da7a983cedb0acf32a38e4d0daa8b5d0e
Gitweb:     http://git.kernel.org/tip/eba11d6da7a983cedb0acf32a38e4d0daa8b5d0e
Author:     Joe Perches <joe@perches.com>
AuthorDate: Sun, 13 Dec 2009 23:24:03 -0800
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Mon, 14 Dec 2009 08:55:43 +0100

x86: Fix build warning in arch/x86/mm/mmio-mod.c

Stephen Rothwell reported these warnings:

 arch/x86/mm/mmio-mod.c: In function 'print_pte':
 arch/x86/mm/mmio-mod.c:100: warning: too many arguments for format
 arch/x86/mm/mmio-mod.c:106: warning: too many arguments for format

The 'fmt' was left out accidentally.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Joe Perches <joe@perches.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Linus <torvalds@linux-foundation.org>
LKML-Reference: <1260775443.18538.16.camel@Joe-Laptop.home>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/mm/mmio-mod.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/mm/mmio-mod.c b/arch/x86/mm/mmio-mod.c
index 4c765e9..34a3291 100644
--- a/arch/x86/mm/mmio-mod.c
+++ b/arch/x86/mm/mmio-mod.c
@@ -20,7 +20,7 @@
  * Derived from the read-mod example from relay-examples by Tom Zanussi.
  */
 
-#define pr_fmt(fmt) "mmiotrace: "
+#define pr_fmt(fmt) "mmiotrace: " fmt
 
 #define DEBUG 1