* [PATCH] x86,perf: P4 PMU -- fix misprint in unflagged nmi handling
@ 2010-05-18 9:29 Lin Ming
2010-05-18 14:54 ` [tip:perf/core] perf, x86: P4 PMU -- fix typo in unflagged NMI handling tip-bot for Cyrill Gorcunov
0 siblings, 1 reply; 2+ messages in thread
From: Lin Ming @ 2010-05-18 9:29 UTC (permalink / raw)
To: Cyrill Gorcunov, Ingo Molnar; +Cc: lkml
From: Cyrill Gorcunov <gorcunov@openvz.org>
Subject: [PATCH] x86,perf: P4 PMU -- fix misprint in unflagged nmi handling
Tested-by: Lin Ming <ming.m.lin@intel.com>
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
---
arch/x86/kernel/cpu/perf_event_p4.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/cpu/perf_event_p4.c b/arch/x86/kernel/cpu/perf_event_p4.c
index f44ce8d..e695795 100644
--- a/arch/x86/kernel/cpu/perf_event_p4.c
+++ b/arch/x86/kernel/cpu/perf_event_p4.c
@@ -473,7 +473,7 @@ static inline int p4_pmu_clear_cccr_ovf(struct hw_perf_event *hwc)
rdmsr(hwc->config_base + hwc->idx, low, high);
/* we need to check high bit for unflagged overflows */
- if ((low & P4_CCCR_OVF) || (high & (1 << 31))) {
+ if ((low & P4_CCCR_OVF) || !(high & (1 << 31))) {
overflow = 1;
(void)checking_wrmsrl(hwc->config_base + hwc->idx,
((u64)low) & ~P4_CCCR_OVF);
^ permalink raw reply [flat|nested] 2+ messages in thread* [tip:perf/core] perf, x86: P4 PMU -- fix typo in unflagged NMI handling
2010-05-18 9:29 [PATCH] x86,perf: P4 PMU -- fix misprint in unflagged nmi handling Lin Ming
@ 2010-05-18 14:54 ` tip-bot for Cyrill Gorcunov
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Cyrill Gorcunov @ 2010-05-18 14:54 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, gorcunov, ming.m.lin, tglx, gorcunov, mingo
Commit-ID: ef4f30f54e265c2f6f9ac9eda4db158a4e16050b
Gitweb: http://git.kernel.org/tip/ef4f30f54e265c2f6f9ac9eda4db158a4e16050b
Author: Cyrill Gorcunov <gorcunov@openvz.org>
AuthorDate: Tue, 18 May 2010 17:29:14 +0800
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 18 May 2010 12:05:20 +0200
perf, x86: P4 PMU -- fix typo in unflagged NMI handling
Tested-by: Lin Ming <ming.m.lin@intel.com>
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>
LKML-Reference: <1274174954.22793.17.camel@minggr.sh.intel.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/cpu/perf_event_p4.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/cpu/perf_event_p4.c b/arch/x86/kernel/cpu/perf_event_p4.c
index 02f0728..87e1803 100644
--- a/arch/x86/kernel/cpu/perf_event_p4.c
+++ b/arch/x86/kernel/cpu/perf_event_p4.c
@@ -473,7 +473,7 @@ static inline int p4_pmu_clear_cccr_ovf(struct hw_perf_event *hwc)
rdmsr(hwc->config_base + hwc->idx, low, high);
/* we need to check high bit for unflagged overflows */
- if ((low & P4_CCCR_OVF) || (high & (1 << 31))) {
+ if ((low & P4_CCCR_OVF) || !(high & (1 << 31))) {
overflow = 1;
(void)checking_wrmsrl(hwc->config_base + hwc->idx,
((u64)low) & ~P4_CCCR_OVF);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-18 14:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-05-18 9:29 [PATCH] x86,perf: P4 PMU -- fix misprint in unflagged nmi handling Lin Ming
2010-05-18 14:54 ` [tip:perf/core] perf, x86: P4 PMU -- fix typo in unflagged NMI handling tip-bot for Cyrill Gorcunov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome