From: tip-bot for Dima Kogan <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: hpa@zytor.com, linux-kernel@vger.kernel.org, tglx@linutronix.de,
dima@secretsauce.net, mingo@kernel.org, acme@redhat.com
Subject: [tip:perf/core] perf symbols: Fix type error when reading a build-id
Date: Thu, 29 Oct 2015 02:42:02 -0700 [thread overview]
Message-ID: <tip-f2f3096888569ff1fc15fa0187a39eef3a24b28e@git.kernel.org> (raw)
In-Reply-To: <87si6pfwz4.fsf@secretsauce.net>
Commit-ID: f2f3096888569ff1fc15fa0187a39eef3a24b28e
Gitweb: http://git.kernel.org/tip/f2f3096888569ff1fc15fa0187a39eef3a24b28e
Author: Dima Kogan <dima@secretsauce.net>
AuthorDate: Mon, 7 Sep 2015 17:30:28 -0700
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 28 Oct 2015 10:02:00 -0300
perf symbols: Fix type error when reading a build-id
This was benign, but wrong. The build-id should live in a char[], not a char*[]
Signed-off-by: Dima Kogan <dima@secretsauce.net>
Link: http://lkml.kernel.org/r/87si6pfwz4.fsf@secretsauce.net
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/symbol-minimal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/symbol-minimal.c b/tools/perf/util/symbol-minimal.c
index fd8477c..4890633 100644
--- a/tools/perf/util/symbol-minimal.c
+++ b/tools/perf/util/symbol-minimal.c
@@ -337,7 +337,7 @@ int dso__load_sym(struct dso *dso, struct map *map __maybe_unused,
symbol_filter_t filter __maybe_unused,
int kmodule __maybe_unused)
{
- unsigned char *build_id[BUILD_ID_SIZE];
+ unsigned char build_id[BUILD_ID_SIZE];
int ret;
ret = fd__is_64_bit(ss->fd);
next prev parent reply other threads:[~2015-10-29 9:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 2:47 [PATCH 0/2] perf: we can now read separate debug-info files based on a build ID Dima Kogan
2015-09-16 18:50 ` Dima Kogan
2015-10-28 2:50 ` Dima Kogan
2015-10-28 12:59 ` Arnaldo Carvalho de Melo
2015-10-29 9:42 ` tip-bot for Dima Kogan [this message]
2015-10-29 9:42 ` [tip:perf/core] perf symbols: " tip-bot for Dima Kogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-f2f3096888569ff1fc15fa0187a39eef3a24b28e@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=dima@secretsauce.net \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome